Merge lp:~cboylan/boots/boots_bug_fixes into lp:boots

Proposed by Clark Boylan
Status: Merged
Merged at revision: not available
Proposed branch: lp:~cboylan/boots/boots_bug_fixes
Merge into: lp:boots
Diff against target: 19 lines (+0/-5)
1 file modified
boots/lib/ui/plain.py (+0/-5)
To merge this branch: bzr merge lp:~cboylan/boots/boots_bug_fixes
Reviewer Review Type Date Requested Status
David Rosenbaum Approve
Review via email: mp+19681@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Clark Boylan (cboylan) wrote :

Clean up readline use. Fixes negative index bug.

Revision history for this message
David Rosenbaum (davidjrosenbaum) wrote :

Merged

review: Approve
lp:~cboylan/boots/boots_bug_fixes updated
66. By David Rosenbaum

Merge of Clark's bug fix.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'boots/lib/ui/plain.py'
2--- boots/lib/ui/plain.py 2010-02-17 03:49:02 +0000
3+++ boots/lib/ui/plain.py 2010-02-19 04:12:17 +0000
4@@ -88,15 +88,10 @@
5 lines = line + "\n"
6 command = self.console.input_complete(line, self.lingo)
7 while command is None:
8- if line:
9- readline.remove_history_item(readline.get_current_history_length()-1)
10 line = raw_input(self.prompt2)
11 lines += line + "\n"
12 command = self.console.input_complete(lines, self.lingo)
13
14- # When adding each history item, strip the last newline; otherwise newlines will
15- # accumulate when history commands are reused.
16- readline.replace_history_item(readline.get_current_history_length()-1, lines[:-1])
17 yield command, self.lingo
18
19 except EOFError:

Subscribers

People subscribed via source and target branches

to status/vote changes: