Juju Charms Collection
ubuntu package

Code review comment for lp:~cbjchen/charms/trusty/ubuntu/lxc-network-config

  1. Trusty Tahr (14.04)
  2. lxc-network-config
  3. Merge into trunk
Revision history for this message
Liang Chen (cbjchen) wrote :

Hi Adam and Antonio,

Thanks for the review, and thanks for the help to supply the the documentation and tests. It makes sense to me to set the default value to false. I was just trying to make sure the behavior is the same as the previous version by default. I took a look at the patch, and it looks good to me.

« Back to merge proposal