Merge lp:~cbjchen/charms/trusty/neutron-gateway/metadata-api-config-fix into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by Liang Chen
Status: Merged
Merged at revision: 118
Proposed branch: lp:~cbjchen/charms/trusty/neutron-gateway/metadata-api-config-fix
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 38 lines (+1/-5)
3 files modified
hooks/neutron_utils.py (+1/-3)
templates/havana/nova.conf (+0/-1)
tests/basic_deployment.py (+0/-1)
To merge this branch: bzr merge lp:~cbjchen/charms/trusty/neutron-gateway/metadata-api-config-fix
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+259152@code.launchpad.net

Description of the change

Remove unnecessary db config for nova-metadata-api. Since nova-metadata-api only access db through nova-conductor, and the db config was left wrong when db relation is not ready.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

This generally looks fine, but please can add

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/neutron_utils.py'
2--- hooks/neutron_utils.py 2015-05-07 09:33:38 +0000
3+++ hooks/neutron_utils.py 2015-05-14 18:34:10 +0000
4@@ -299,9 +299,7 @@
5
6 NOVA_CONFIG_FILES = {
7 NOVA_CONF: {
8- 'hook_contexts': [context.SharedDBContext(ssl_dir=NOVA_CONF_DIR),
9- context.PostgresqlDBContext(),
10- NetworkServiceContext(),
11+ 'hook_contexts': [NetworkServiceContext(),
12 NeutronGatewayContext(),
13 SyslogContext(),
14 context.ZeroMQContext(),
15
16=== modified file 'templates/havana/nova.conf'
17--- templates/havana/nova.conf 2014-09-10 10:24:49 +0000
18+++ templates/havana/nova.conf 2015-05-14 18:34:10 +0000
19@@ -12,7 +12,6 @@
20 api_paste_config=/etc/nova/api-paste.ini
21 enabled_apis=metadata
22 multi_host=True
23-{% include "parts/database" %}
24 neutron_metadata_proxy_shared_secret={{ shared_secret }}
25 service_neutron_metadata_proxy=True
26 # Access to message bus
27
28=== modified file 'tests/basic_deployment.py'
29--- tests/basic_deployment.py 2015-04-24 10:07:10 +0000
30+++ tests/basic_deployment.py 2015-05-14 18:34:10 +0000
31@@ -551,7 +551,6 @@
32 'api_paste_config': '/etc/nova/api-paste.ini',
33 'enabled_apis': 'metadata',
34 'multi_host': 'True',
35- 'sql_connection': db_uri,
36 'service_neutron_metadata_proxy': 'True',
37 'rabbit_userid': 'neutron',
38 'rabbit_virtual_host': 'openstack',

Subscribers

People subscribed via source and target branches