Code review comment for lp:~cbehrens/nova/servers-search

Revision history for this message
Brian Lamar (blamar) wrote :

This seems like a pretty inefficient way to do filtering if all we're looking for is wildcard matching. Why return everything when SQLAlchemy should successfully provide filtering across multiple backends? Can this be done using something like...

query.filter(Instance.name.like('%test%'))

...rather than returning each row and doing a regex?

review: Needs Fixing

« Back to merge proposal