Merge lp:~cbehrens/nova/bug614090 into lp:~hudson-openstack/nova/trunk

Proposed by Chris Behrens
Status: Merged
Approved by: Eric Day
Approved revision: 207
Merge reported by: OpenStack Infra
Merged at revision: not available
Proposed branch: lp:~cbehrens/nova/bug614090
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
nova/virt/images.py (+1/-1)
To merge this branch: bzr merge lp:~cbehrens/nova/bug614090
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Review via email: mp+31914@code.launchpad.net

Commit message

Change nova/virt/images.py's _fetch_local_image to accept 4 args, since fetch() tries to call it with that many.

Description of the change

Change nova/virt/images.py's _fetch_local_image to accept 4 args, since fetch() tries to call it with that many.

To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

This looks fine, although this code is all fixed and changed in ewan's branch. Perhaps we can just merge that one?

lp:~ewanmellor/nova/xenapi

Revision history for this message
Vish Ishaya (vishvananda) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/virt/images.py'
2--- nova/virt/images.py 2010-07-30 22:19:41 +0000
3+++ nova/virt/images.py 2010-08-05 23:31:06 +0000
4@@ -65,7 +65,7 @@
5 cmd += ['-o', path]
6 return process.SharedPool().execute(executable=cmd[0], args=cmd[1:])
7
8-def _fetch_local_image(image, path, _):
9+def _fetch_local_image(image, path, user, project):
10 source = _image_path('%s/image' % image)
11 return process.simple_execute('cp %s %s' % (source, path))
12