Merge lp:~carlos.ribeiro/nuvola-player/nuvola-player into lp:nuvola-player/2.5.x

Proposed by Jiří Janoušek
Status: Merged
Approved by: Jiří Janoušek
Approved revision: 760
Merged at revision: 768
Proposed branch: lp:~carlos.ribeiro/nuvola-player/nuvola-player
Merge into: lp:nuvola-player/2.5.x
Diff against target: 61 lines (+9/-9)
1 file modified
data/nuvolaplayer/services/deezer/integration.js (+9/-9)
To merge this branch: bzr merge lp:~carlos.ribeiro/nuvola-player/nuvola-player
Reviewer Review Type Date Requested Status
Jiří Janoušek Approve
Michał Pawłowski Pending
Review via email: mp+185252@code.launchpad.net

Description of the change

Bug: Service deezer loading, but toolbar actions not working.
Fixed implementation.js

To post a comment you must log in.
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

I have no formal objections. However, I haven't tested the fix and approval of Michał Pawłowski, the maintainer of Deezer service integration, is needed.

review: Abstain
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

I'm making an exception and I'm merging the fix without wating for approval from the service maitainer. The reason is the fact that I would like to release Nuvola Player 2.2.0 today and discontinue active development, so it might be a long time until a new maintainer is found to merge the fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/nuvolaplayer/services/deezer/integration.js'
2--- data/nuvolaplayer/services/deezer/integration.js 2012-10-02 17:43:51 +0000
3+++ data/nuvolaplayer/services/deezer/integration.js 2013-09-12 12:53:24 +0000
4@@ -46,8 +46,8 @@
5 var can_thumbs_down;
6
7 try{
8- var play = $('#h_play a');
9- var pause = $('#h_pause a');
10+ var play = window.playercontrol.$btnPlay;
11+ var pause = window.playercontrol.$btnPause;
12
13 if (play.is(':visible')) {
14 state = Nuvola.STATE_PAUSED;
15@@ -56,8 +56,8 @@
16 }
17
18 if(state != Nuvola.STATE_NONE){
19- can_prev = !$('#h_previous a').hasClass('disabled');
20- can_next = !$('#h_next a').hasClass('disabled');
21+ can_prev = !window.playercontrol.$btnPrevious.hasClass('disabled');
22+ can_next = !window.playercontrol.$btnNext.hasClass('disabled');
23
24 var td_btn = $('#like_track.bad-song');
25 can_thumbs_down = td_btn.length>0 && td_btn.is(':visible');
26@@ -70,8 +70,8 @@
27 can_prev = can_next = can_thumbs_down = false;
28 }
29
30- var song = $('#current-track').text();
31- var artist = $('#current-artist').text();
32+ var song = window.playercontrol.$labelSongTitle.text();
33+ var artist = window.playercontrol.$labelArtName.text();
34 var last_song = song + '-' + artist;
35
36 // album art - only on radio mode
37@@ -84,7 +84,7 @@
38 this.last_song = last_song;
39
40 try {
41- var img = $('#radio_thumbs li img').first();
42+ var img = $('#thumb_0 img').first();
43
44 if (img.length) {
45 this.last_art = img.attr('src');
46@@ -115,7 +115,7 @@
47 try {
48 switch(message){
49 case Nuvola.ACTION_TOGGLE_PLAY:
50- if ($('#h_play a').is(':visible')) {
51+ if (window.playercontrol.$btnPlay.is(':visible')) {
52 window.playercontrol.doAction('play');
53 } else {
54 window.playercontrol.doAction('pause');
55@@ -146,4 +146,4 @@
56 }
57
58 Nuvola.integration = new Integration(); // Singleton
59-})(this);
60+})(this);
61\ No newline at end of file

Subscribers

People subscribed via source and target branches