Merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 into lp:ubuntu-filemanager-app
Proposed by
Carlos Jose Mazieri
Status: | Merged |
---|---|
Approved by: | Arto Jalkanen |
Approved revision: | 515 |
Merged at revision: | 517 |
Proposed branch: | lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 |
Merge into: | lp:ubuntu-filemanager-app |
Prerequisite: | lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-03 |
Diff against target: |
391 lines (+272/-17) 8 files modified
src/plugin/folderlistmodel/CMakeLists.txt (+4/-0) src/plugin/folderlistmodel/folderlistmodel.pri (+6/-3) src/plugin/folderlistmodel/networklistworker.cpp (+74/-0) src/plugin/folderlistmodel/networklistworker.h (+54/-0) src/plugin/folderlistmodel/networklocation.cpp (+41/-0) src/plugin/folderlistmodel/networklocation.h (+89/-0) src/plugin/folderlistmodel/smb/smblocation.cpp (+1/-8) src/plugin/folderlistmodel/smb/smblocation.h (+3/-6) |
To merge this branch: | bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Arto Jalkanen | Approve | ||
Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+280390@code.launchpad.net |
Commit message
* Created new and generic classes: NetworkLocation and NetworkListWorker
* SmbLocation now inherits from the generic NetworkLocation instead of Location
* SmbListWorker class is no longer used and it will be removed
* NetworkListWorker really performs the loading on a secondary thread
Description of the change
* Created new and generic classes: NetworkLocation and NetworkListWorker
* SmbLocation now inherits from the generic NetworkLocation instead of Location
* SmbListWorker class is no longer used and it will be removed
* NetworkListWorker really performs the loading on a secondary thread
To post a comment you must log in.
PASSED: Continuous integration, rev:515 /core-apps- jenkins. ubuntu. com/job/ filemanager- app-ci/ 40/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/254/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ filemanager- app-ci/ 40/rebuild
https:/