Merge lp:~carlos-mazieri/ubuntu-filemanager-app/bug-openPath into lp:ubuntu-filemanager-app

Proposed by Carlos Jose Mazieri
Status: Merged
Approved by: Carlos Jose Mazieri
Approved revision: 213
Merged at revision: 214
Proposed branch: lp:~carlos-mazieri/ubuntu-filemanager-app/bug-openPath
Merge into: lp:ubuntu-filemanager-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/plugin/folderlistmodel/locationsfactory.cpp (+1/-0)
To merge this branch: bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/bug-openPath
Reviewer Review Type Date Requested Status
Carlos Jose Mazieri Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+224535@code.launchpad.net

Commit message

fixes the bug #1330223.

Description of the change

fixes the bug #1330223.

LocationsFactory::setNewPath() must return NULL when the item is a file.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

I am approving myself since it is very simple.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/plugin/folderlistmodel/locationsfactory.cpp'
2--- src/plugin/folderlistmodel/locationsfactory.cpp 2014-05-24 01:40:01 +0000
3+++ src/plugin/folderlistmodel/locationsfactory.cpp 2014-06-25 22:58:09 +0000
4@@ -131,6 +131,7 @@
5 else
6 {
7 storeValidFileInfo(item);
8+ location = 0;
9 }
10 }
11 else

Subscribers

People subscribed via source and target branches