Merge lp:~carlos-mazieri/ubuntu-filemanager-app/app-removed-code-about-old-properties into lp:ubuntu-filemanager-app

Proposed by Carlos Jose Mazieri
Status: Merged
Approved by: Carlos Jose Mazieri
Approved revision: 76
Merged at revision: 83
Proposed branch: lp:~carlos-mazieri/ubuntu-filemanager-app/app-removed-code-about-old-properties
Merge into: lp:ubuntu-filemanager-app
Diff against target: 57 lines (+8/-34)
1 file modified
FolderListPage.qml (+8/-34)
To merge this branch: bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/app-removed-code-about-old-properties
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michael Spencer Approve
Review via email: mp+190502@code.launchpad.net

Commit message

removed code related to old properties that do not exist anymore

Description of the change

removed code related to old properties that do not exist anymore

To post a comment you must log in.
Revision history for this message
Michael Spencer (ibelieve) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'FolderListPage.qml'
2--- FolderListPage.qml 2013-09-28 18:48:28 +0000
3+++ FolderListPage.qml 2013-10-10 22:45:36 +0000
4@@ -88,45 +88,19 @@
5 pageModel.refresh()
6 }
7
8- // For these 3 functions: pathAccessedDate(), pathModifiedDate() and pathModifiedDate()
9- // we are using a temporary construction to ask if a such property exists in the model
10- //
11- // Right now all properties exist: "pathAccessedDate", "pathModifiedDate" and "pathIsWritable"
12- // but they will be removed and the corresponding READ functions: pathAccessedDate(),
13- // pathModifiedDate() and pathIsWritable() will become Q_INVOKABLE() replacing the prefix "path" for
14- // "curPath".
15- // This construction will allow the File Manager to keep working while we change the model
16- // after changing the model, this construction can be removed
17-
18 function pathAccessedDate() {
19- if ("pathAccessedDate" in pageModel) {
20- console.log("using property pathAccessedDate")
21- return pageModel.pathAccessedDate
22- }
23- else {
24- console.log("calling method pageModel.curPathAccessedDate()")
25- return pageModel.curPathAccessedDate()
26- }
27+ console.log("calling method pageModel.curPathAccessedDate()")
28+ return pageModel.curPathAccessedDate()
29 }
30+
31 function pathModifiedDate() {
32- if ("pathModifiedDate" in pageModel) {
33- console.log("using property pathModifiedDate")
34- return pageModel.pathModifiedDate
35- }
36- else {
37- console.log("calling method pageModel.curPathModifiedDate()")
38- return pageModel.curPathModifiedDate()
39- }
40+ console.log("calling method pageModel.curPathModifiedDate()")
41+ return pageModel.curPathModifiedDate()
42 }
43+
44 function pathIsWritable() {
45- if ("pathIsWritable" in pageModel) {
46- console.log("using property pathIsWritable");
47- return pageModel.pathIsWritable
48- }
49- else {
50- console.log("calling method pageModel.curPathIsWritable()")
51- return pageModel.curPathIsWritable()
52- }
53+ console.log("calling method pageModel.curPathIsWritable()")
54+ return pageModel.curPathIsWritable()
55 }
56
57 // FIXME: hard coded path for icon, assumes Ubuntu desktop icon available.

Subscribers

People subscribed via source and target branches