Merge lp:~carla-sella/ubuntu-rssreader-app/unique-random-topic into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Carla Sella
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 374
Merged at revision: 383
Proposed branch: lp:~carla-sella/ubuntu-rssreader-app/unique-random-topic
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 23 lines (+3/-1)
1 file modified
tests/autopilot/shorts_app/tests/test_rssreader.py (+3/-1)
To merge this branch: bzr merge lp:~carla-sella/ubuntu-rssreader-app/unique-random-topic
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs Pending
Review via email: mp+253281@code.launchpad.net

Commit message

Autopilot tests for Shorts App.

Description of the change

Added unique random topic name to avoid creating topic in non clean env.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Nice one, thanks Carla!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/shorts_app/tests/test_rssreader.py'
2--- tests/autopilot/shorts_app/tests/test_rssreader.py 2015-01-30 19:39:48 +0000
3+++ tests/autopilot/shorts_app/tests/test_rssreader.py 2015-03-17 21:12:56 +0000
4@@ -20,6 +20,7 @@
5 from testtools.matchers import Equals, NotEquals
6
7 from shorts_app.tests import ShortsAppTestCase
8+import uuid
9 import logging
10
11 logger = logging.getLogger(__name__)
12@@ -33,9 +34,10 @@
13
14 def setUp(self):
15 super(BaseShortsAppTestCase, self).setUp()
16+ unique_id = str(uuid.uuid1())
17 self.test_feed_url = _EXTERNAL_FEED_URL
18 self.test_feed_title = _EXTERNAL_FEED_TITLE
19- self.test_topic = 'Test topic'
20+ self.test_topic = 'Test topic {}'.format(unique_id)
21 self.test_change_topic = 'Ubuntu'
22
23 # wait for any updates to finish before beginning tests

Subscribers

People subscribed via source and target branches