Merge lp:~carla-sella/ubuntu-rssreader-app/tests-refactoring into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

[Carla Sella]

refactored tests

I have an issue on getting the current tab (currentTab = tabs.get_current_tab()) :
Running test test_view_mode gives me this error: http://paste.ubuntu.com/7062392/.
But with autopilot vis I can see there is a tab with index 1 : http://ubuntuone.com/5BNa2F1hYxrgHJVfcbNcaz http://ubuntuone.com/0ob4TJNKhp4NA6VHqsvJJZ.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:188
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/190/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1912
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/190
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/190
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/77

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/190/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:188
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/191/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1926
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/191
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/191
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/78

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/191/rebuild

review: Needs Fixing (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Carla, rebase your branch to trunk, I think that should solve this issue. If not, we should file a bug.

[Nicholas Skaggs (nskaggs)]

I get one failure

Traceback (most recent call last):
  File "/home/nskaggs/projects/ubuntutouch/merges/tests-refactoring/tests/autopilot/shorts_app/tests/test_rssreader.py", line 239, in test_remove_feed_and_topic
    self._remove_feed(test_feed_title, test_topic)
  File "/home/nskaggs/projects/ubuntutouch/merges/tests-refactoring/tests/autopilot/shorts_app/tests/test_rssreader.py", line 127, in _remove_feed
    Eventually(Equals([])))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: After 10.0 seconds test failed: !=:
reference = []
actual = [<autopilot.introspection.dbus.FeedComponent object at 0x7ff0c6785f50>]

Ran 5 tests in 92.746s
FAILED (failures=1)

[Nicholas Skaggs (nskaggs)]

This is potentially a bug.

$ shorts-app
file:///usr/share/shorts-app/shorts-app.qml:351 Type SavedTab unavailable
file:///usr/share/shorts-app/SavedTab.qml:20 ListModePage is not a type

[Carla Sella (carla-sella)]

For the shorts-app error launching it in terminal I reported bug 1300969.

[Carla Sella (carla-sella)]

Nicholas, I branched rssreader-app from trunk and put my tests back in but I am having the same exact problem: "ToolkitEmulatorException: There is no tab with index 1."
The test giving me touble is the test_view_mode one, I forgot to comment the @unittest.skip("Can't get tabs'") line (line 244).

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:188
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/192/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1937
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/192
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/192
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/79

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/192/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

188. By Carla Sella on 2014-03-10

Commented tests with problems.

187. By Carla Sella on 2014-03-09

Other fixes for refactoring of existing tests.

186. By Carla Sella on 2014-03-09

Started refactoring tests.

=== modified file 'tests/autopilot/shorts_app/emulators.py'
--- tests/autopilot/shorts_app/emulators.py	2014-03-04 01:30:51 +0000
+++ tests/autopilot/shorts_app/emulators.py	2014-03-28 20:47:58 +0000
@@ -204,15 +204,27 @@
     def get_topic_tab(self, topic):
         return self.wait_select_single("TopicTab", title=topic)
 
+    @autopilot_logging.log_action(logger.info)
+    def get_tab_ListModePage(self):
+        """Get topic tab GridModePage page """
+        logger.debug("get_tab_ListModePage: get_tabs")
+        tabs = self.get_tabs()
+        logger.debug("get_tab_ListModePage: get_current_tab")
+        currentTab = tabs.get_current_tab()
+        logger.debug("get_tab_ListModePage: tab.visible.wait_for True")
+        currentTab.visible.wait_for(True)
+        return currentTab.wait_select_single("ListModePage")
+
+    @autopilot_logging.log_action(logger.info)
     def get_feed_in_feedlist(self, topic, feed):
-        itemList = self.get_feedlist(topic)
+        itemList = self._get_feedlist(topic)
         for item in itemList:
             label = item.select_single("Label", objectName="labelFeedname")
             if label.text == feed:
                 return item
 
-    def get_feedlist(self, topic):
-        #tab = self.get_topic_tab(topic)
+    def _get_feedlist(self, topic):
+        logger.debug("_get_feedlist: select feedlistitems")
         items = self.select_many("UbuntuShape", objectName="feedlistitems")
         return items
 

=== modified file 'tests/autopilot/shorts_app/tests/test_rssreader.py'
--- tests/autopilot/shorts_app/tests/test_rssreader.py	2014-03-04 04:12:32 +0000
+++ tests/autopilot/shorts_app/tests/test_rssreader.py	2014-03-28 20:47:58 +0000
@@ -241,60 +241,39 @@
         #remove added topic
         self._remove_topic(test_topic)
 
-    @unittest.skip("Tab switching fails")
-    def test_view_mode_and_feed_item(self):
-        """test view modes and ensure feed items can be opened"""
-        test_feed_url = 'http://www.canonical.com/rss.xml'
-        test_feed_title = 'Insights'
-        test_topic = 'Test topic'
-
-        self.add_feed_to_new_topic(test_feed_url, test_feed_title, test_topic)
-
-        #verify we are on the editTopic Tab
-        editTab = self.main_view.get_topic_tab(test_topic)
-        self.assertThat(lambda: editTab.visible, Eventually(Equals(True)))
-
-        #open toolbar
+    @unittest.skip("Can't get tabs'")
+    def test_view_mode(self):
+        """test view modes (list mode and grid mode)"""
+
         toolbar = self.main_view.open_toolbar()
-
-        #click on refresh  toolbar button
         toolbar.click_button("rsspagerefreshbutton")
-
-        #wait for any updates to finish before continuing tests
         self._wait_for_refresh()
-
-        #open toolbar
         toolbar = self.main_view.open_toolbar()
-
-        #click on list view toolbar button
         toolbar.click_button("changemodebutton")
 
-        #TODO FIX WHY THIS WON'T SWITCH TO THE PROPER TAB
-        #switch to the feed
-        #header = self.main_view.get_header()
-        #header.switch_to_next_tab()
-        #self.main_view.get_header().switch_to_next_tab()
-        #feedTab = self.main_view.get_topic_tab(topicName)
-        #self.pointing_device.click_object(feedTab)
-        #self.assertThat(lambda: feedTab.visible, Eventually(Equals(True)))
-
-        #select feed entry
-        self.assertThat(lambda: self.main_view.get_feedlist(test_topic),
-                        Eventually(Not(Is(None))))
-        editFeed = self.main_view.get_feedlist(test_topic)
-
-        for item in editFeed:
-            label = item.select_single("Label", objectName="labelFeedname")
-            logger.debug("editFeed: " + str(label.text))
-
-        #click on the first entry in the list
-        self.pointing_device.click_object(editFeed[0])
-
-        #verify we are on RSS feed page
-        rssfeedpage = lambda: self.main_view.get_rss_feed_page().visible
+        shortsListModePage = self.main_view.get_tab_ListModePage()
+        self.assertThat(shortsListModePage.visible, Eventually(Equals(True)))
+
+    @unittest.skip("Can't get tabs'")
+    def test_feed_item_ListModePage(self):
+        """"ensure feed items can be opened"""
+
+        test_feed_url = 'http://www.canonical.com/rss.xml'
+        test_feed_title = 'Insights'
+        test_topic = 'Test topic'
+
+        self.add_feed_to_new_topic(test_feed_url, test_feed_title, test_topic)
+
+        if self.main_view.get_tab_ListModePage().visible is False:
+            toolbar = self.main_view.open_toolbar()
+            toolbar.click_button("changemodebutton")
+
+        feed = self.main_view.get_feed_in_feedlist(test_topic, test_feed_title)
+        self.pointing_device.click_object(feed)
+
+        rssfeedpage = self.main_view.get_rss_feed_page().visible
         self.assertThat(rssfeedpage, Eventually(Equals(True)))
 
-    @unittest.skip("Can't see or get dynamic tabs")
     def test_edit_topic(self):
         """test edit topic"""
         test_feed_url = 'http://www.canonical.com/rss.xml'
@@ -303,41 +282,22 @@
 
         self.add_feed_to_new_topic(test_feed_url, test_feed_title, test_topic)
 
-        #verify we are on the topicName Tab
-        editTab = self.main_view.get_topic_tab(test_topic)
-        self.assertThat(editTab.visible, Eventually(Equals(True)))
-
-        #open toolbar
         toolbar = self.main_view.open_toolbar()
-
-        #click on edit topics button
         toolbar.click_button("edittopicsbutton")
 
-        # verify we are on topic management page
-        topicmanagementpage = self.main_view.get_feed_management_page()
-        self.assertThat(
-            topicmanagementpage.objectName,
-            Eventually(Equals("topicmanagement")))
-
-        #verity Tab is expanded
-        editTopic = self.main_view.get_feedlist_topic(test_topic)
-        if editTopic.state != "expended":
-            self.pointing_device.click_object(editTopic)
-
-        #select feed
-        editFeed = self.main_view.get_feedlist_feed(test_topic)
-        self.assertThat(editFeed, NotEquals(None))
-        self.pointing_device.click_object(editFeed)
-
-        #verify we are on edit feed page
+        feedListTopic = self.main_view.get_feedlist_topic(test_topic)
+        if feedListTopic.state != "expended":
+            self.pointing_device.click_object(feedListTopic)
+
+        feedListFeed = self.main_view.get_feedlist_feed(test_feed_title)
+        self.pointing_device.click_object(feedListFeed)
+
         editfeedpage = self.main_view.get_edit_feed_page()
         self.assertThat(editfeedpage.visible, Eventually(Equals(True)))
 
-        #change topic from dropdown
         topicValueselector = self.main_view.get_editfeed_topic_valueselector()
         self.pointing_device.click_object(topicValueselector)
 
-        #click on news topic
         topicValueselectorValue = self.main_view. \
             get_editfeed_valueselector_value("Ubuntu")
         self.pointing_device.click_object(topicValueselectorValue)