Merge lp:~carla-sella/ubuntu-rssreader-app/open_feed_test into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

[Carla Sella]

Test for opening a feed in feed list.

Hello Leo,
I am trying to test opening a feed in a feed list.
I am unable to get the count and currentIndex properties of the Article view item's Quick list view (https://lh3.googleusercontent.com/-wumo9Dj3-Qg/U0L7f_s6e1I/AAAAAAAAF2o/J1rJVKmJW6g/w1309-h737-no/QquickListView.png).
If count is greater than 0 and currentIndex is greater than -1 then it means that a feed has been opened (clicked on).
I just need to put an assert to verify the feed I clicked on has been opened.

[Carla Sella (carla-sella)]

I forgot, I get a StateNotFoundError: Object not found with name 'QQuickListView' and properties {'ObjectName': 'articleviewitem_listview'}.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:205
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/203/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2006
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/203
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/203
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/90

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/203/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-rssreader-app/open_feed_test]

206. By Carla Sella on 2014-04-07

Fixed asserts at the end of the test.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:206
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/204/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2008
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/204
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/204
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/91

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/204/rebuild

review: Approve (continuous-integration)

[Leo Arias (elopio)]

Hello Carla,

This is a good test, but it could be better if we hide the implementation details behind methods that are called after actions that a user can do.

Have you read https://code.google.com/p/selenium/wiki/PageObjects ?
We are trying to follow that patter everywhere, because it makes the tests more readable and easier to maintain.

Some important details:

38 + def get_topictab_articleviewitem(self, test_feed_title):
42 + def get_articleviewitem_listview(self, test_feed_title):

Any method that returns an autopilot object should be private and not be called directly from the test cases. So they should be:
_get_topictab_articleviewitem
_get_articleviewitem_listview

77 + feed_in_feeedlist = self.main_view.get_feed_in_feedlist(
78 + test_topic, test_feed_title)
79 + self.pointing_device.click_object(feed_in_feeedlist)

We can wrap this in a method called: open_feed_item.

81 + article_count = self.main_view.\
82 + get_articleviewitem_listview(test_feed_title).count

We can wrap this in a method called: get_article_count.

I'm going to take half a holiday today, so I'm about to leave to enjoy the sun rays. But tomorrow I'll be all day, ping me and I'll go into more details if you have doubts with the page object pattern.

Thanks again, a hug for your code.

[Carla Sella (carla-sella)]

> Hello Carla,

Hello Leo,

>
> This is a good test, but it could be better if we hide the implementation
> details behind methods that are called after actions that a user can do.
>
> Have you read https://code.google.com/p/selenium/wiki/PageObjects ?

No I haven't read it but I will now :).

> We are trying to follow that patter everywhere, because it makes the tests
> more readable and easier to maintain.
>
> Some important details:
>
> 38 + def get_topictab_articleviewitem(self, test_feed_title):
> 42 + def get_articleviewitem_listview(self, test_feed_title):
>
> Any method that returns an autopilot object should be private and not be
> called directly from the test cases. So they should be:
> _get_topictab_articleviewitem
> _get_articleviewitem_listview

I put
 38 + def get_topictab_articleviewitem(self, test_feed_title):
 42 + def get_articleviewitem_listview(self, test_feed_title):

in emulators.py not in test_rssreader.py, if I make them private in emulators.py I will not be able to use them in test_rssreader.py, so do I have to make them private and move them to test_rssreader.py ?
I made them private and moved them to test_rssreader.py if this is not ok, tell me and I will put them back to emulators.py, but the cannot be private.

[...]
>
> I'm going to take half a holiday today, so I'm about to leave to enjoy the sun
> rays.

Lucky you :D.

>But tomorrow I'll be all day, ping me and I'll go into more details if
> you have doubts with the page object pattern.
>
> Thanks again, a hug for your code.

Thank you.

Carla

[lp:~carla-sella/ubuntu-rssreader-app/open_feed_test]

207. By Carla Sella on 2014-04-09

Fixed test_open_feed_item as Leo suggested.

[Carla Sella (carla-sella)]

Hello Leo,
I put back the:
 38 + def get_topictab_articleviewitem(self, test_feed_title):
 42 + def get_articleviewitem_listview(self, test_feed_title):
to emulators.py.
I will ping you for this tomorrow :).

Carla

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:207
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/205/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2019
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/205
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/205
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/92

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/205/rebuild

review: Approve (continuous-integration)

[lp:~carla-sella/ubuntu-rssreader-app/open_feed_test]

208. By Carla Sella on 2014-04-13

Fixed assert in test_open_listmode_feed_item test (renamed form test_open_feed_item).

209. By Carla Sella on 2014-04-13

Bzr merged.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:209
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/207/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2075
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/207
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/207
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/94

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/207/rebuild

review: Approve (continuous-integration)

[David Planella (dpm)]

Leo, Nick, would you mind having a look at the latest changes from Carla on this branch? Does it now look good to you for approval?

[Nicholas Skaggs (nskaggs)]

Hmm, when I run this I'm getting this bug:

https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1314531

Wild, and not related to this change I'm sure.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:209
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/215/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2320
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/215
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/215
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/102

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/215/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:209
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/217/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2325
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/217
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/217
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/104

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/217/rebuild

review: Needs Fixing (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Needs to use the new variables from trunk. Rebase to trunk and you will see them. This fixes the build.

_EXTERNAL_FEED_URL = 'http://www.canonical.com/rss.xml'
_EXTERNAL_FEED_TITLE = 'Ubuntu Insights'

Then +1 from me.

review: Needs Fixing

[lp:~carla-sella/ubuntu-rssreader-app/open_feed_test]

210. By Carla Sella on 2014-04-30

Fixed test_open_listmode_feed_item with new variables from trunk.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:210
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/218/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2326
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/218
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/218
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-trusty-amd64-ci/105

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/218/rebuild

review: Approve (continuous-integration)

=== modified file 'ArticleViewItem.qml'
--- ArticleViewItem.qml	2014-04-16 15:54:38 +0000
+++ ArticleViewItem.qml	2014-04-30 18:58:28 +0000
@@ -126,6 +126,7 @@
 
         Flickable {
             id: scrollArea
+            objectName: "articleview_flickable"
 
             clip: true
 
@@ -173,6 +174,7 @@
                 }
 
                 Label {
+                    objectName: "articleviewitem_title"
                     fontSize: "large"
                     text: model.title
                     anchors.horizontalCenter: parent.horizontalCenter

=== modified file 'ListModePage.qml'
--- ListModePage.qml	2014-03-08 15:27:10 +0000
+++ ListModePage.qml	2014-04-30 18:58:28 +0000
@@ -141,6 +141,7 @@
 
                     Label {
                         id: labelTitle
+                        objectName: "label_title"
 
                         text: model.title
                         width: parent.width

=== modified file 'tests/autopilot/shorts_app/emulators.py'
--- tests/autopilot/shorts_app/emulators.py	2014-04-23 17:48:20 +0000
+++ tests/autopilot/shorts_app/emulators.py	2014-04-30 18:58:28 +0000
@@ -170,8 +170,7 @@
         return self.select_single("ManageTopicsPage")
 
     def get_rss_feed_page(self):
-        return self.wait_select_single(
-            "RssFeedPage", objectName="rssfeedpage")
+        return self.wait_select_single("RssFeedPage", objectName="rssfeedpage")
 
     def get_shorts_tab(self):
         return self.wait_select_single("ShortsTab", objectName="Tab0")
@@ -217,18 +216,41 @@
     def get_topic_tab(self, topic):
         return self.wait_select_single("TopicTab", title=topic)
 
-    def get_feed_in_feedlist(self, topic, feed):
-        itemList = self.get_feedlist(topic)
+    @autopilot_logging.log_action(logger.info)
+    def open_feed_item(self, test_topic, test_feed_title):
+        feed_in_feeedlist = self._get_feed_in_feedlist(
+            test_topic, test_feed_title)
+        self.pointing_device.click_object(feed_in_feeedlist)
+
+    def _get_feed_in_feedlist(self, topic, feed):
+        itemList = self._get_feedlist(topic)
         for item in itemList:
             label = item.select_single("Label", objectName="labelFeedname")
             if label.text == feed:
                 return item
 
-    def get_feedlist(self, topic):
-        #tab = self.get_topic_tab(topic)
+    def _get_feedlist(self, topic):
         items = self.select_many("UbuntuShape", objectName="feedlistitems")
         return items
 
+    def get_feed_in_feedlist_title(self, test_topic, test_feed_title):
+        feed_in_feeedlist = self._get_feed_in_feedlist(
+            test_topic, test_feed_title)
+        return feed_in_feeedlist.select_single(
+            "Label", objectName="label_title").text
+
+    def get_articleviewitem_title(self):
+        flickable = self._get_articleview_flickables()
+        return flickable.select_single(
+            "Label", objectName="articleviewitem_title").text
+
+    def _get_articleview_flickables(self):
+        flickables_list = self.select_many(
+            "QQuickFlickable", objectName="articleview_flickable")
+        for flickable in flickables_list:
+            if flickable.focus:
+                return flickable
+
     def get_editfeed_topic_valueselector(self):
         return self.wait_select_single(
             "ValueSelector", objectName="valueselector")

=== modified file 'tests/autopilot/shorts_app/tests/test_rssreader.py'
--- tests/autopilot/shorts_app/tests/test_rssreader.py	2014-04-30 17:10:41 +0000
+++ tests/autopilot/shorts_app/tests/test_rssreader.py	2014-04-30 18:58:28 +0000
@@ -205,6 +205,23 @@
         if not current_tab.isListMode:
             self.main_view.change_view_mode()
 
+    def test_open_listmode_feed_item(self):
+        """"test to ensure list mode feed items can be opened"""
+
+        test_feed_url = _EXTERNAL_FEED_URL
+        test_feed_title = _EXTERNAL_FEED_TITLE
+        test_topic = 'Test topic'
+
+        self.add_feed_to_new_topic(test_feed_url, test_feed_title, test_topic)
+        new_topic_tab = self.main_view.get_topic_tab(test_topic)
+        self.ensure_list_view_mode(new_topic_tab)
+
+        self.main_view.open_feed_item(test_topic, test_feed_title)
+        self.assertEqual(
+            self.main_view.get_feed_in_feedlist_title(
+                test_topic, test_feed_title),
+            self.main_view.get_articleviewitem_title())
+
     @unittest.skip("Can't see or get dynamic tabs")
     def test_edit_topic(self):
         """test edit topic"""