Merge lp:~carla-sella/ubuntu-rssreader-app/fixed-tests-for-feed-checkbox into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

[Carla Sella]

Autopilot tests for Ubuntu Rssreader App

Fixed broken tests due to introduction of feed checkbox.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:350
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/285/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/505
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/505/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-vivid-amd64-ci/10

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/285/rebuild

review: Approve (continuous-integration)

[Carla Sella (carla-sella)]

This fixes failing of various tests where the checkbox is not beeing selected while adding a new feed.

[Nicholas Skaggs (nskaggs)]

Awesome. I should have looked through this first. Thanks Carla!

=== modified file 'feeds/AppendFeedPage.qml'
--- feeds/AppendFeedPage.qml	2014-09-20 10:51:29 +0000
+++ feeds/AppendFeedPage.qml	2014-12-21 20:59:18 +0000
@@ -207,7 +207,7 @@
             control: CheckBox {
                 anchors.verticalCenter: parent.verticalCenter
 
-                objectName: "feedCheckbox"
+                objectName: "feedCheckbox-" + model.title
                 onCheckedChanged: {
                     searchResultsModel.setProperty(index, "isSelected", checked)
                     if (checked)

=== modified file 'tests/autopilot/shorts_app/__init__.py'
--- tests/autopilot/shorts_app/__init__.py	2014-12-16 19:51:03 +0000
+++ tests/autopilot/shorts_app/__init__.py	2014-12-21 20:59:18 +0000
@@ -359,7 +359,7 @@
 
     def _check_result(self, result):
         results_list = self._get_results_list()
-        results_list.click_element('feedpagelistitem-{}'.format(result))
+        results_list.click_element('feedCheckbox-{}'.format(result))
 
 
 class ChooseTopicPage(Page):