Merge lp:~carla-sella/ubuntu-calendar-app/dayview-test-default-view into lp:ubuntu-calendar-app

[Carla Sella]

Autopilot test for Calendar app

Dayview: test default view.

[Carla Sella (carla-sella)]

Still need to verify that the day should be scrolled to the current time.

[Carla Sella (carla-sella)]

Should be ok now.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:607
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1109/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2392/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/580/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/106/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1109/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-calendar-app/dayview-test-default-view]

608. By Carla Sella on 2015-03-22

Fixed identation errror.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:608
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1110/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2393
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2393/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/581
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/107

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1110/rebuild

review: Needs Fixing (continuous-integration)

[Carla Sella (carla-sella)]

Reported bug #1435542 as in Italy Sunday is the first day of the week and yesterday, 22nd March the week number was 12 and not 11, so this test failed, but should not have:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/calendar_app/tests/test_dayview.py", line 77, in test_default_view
    self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%U"))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 'W11' != 'W12'

[Carla Sella (carla-sella)]

I found out why the test is failing only on Sundays.
If you look at the screenshot:

https://dl.dropboxusercontent.com/u/10083981/Ubuntu%20phone/Calendar.png

You can see how the days in Calendar app are displayed, Sunday is together with Saturday and Friday on the same page where there is the W13 week number label, but friday and saturday are W13 while sunday is W14.
That means that, for instance sunday 5 april is displayed on W13 but is
W14 instead.
So the test fails if you are testing on sunday 5 april because I am checking day label and day of week label are correct, the label is correct for two day but not for the third only in pages displaying Friday, Saturday and Sunday together.

So the question is: what should I do if the day I am testing on is a Sunday, this test will always fail on Sundays as Sundays are already on a next week number-

I can verify that if the day I am testing on is a Sunday I have to subtact 1 to week number, but not sure this is what you want me to do.

Carla

[lp:~carla-sella/ubuntu-calendar-app/dayview-test-default-view]

609. By Carla Sella on 2015-04-04

Added test_today_button.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:609
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1125/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2495
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2495/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/596
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/122

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1125/rebuild

review: Needs Fixing (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

> I found out why the test is failing only on Sundays.
> If you look at the screenshot:
>
> https://dl.dropboxusercontent.com/u/10083981/Ubuntu%20phone/Calendar.png
>
> You can see how the days in Calendar app are displayed, Sunday is together
> with Saturday and Friday on the same page where there is the W13 week number
> label, but friday and saturday are W13 while sunday is W14.
> That means that, for instance sunday 5 april is displayed on W13 but is
> W14 instead.
> So the test fails if you are testing on sunday 5 april because I am checking
> day label and day of week label are correct, the label is correct for two day
> but not for the third only in pages displaying Friday, Saturday and Sunday
> together.
>
> So the question is: what should I do if the day I am testing on is a Sunday,
> this test will always fail on Sundays as Sundays are already on a next week
> number-
>
> I can verify that if the day I am testing on is a Sunday I have to subtact 1
> to week number, but not sure this is what you want me to do.
>
> Carla

Hello Carla,

There seem some issue with logic how we calculate week numer from date.

Date.prototype.weekNumber = function() {
    var date = this.weekStart(1).addDays(3) // Thursday midnight

This is function used, in dateext.js, and looks like week's start day here is hard coded.
I gave you a branch where I resolved this issue, that patch calculate week number by taking in account what is week start day.

Please check with that branch as well.

[Carla Sella (carla-sella)]

Hello Kunal,
I merged your branch into mine. It works if I run this test on a Sunday (for instance Sun 5th April), but fails if I run it on the 31st of March for instance, I get this errror:

Traceback (most recent call last):
  File "/home/letozaf/autopilot-tests/dayview-test-default-view/tests/autopilot/calendar_app/tests/test_dayview.py", line 77, in test_default_view
    self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%U"))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 'W14' != 'W13'

[Kunal Parmar (pkunal-parmar)]

> Hello Kunal,
> I merged your branch into mine. It works if I run this test on a Sunday (for
> instance Sun 5th April), but fails if I run it on the 31st of March for
> instance, I get this errror:
>
> Traceback (most recent call last):
> File "/home/letozaf/autopilot-tests/dayview-test-default-
> view/tests/autopilot/calendar_app/tests/test_dayview.py", line 77, in
> test_default_view
> self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%U"))
> File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in
> assertEqual
> self.assertThat(observed, matcher, message)
> File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in
> assertThat
> raise mismatch_error
> testtools.matchers._impl.MismatchError: 'W14' != 'W13'

Hello Carla,

I read python strftime doc. As per it, week start from 00 and end at 53. As per our implementation it start from 1 and end at 54.

Also we need to check what is locale set as per that we should use %U or %W.
I referred this link https://docs.python.org/2/library/time.html

[lp:~carla-sella/ubuntu-calendar-app/dayview-test-default-view]

610. By Carla Sella on 2015-04-06

Fixed cheching week number.

[Carla Sella (carla-sella)]

To me looks like using %W instead of %U fixes the issue, but I am not sure. Maybe someone can double check ?

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:610
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1135/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2519
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2519/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/606
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/132

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1135/rebuild

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

%W can work, so long as we assume a Monday as first day of the week locale.

=== modified file 'HeaderDateComponent.qml'
--- HeaderDateComponent.qml	2014-11-04 18:32:16 +0000
+++ HeaderDateComponent.qml	2015-04-06 16:51:08 +0000
@@ -39,6 +39,7 @@
 
     Column {
         id: dateContainer
+        objectName: "dateContainer"
 
         width: dayLabel.paintedWidth
         spacing: units.gu(0.2)

=== modified file 'tests/autopilot/calendar_app/__init__.py'
--- tests/autopilot/calendar_app/__init__.py	2015-03-07 10:14:46 +0000
+++ tests/autopilot/calendar_app/__init__.py	2015-04-06 16:51:08 +0000
@@ -28,6 +28,7 @@
 from testtools.matchers import GreaterThan
 
 from calendar_app import data
+from datetime import date
 
 
 logger = logging.getLogger(__name__)
@@ -275,6 +276,10 @@
         local = utc.astimezone(tz.tzlocal())
         return local
 
+    def press_header_todaybutton(self):
+        header = self.get_header()
+        header.click_action_button('todaybutton')
+
 
 class YearView(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
 
@@ -583,27 +588,81 @@
         return event_details_page.edit()
 
     @autopilot.logging.log_action(logger.info)
-    def get_day_header(self, day=None):
+    def get_timeline_header_component(self, day):
         """Return the dayheader for a given day. If no day is given,
         return the current day.
 
-        :param day: A datetime object matching the header
+        :param day:  day in date(year, month, day) format
         :return: The day header object
         """
         if day:
             headers = self.select_many('TimeLineHeaderComponent')
             for header in headers:
-                if header.startDay.datetime == day:
-                    day_header = header
-                    break
-        else:
-            # just grab the current day
-            day_header = self.wait_select_single(
-                'TimeLineHeaderComponent', isCurrentItem=True)
-
-        if not(day_header):
-            raise CalendarException('Day Header not found for %s' % day)
-        return day_header
+                header_date = date(header.startDay.datetime.year,
+                                   header.startDay.datetime.month,
+                                   header.startDay.datetime.day)
+                if header_date == day:
+                    return header
+
+        else:
+            raise CalendarException('Day Header not found for %s' % day)
+
+    @autopilot.logging.log_action(logger.info)
+    def get_timeline_header(self, day):
+        """Return the dayheader for a given day. If no day is given,
+        return the current day.
+
+        :param day:  day in date(year, month, day) format
+        :return: The day header object
+        """
+        if day:
+            headers = self.select_many('TimeLineHeader')
+            for header in headers:
+                header_date = date(header.startDay.datetime.year,
+                                   header.startDay.datetime.month,
+                                   header.startDay.datetime.day)
+                if header_date == day:
+                    return header
+
+        else:
+            raise CalendarException('Day Header not found for %s' % day)
+
+    @autopilot.logging.log_action(logger.info)
+    def get_daylabel(self, today):
+        current_day_header = self.get_timeline_header_component(today)
+        return current_day_header.wait_select_single(
+            'Label', objectName='dayLabel')
+
+    @autopilot.logging.log_action(logger.info)
+    def get_datelabel(self, today):
+        current_day_header = self.get_timeline_header_component(today)
+        return current_day_header.wait_select_single(
+            'Label', objectName='dateLabel')
+
+    @autopilot.logging.log_action(logger.info)
+    def get_weeknumer(self, today):
+        current_day_header = self.get_timeline_header(today)
+        return current_day_header.wait_select_single(
+            'Label', objectName='weeknumber')
+
+    @autopilot.logging.log_action(logger.info)
+    def get_scrollHour(self):
+        return self.wait_select_single(
+            'TimeLineBaseComponent', objectName='DayComponent-0').scrollHour
+
+    @autopilot.logging.log_action(logger.info)
+    def check_loading_spinnger(self):
+        timelinebasecomponent = self.get_active_timelinebasecomponent()
+        loading_spinner = timelinebasecomponent.wait_select_single(
+            "ActivityIndicator")
+        loading_spinner.running.wait_for(False)
+
+    @autopilot.logging.log_action(logger.info)
+    def get_active_timelinebasecomponent(self):
+        timelinebase_components = self.select_many(("TimeLineBaseComponent"))
+        for component in timelinebase_components:
+            if component.isActive:
+                return component
 
 
 class AgendaView(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):

=== modified file 'tests/autopilot/calendar_app/tests/test_dayview.py'
--- tests/autopilot/calendar_app/tests/test_dayview.py	2014-10-08 00:44:20 +0000
+++ tests/autopilot/calendar_app/tests/test_dayview.py	2015-04-06 16:51:08 +0000
@@ -19,6 +19,7 @@
 """
 
 import datetime
+import calendar
 
 # from __future__ import range
 # (python3's range, is same as python2's xrange)
@@ -30,6 +31,7 @@
 from testtools.matchers import Equals, NotEquals
 
 from calendar_app.tests import CalendarAppTestCase
+from datetime import date
 
 
 class TestDayView(CalendarAppTestCase):
@@ -38,15 +40,44 @@
         super(TestDayView, self).setUp()
         self.day_view = self.app.main_view.go_to_day_view()
 
-    def test_current_month_and_year_is_selected(self):
-        """By default, the day view shows the current month and year."""
+    def test_default_view(self):
+        """By default, the day view shows the current month year and
+           today's date.
+           The day should be scrolled to the current time
+        """
 
         now = datetime.datetime.now()
+        today = date(now.year, now.month, now.day)
+        day_view_currentDay = self.day_view.currentDay
+
+        day_view_currentDay_date = \
+            date(day_view_currentDay.year,
+                 day_view_currentDay.month,
+                 day_view_currentDay.day)
 
         expected_month_name_year = now.strftime("%B %Y")
 
-        self.assertThat(self.app.main_view.get_month_year(self.day_view),
-                        Equals(expected_month_name_year))
+        # Checking today's date is correct
+        self.assertEquals(day_view_currentDay_date, today)
+
+        # Checking month and year in header are correct
+        self.assertEquals(
+            self.app.main_view.get_month_year(self.day_view),
+            expected_month_name_year)
+
+        # Checking day label and day of week label are correct
+        self.assertEquals(
+            self.day_view.get_daylabel(today).text,
+            calendar.day_abbr[now.weekday()])
+        self.assertEquals(
+            self.day_view.get_datelabel(today).text, str(now.day))
+
+        # Checking week number is  correct
+        self.assertEquals(
+            self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%W"))
+
+        # Check  day is scrolled to the current time
+        self.assertEquals(self.day_view.get_scrollHour(), now.hour)
 
     def test_show_next_days(self):
         """It must be possible to show next days by swiping the view."""
@@ -56,6 +87,18 @@
         """It must be possible to show previous days by swiping the view."""
         self._change_days(-1)
 
+    def test_today_button(self):
+        now = datetime.datetime.now()
+        today = date(now.year, now.month, now.day)
+        self._change_days(1)
+        self.app.main_view.press_header_todaybutton()
+        self.day_view.check_loading_spinnger()
+
+        current_day = self.day_view.get_active_timelinebasecomponent().startDay
+        new_today = date(current_day.year, current_day.month, current_day.day)
+
+        self.assertEquals(today, new_today)
+
     def _change_days(self, direction):
         firstday = self.day_view.currentDay.datetime