Merge lp:~carifio/lightdm/lightdm-lp967229 into lp:ubuntu/precise/lightdm

Proposed by Mike Carifio on 2012-10-25
Status: Rejected
Rejected by: St├ęphane Graber on 2012-11-08
Proposed branch: lp:~carifio/lightdm/lightdm-lp967229
Merge into: lp:ubuntu/precise/lightdm
Diff against target: 34 lines (+16/-0)
2 files modified
debian/changelog (+7/-0)
debian/lightdm.upstart (+9/-0)
To merge this branch: bzr merge lp:~carifio/lightdm/lightdm-lp967229
Reviewer Review Type Date Requested Status
Marc Deslauriers Disapprove on 2012-11-07
Michael Terry Needs Fixing on 2012-11-06
Ubuntu branches 2012-10-25 Pending
Review via email: mp+131478@code.launchpad.net
To post a comment you must log in.
Mike Carifio (carifio) wrote :

Modified /etc/init/lightdm.conf post-stop script to clear /dev/tty7 if lightdm exits successfully.

Michael Terry (mterry) wrote :

I dunno. I tested in a virtual machine and it felt like it made it worse. I saw the text very briefly, it cleared, then I saw it again very briefly, then plymouth came up. So it looked like the text flashed off and on again.

review: Needs Fixing
Marc Deslauriers (mdeslaur) wrote :

This approach doesn't really work. Not only is clearing the text likely to be visible, but other daemons which are in the process of shutting down will still be printing stuff to the screen before plymouth comes up.

review: Disapprove

Unmerged revisions

70. By Mike Carifio on 2012-10-25

Added debian/changelog entry.

69. By Mike Carifio on 2012-10-25

Clear /dev/tty7 on lightdm stop if and only if lightdm exits
without error. Mitigates LP: #967229.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-04-18 18:37:47 +0000
3+++ debian/changelog 2012-10-25 20:24:21 +0000
4@@ -1,3 +1,10 @@
5+lightdm (1.2.1-0ubuntu2) precise-proposed; urgency=low
6+
7+ * Clear /dev/tty7 on lightdm stop if and only if lightdm exits
8+ without error. Mitigates LP: #967229.
9+
10+ -- Mike Carifio <michael.carifio@canonical.com> Thu, 25 Oct 2012 16:13:07 -0400
11+
12 lightdm (1.2.1-0ubuntu1) precise-proposed; urgency=low
13
14 * New upstream release:
15
16=== modified file 'debian/lightdm.upstart'
17--- debian/lightdm.upstart 2011-11-02 11:37:43 +0000
18+++ debian/lightdm.upstart 2012-10-25 20:24:21 +0000
19@@ -48,6 +48,15 @@
20 end script
21
22 post-stop script
23+
24+ # If lightdm exits ok, clear messages on /dev/tty7
25+ # Mitigates a race condition between lightdm stopping
26+ # and plymouth starting (LP: #967229)
27+ if [ -z "$EXIT_STATUS" -a -z "$EXIT_SIGNAL" ]; then
28+ logger "$UPSTART_JOB cleared /dev/tty7"
29+ clear > /dev/tty7
30+ fi
31+
32 if [ "$UPSTART_STOP_EVENTS" = runlevel ]; then
33 initctl emit desktop-shutdown
34 fi

Subscribers

People subscribed via source and target branches

to all changes: