Merge lp:~cardinot/stellarium/configGUI into lp:stellarium

[Marcos Cardinot]

It's just a new way to open the configGUI of a loaded plugin.

F2->Plugins->(dbclick on a loaded plugin)

[Alexander Wolf (alexwolf)]

In current code this part - QObject::sender()->objectName()=="pluginsListWidget" - don't need for work. Why you use it?

review: Needs Information

[Alexander Wolf (alexwolf)]

review: Needs Information

[Marcos Cardinot (cardinot)]

> In current code this part -
> QObject::sender()->objectName()=="pluginsListWidget" - don't need for work.
> Why you use it?

Without this modification a warning is send whenever the user doubleclick on a plugin not loaded.
IMHO it could unnecessarily pollute the output terminal...

[Alexander Wolf (alexwolf)]

OK

[Alexander Wolf (alexwolf)]

This patch introduces the opening GUI of plugin via double click event in plugins list. It can be good solution for alternative for opening dialogs, plus introduce short way for it.

review: Approve

=== modified file 'src/gui/ConfigurationDialog.cpp'
--- src/gui/ConfigurationDialog.cpp	2014-02-27 16:15:23 +0000
+++ src/gui/ConfigurationDialog.cpp	2014-03-09 20:22:27 +0000
@@ -272,6 +272,7 @@
 	// plugins control
 	connect(ui->pluginsListWidget, SIGNAL(currentItemChanged(QListWidgetItem*, QListWidgetItem*)), this, SLOT(pluginsSelectionChanged(QListWidgetItem*, QListWidgetItem*)));
 	connect(ui->pluginLoadAtStartupCheckBox, SIGNAL(stateChanged(int)), this, SLOT(loadAtStartupChanged(int)));
+	connect(ui->pluginsListWidget, SIGNAL(doubleClicked(QModelIndex)), this, SLOT(pluginConfigureCurrentSelection()));
 	connect(ui->pluginConfigureButton, SIGNAL(clicked()), this, SLOT(pluginConfigureCurrentSelection()));
 	populatePluginsList();
 
@@ -755,7 +756,7 @@
 	{
 		if (id == desc.info.id)
 		{
-			StelModule* pmod = moduleMgr.getModule(desc.info.id);
+			StelModule* pmod = moduleMgr.getModule(desc.info.id, QObject::sender()->objectName()=="pluginsListWidget");
 			if (pmod != NULL)
 			{
 				pmod->configureGui(true);