Merge lp:~canonical-website-editors/resource-centre/bug-1639772 into lp:resource-centre

Proposed by Graham Bancroft
Status: Merged
Approved by: Anthony Dillon
Approved revision: 98
Merged at revision: 98
Proposed branch: lp:~canonical-website-editors/resource-centre/bug-1639772
Merge into: lp:resource-centre
Diff against target: 15 lines (+3/-2)
1 file modified
header.php (+3/-2)
To merge this branch: bzr merge lp:~canonical-website-editors/resource-centre/bug-1639772
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
Review via email: mp+322975@code.launchpad.net

Description of the change

## Done

Fix bug 1639772: Favicon is not crisp on retina screens
Use the same favicons as ubuntu.com

## QA

Check that insights is now using the same favicon icons as ubuntu.com

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Looks good, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'header.php'
2--- header.php 2015-12-16 11:26:54 +0000
3+++ header.php 2017-04-21 15:46:09 +0000
4@@ -34,8 +34,9 @@
5 <meta name="author" content="Canonical" />
6 <meta name="viewport" content="width=device-width, initial-scale=1" />
7
8-<!-- shortcut icons -->
9-<link rel="shortcut icon" href="//assets.ubuntu.com/sites/ubuntu/latest/u/img/favicon.ico" />
10+<link rel="icon" type="image/png" href="https://assets.ubuntu.com/v1/cb22ba5d-favicon-16x16.png" sizes="16x16" />
11+<link rel="icon" type="image/png" href="https://assets.ubuntu.com/v1/49a1a858-favicon-32x32.png" sizes="32x32" />
12+
13 <link rel="apple-touch-icon" href="//assets.ubuntu.com/sites/ubuntu/latest/u/img/touch-icon-iphone.png" />
14 <link rel="apple-touch-icon" sizes="72x72" href="//assets.ubuntu.com/sites/ubuntu/latest/u/img/touch-icon-ipad.png" />
15 <link rel="apple-touch-icon" sizes="114x114" href="//assets.ubuntu.com/sites/ubuntu/latest/u/img/touch-icon-iphone-retina.png" />

Subscribers

People subscribed via source and target branches

to all changes: