Merge lp:~canonical-website-editors/resource-centre/bug-1546054 into lp:resource-centre

Proposed by Graham Bancroft
Status: Merged
Merged at revision: 90
Proposed branch: lp:~canonical-website-editors/resource-centre/bug-1546054
Merge into: lp:resource-centre
Diff against target: 12 lines (+1/-1)
1 file modified
functions/general.php (+1/-1)
To merge this branch: bzr merge lp:~canonical-website-editors/resource-centre/bug-1546054
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
Review via email: mp+308641@code.launchpad.net

Description of the change

## Done

Remove restrictions on posting News Content Types

## QA

Either pull the theme down into a WP install. Or head on over to http://insights.canonicalwebteam.com/wp-admin ping me on IRC for the login detailsw

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Code looks good. Will need the login details to verify. Also what would be the true QA steps to reproduce?

Revision history for this message
Graham Bancroft (gbancroft-canonical) wrote :

## QA

Login to using the user 'Contributor' with the password sent via email

Go to http://insights.canonicalwebteam.com/wp-admin/post-new.php to add a new article and note that you can see 'News' listed as a content type

If you login to live insights with your own details you won't be able to see the content type as it's restricted to a limited number of users

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Thanks for the QA steps. Code and QA +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'functions/general.php'
2--- functions/general.php 2016-07-15 11:18:07 +0000
3+++ functions/general.php 2016-10-17 15:47:58 +0000
4@@ -119,7 +119,7 @@
5 add_action( 'admin_init', 'gb_do_terms_exclusion' );
6
7 function gb_list_terms_exclusions($exclusions,$args) {
8- return $exclusions . " AND ( t.name <> 'News' ) AND ( t.name <> 'Press releases' ) AND ( t.name <> 'Downloads' )";
9+ return $exclusions . " AND ( t.name <> 'Downloads' )";
10 }
11
12 /**

Subscribers

People subscribed via source and target branches

to all changes: