Merge ~canonical-server/+git/team-subscriptions:subscribe-to-glusterfs into ~canonical-server/+git/team-subscriptions:main

Proposed by Andreas Hasenack
Status: Merged
Merged at revision: 981a8eafd9c4d941ecdb525878fd07b8f88ac2e1
Proposed branch: ~canonical-server/+git/team-subscriptions:subscribe-to-glusterfs
Merge into: ~canonical-server/+git/team-subscriptions:main
Diff against target: 12 lines (+1/-0)
1 file modified
subscriptions.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  Approve
Utkarsh Gupta Approve
Review via email: mp+419221@code.launchpad.net

Description of the change

Subscribe to src:glusterfs, MIR bug #1950321 was approved.

To post a comment you must log in.
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Yeehaw! Probably merge in with the seed change or something but I know you know it better so I'll leave it with a +1. \o/

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

The commit message, however, has a missing # in the bug number. :)

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

samba-vfs-modules will pull in the minimal gluster packages into main, but yeah, let's also check a seed change for the server and client bits.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I did the subscription for today already.
When we land this before the checker lands it will be fine permanently.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

@Utkarsh the commit message is not a changelog or closing the bug, it is just related so the reference to the bug is fine as-is.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

my +1 as well

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hellu,

It's not about closing the bug or whatever but we generally do LP: #XXXXXX. Just to work around the system catching it and closing bugs when mentioned in the d/ch entry, we do LP: XXXXXX. So technically, which I learned recently, the correct format is LP: #XXXXXX.

And honestly, it doesn't really matter that much. But force of habit so I spotted.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/subscriptions.yaml b/subscriptions.yaml
index 7d6dd59..9b7fbb6 100644
--- a/subscriptions.yaml
+++ b/subscriptions.yaml
@@ -57,6 +57,7 @@ ubuntu-server: !!set
57 ? frr57 ? frr
58 ? gdisk58 ? gdisk
59 ? genshi59 ? genshi
60 ? glusterfs
60 ? gpsd61 ? gpsd
61 ? grub-legacy-ec262 ? grub-legacy-ec2
62 ? haproxy63 ? haproxy

Subscribers

People subscribed via source and target branches

to all changes: