Merge lp:~canonical-platform-qa/webbrowser-app/fix255631-focus_address_bar into lp:webbrowser-app
Proposed by
Leo Arias
| Status: | Merged |
|---|---|
| Approved by: | Olivier Tilloy |
| Approved revision: | 964 |
| Merged at revision: | 977 |
| Proposed branch: | lp:~canonical-platform-qa/webbrowser-app/fix255631-focus_address_bar |
| Merge into: | lp:webbrowser-app |
| Diff against target: |
10 lines (+0/-1) 1 file modified
tests/autopilot/webbrowser_app/emulators/browser.py (+0/-1) |
| To merge this branch: | bzr merge lp:~canonical-platform-qa/webbrowser-app/fix255631-focus_address_bar |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Tilloy | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
In the autopilot tests, removed the extra focus step to write a URL.
Description of the change
The extra focus step was causing the sanity tests to fail sometimes.
>From Richard's analyzis:
in the case of long urls, it was causing the text field to scroll to the end of the url which takes a small amount of time. When the clear button was pressed during this time it would fail to clear the existing url.
To post a comment you must log in.
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Leo Arias (elopio) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Not sure how this change would make a difference: TextField.write() has to focus the text field before writing to it, how would it do it without tapping on the field first? (which would trigger the scrolling to the end of the URL)