Merge lp:~canonical-platform-qa/utah/remove-append into lp:utah

[Max Brustkern]

This branch comments out setting the serial port to append. In the current xenial version of qemu, this capability is defined but not supported. The directive is silently ignored on versions predating its introduction, as far as I can tell. I'd like to reintegrate it once we figure out how, but I think this is safer for now, since it will allow us to continue testing changes on xenial and trusty.

[Christopher Lee (veebers)]

Can we file a bug that we can track somehow so we know when we can reintegrate it once it's fixed?

review: Needs Information

[lp:~canonical-platform-qa/utah/remove-append]

1077. By Max Brustkern on 2016-02-22

Filed bug

[Christopher Lee (veebers)]

LGTM

review: Approve

=== modified file 'utah/provisioning/vm.py'
--- utah/provisioning/vm.py	2016-02-10 22:40:15 +0000
+++ utah/provisioning/vm.py	2016-02-22 20:43:59 +0000
@@ -14,7 +14,6 @@
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 """Provide functions for virtual machine provisioning."""
-# TODO: Maybe combine the VM stuff into one file?
 
 
 import apt
@@ -386,7 +385,8 @@
         serial.set('type', 'file')
         source = ElementTree.Element('source')
         source.set('path', self.syslog)
-        source.set('append', 'on')
+        #TODO: reintegrate this when the required qemu version lands
+#        source.set('append', 'on')  # lp#1548499
         serial.append(source)
         target = ElementTree.Element('target')
         target.set('port', '0')