Merge lp:~canonical-platform-qa/unity8/slow-down-scope-swipe into lp:unity8

Proposed by Richard Huddie
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1779
Merged at revision: 1812
Proposed branch: lp:~canonical-platform-qa/unity8/slow-down-scope-swipe
Merge into: lp:unity8
Diff against target: 21 lines (+2/-2)
1 file modified
tests/autopilot/unity8/shell/emulators/dash.py (+2/-2)
To merge this branch: bzr merge lp:~canonical-platform-qa/unity8/slow-down-scope-swipe
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Leo Arias (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+259547@code.launchpad.net

Commit message

Slow down the speed of autopilot helpers used to swipe to a different scope to improve the reliability.

Description of the change

The autopilot helpers used to swipe to a different scope can sometimes fail. The reliability of the swipe operation is improved by slowing down the speed of the swipe.

 * Are there any related MPs required for this MP to build/function as expected? Please list.

No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes, tested modified autopilot helpers.

 * Did you make sure that your branch does not contain spurious tags?

Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

No packaging changes.

 * If you changed the UI, has there been a design review?

No UI changes.

 * Did you have a look at the warnings when running tests? Can they be reduced?

No warnings from this change.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

Richard, please paste and answer the checklist into the description of your branch:
https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8

This makes sense to me, thanks.

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Test only change

 * Did CI run pass?
Not worse than usual

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/unity8/shell/emulators/dash.py'
2--- tests/autopilot/unity8/shell/emulators/dash.py 2015-04-28 15:20:13 +0000
3+++ tests/autopilot/unity8/shell/emulators/dash.py 2015-05-19 21:47:36 +0000
4@@ -130,7 +130,7 @@
5 x, y, width, height = dash_content.globalRect
6 # Make the drag range be a multiple of the drag "rate" value.
7 # Workarounds https://bugs.launchpad.net/mir/+bug/1399690
8- rate = 10
9+ rate = 5
10 divisions = 5
11 jump = (width / divisions) // rate * rate
12 start_x = x + jump
13@@ -146,7 +146,7 @@
14 x, y, width, height = dash_content.globalRect
15 # Make the drag range be a multiple of the drag "rate" value.
16 # Workarounds https://bugs.launchpad.net/mir/+bug/1399690
17- rate = 10
18+ rate = 5
19 divisions = 5
20 jump = (width / divisions) // rate * rate
21 start_x = x + jump * (divisions - 1)

Subscribers

People subscribed via source and target branches