Merge lp:~canonical-platform-qa/unity8/nopy2 into lp:unity8

Proposed by Leo Arias
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1630
Merged at revision: 1680
Proposed branch: lp:~canonical-platform-qa/unity8/nopy2
Merge into: lp:unity8
Diff against target: 631 lines (+49/-99)
23 files modified
CODING (+5/-5)
cmake/modules/autopilot.cmake (+0/-8)
debian/control (+0/-8)
debian/rules (+2/-2)
tests/autopilot/setup.py (+2/-2)
tests/autopilot/unity8/application_lifecycle/tests/__init__.py (+2/-2)
tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py (+2/-4)
tests/autopilot/unity8/application_lifecycle/tests/test_url_dispatcher.py (+2/-2)
tests/autopilot/unity8/fixture_setup.py (+4/-4)
tests/autopilot/unity8/indicators/__init__.py (+1/-1)
tests/autopilot/unity8/indicators/tests/__init__.py (+1/-1)
tests/autopilot/unity8/indicators/tests/test_indicators.py (+2/-4)
tests/autopilot/unity8/process_helpers.py (+2/-9)
tests/autopilot/unity8/shell/__init__.py (+2/-2)
tests/autopilot/unity8/shell/emulators/create_interactive_notification.py (+2/-3)
tests/autopilot/unity8/shell/emulators/dash.py (+3/-3)
tests/autopilot/unity8/shell/fixture_setup.py (+2/-2)
tests/autopilot/unity8/shell/tests/__init__.py (+3/-3)
tests/autopilot/unity8/shell/tests/test_emulators.py (+4/-4)
tests/autopilot/unity8/shell/tests/test_lock_screen.py (+1/-9)
tests/autopilot/unity8/shell/tests/test_notifications.py (+4/-12)
tests/autopilot/unity8/shell/tests/test_tutorial.py (+2/-2)
tests/autopilot/unity8/shell/tests/test_upstart.py (+1/-7)
To merge this branch: bzr merge lp:~canonical-platform-qa/unity8/nopy2
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Ubuntu Unity PS integration team Pending
Review via email: mp+250659@code.launchpad.net

Commit message

Drop the support for python2 in autopilot tests.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

No required MPs.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

No, just ran the tests.

 * Did you make sure that your branch does not contain spurious tags?

Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes.

 * If you changed the UI, has there been a design review?

No UI changes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Are you doing the same for ubuntu-ui-toolkit-autopilot ? Otherwise it still pulls python 2.7 on the dependency chain for us.

Anyway this looks good

* Did you perform an exploratory manual test run of the code change and any related functionality?
Tests are still fine

* Did CI run pass?
No, but unrelated to this

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

> Are you doing the same for ubuntu-ui-toolkit-autopilot ? Otherwise it still
> pulls python 2.7 on the dependency chain for us.

Not yet. We need to dig a little on all the suites before removing it from the toolkit.
Unity was easier because only a handful of suites depend on it.

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Hey, while cleaning this up, IIUC we should replace libautopilot-qt dependency with autopilot-qt5 to prevent unnecessary qt4 installation.

Revision history for this message
Leo Arias (elopio) wrote :

> Hey, while cleaning this up, IIUC we should replace libautopilot-qt dependency
> with autopilot-qt5 to prevent unnecessary qt4 installation.

https://code.launchpad.net/~canonical-platform-qa/unity8/remove-qt4dep/+merge/252118

We also need to remove it from the toolkit: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1429158

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CODING'
2--- CODING 2014-09-26 10:02:48 +0000
3+++ CODING 2015-03-03 04:24:40 +0000
4@@ -24,7 +24,7 @@
5
6 this will:
7 - install the required dependencies to build, as well as run on the desktop
8- - it should also install unity-scope-home and unity-lens-application which
9+ - it should also install unity-scope-home and unity-lens-application which
10 are technically "recommends", not strict dependencies
11
12 build Unity 8
13@@ -104,8 +104,8 @@
14 - it's unsafe - anyone can connect to your device
15 - with TCP the Nexus 10 doesn't drop the adb connection when locking
16 the screen
17-- exporting ANDROID_SERIAL=$your_device_serial or
18- ANDROID_SERIAL=$your_device_ip:5555 will make adb not complain about
19+- exporting ANDROID_SERIAL=$your_device_serial or
20+ ANDROID_SERIAL=$your_device_ip:5555 will make adb not complain about
21 multiple devices
22 - you can export TARGET_IP=$your_device_ip TARGET_SSH_PORT=22 for run_on_device.sh
23 to not use adb forwarding - useful if you use multiple devices
24@@ -190,8 +190,8 @@
25
26 And then run a single test with
27
28-$ PYTHONPATH=../tests/autopilot autopilot run unity8.some.very.long.test.name
29+$ PYTHONPATH=../tests/autopilot autopilot3 run unity8.some.very.long.test.name
30
31 or run them all with
32
33-$ PYTHONPATH=../tests/autopilot autopilot run unity8
34+$ PYTHONPATH=../tests/autopilot autopilot3 run unity8
35
36=== modified file 'cmake/modules/autopilot.cmake'
37--- cmake/modules/autopilot.cmake 2014-07-31 14:06:09 +0000
38+++ cmake/modules/autopilot.cmake 2015-03-03 04:24:40 +0000
39@@ -13,12 +13,4 @@
40
41 add_dependencies(autopilot autopilot-${TEST_NAME})
42
43- add_custom_target(autopilot2-${TEST_NAME}
44- COMMAND UNITY_TESTING=1 LANG=C QML2_IMPORT_PATH=${SHELL_INSTALL_QML}/mocks python2 -m autopilot.run run ${TEST_SUITE}
45- WORKING_DIRECTORY ${WORKING_DIR}
46- DEPENDS fake_install
47- )
48-
49- add_dependencies(autopilot autopilot2-${TEST_NAME})
50-
51 endfunction()
52
53=== modified file 'debian/control'
54--- debian/control 2015-02-13 17:05:08 +0000
55+++ debian/control 2015-03-03 04:24:40 +0000
56@@ -31,10 +31,8 @@
57 libusermetricsoutput1-dev,
58 libxcb1-dev,
59 pkg-config,
60- python-setuptools,
61 python3-all:any,
62 python3-setuptools,
63- python:any (>= 2.7),
64 qml-module-qt-labs-folderlistmodel,
65 qml-module-qtquick-layouts,
66 qml-module-qtquick-xmllistmodel,
67@@ -144,11 +142,6 @@
68 libautopilot-qt (>= 1.4),
69 libqt5test5,
70 libqt5widgets5,
71- python-autopilot,
72- python-evdev,
73- python-fixtures,
74- python-gi,
75- python-mock,
76 python3-autopilot,
77 python3-evdev,
78 python3-fixtures,
79@@ -160,7 +153,6 @@
80 url-dispatcher-tools,
81 ${misc:Depends},
82 ${python3:Depends},
83- ${python:Depends},
84 ${shlibs:Depends},
85 Description: Test package for Unity 8 shell
86 Autopilot tests for the unity8 package
87
88=== modified file 'debian/rules'
89--- debian/rules 2015-02-26 19:39:54 +0000
90+++ debian/rules 2015-03-03 04:24:40 +0000
91@@ -14,7 +14,7 @@
92 export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
93
94 %:
95- dh $@ --parallel --fail-missing --with python2,python3
96+ dh $@ --parallel --fail-missing --with python3
97
98 override_dh_auto_clean:
99 dh_auto_clean
100@@ -32,7 +32,7 @@
101 override_dh_install:
102 # install autopilot tests
103 cd tests/autopilot; \
104- set -ex; for python in $(shell pyversions -r) $(shell py3versions -r); do \
105+ set -ex; for python in $(shell py3versions -r); do \
106 $$python setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb; \
107 done; \
108 cd $(CURDIR)
109
110=== modified file 'tests/autopilot/setup.py'
111--- tests/autopilot/setup.py 2013-07-23 09:54:32 +0000
112+++ tests/autopilot/setup.py 2015-03-03 04:24:40 +0000
113@@ -1,8 +1,8 @@
114-#!/usr/bin/python
115+#!/usr/bin/python3
116 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
117 #
118 # Unity Autopilot Test Suite
119-# Copyright (C) 2012-2013 Canonical
120+# Copyright (C) 2012, 2013, 2015 Canonical
121 #
122 # This program is free software: you can redistribute it and/or modify
123 # it under the terms of the GNU General Public License as published by
124
125=== modified file 'tests/autopilot/unity8/application_lifecycle/tests/__init__.py'
126--- tests/autopilot/unity8/application_lifecycle/tests/__init__.py 2014-06-11 15:36:51 +0000
127+++ tests/autopilot/unity8/application_lifecycle/tests/__init__.py 2015-03-03 04:24:40 +0000
128@@ -1,7 +1,7 @@
129 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
130 #
131 # Unity Autopilot Test Suite
132-# Copyright (C) 2014 Canonical
133+# Copyright (C) 2014, 2015 Canonical
134 #
135 # This program is free software: you can redistribute it and/or modify
136 # it under the terms of the GNU General Public License as published by
137@@ -28,7 +28,7 @@
138 class ApplicationLifeCycleTestCase(tests.UnityTestCase):
139
140 def setUp(self):
141- super(ApplicationLifeCycleTestCase, self).setUp()
142+ super().setUp()
143 self._qml_mock_enabled = False
144 self._data_dirs_mock_enabled = False
145 unity_proxy = self.launch_unity()
146
147=== modified file 'tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py'
148--- tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py 2014-12-01 12:57:57 +0000
149+++ tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py 2015-03-03 04:24:40 +0000
150@@ -1,7 +1,7 @@
151 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
152 #
153 # Unity Autopilot Test Suite
154-# Copyright (C) 2013, 2014 Canonical
155+# Copyright (C) 2013, 2014, 2015 Canonical
156 #
157 # This program is free software: you can redistribute it and/or modify
158 # it under the terms of the GNU General Public License as published by
159@@ -19,8 +19,6 @@
160
161 """Tests for the application lifecycle."""
162
163-from __future__ import absolute_import
164-
165 import logging
166 import os
167
168@@ -40,7 +38,7 @@
169 def setUp(self):
170 if model() == 'Desktop':
171 self.skipTest('Test cannot be run on the desktop.')
172- super(ApplicationLifecycleTests, self).setUp()
173+ super().setUp()
174
175 def swipe_screen_from_right(self):
176 width = self.main_window.width
177
178=== modified file 'tests/autopilot/unity8/application_lifecycle/tests/test_url_dispatcher.py'
179--- tests/autopilot/unity8/application_lifecycle/tests/test_url_dispatcher.py 2014-07-31 05:52:29 +0000
180+++ tests/autopilot/unity8/application_lifecycle/tests/test_url_dispatcher.py 2015-03-03 04:24:40 +0000
181@@ -1,7 +1,7 @@
182 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
183 #
184 # Unity Autopilot Test Suite
185-# Copyright (C) 2014 Canonical
186+# Copyright (C) 2014, 2015 Canonical
187 #
188 # This program is free software: you can redistribute it and/or modify
189 # it under the terms of the GNU General Public License as published by
190@@ -32,7 +32,7 @@
191 def setUp(self):
192 if platform.model() == 'Desktop':
193 self.skipTest("URL dispatcher doesn't work on the desktop.")
194- super(URLDispatcherTestCase, self).setUp()
195+ super().setUp()
196
197 def test_swipe_out_application_started_by_url_dispatcher(self):
198 _, desktop_file_path = self.create_test_application()
199
200=== modified file 'tests/autopilot/unity8/fixture_setup.py'
201--- tests/autopilot/unity8/fixture_setup.py 2015-01-22 13:11:51 +0000
202+++ tests/autopilot/unity8/fixture_setup.py 2015-03-03 04:24:40 +0000
203@@ -38,13 +38,13 @@
204 :type variables: A dictionary.
205
206 """
207- super(LaunchDashApp, self).__init__()
208+ super().__init__()
209 self.binary_path = binary_path
210 self.variables = variables
211
212 def setUp(self):
213 """Launch the dash app when the fixture is used."""
214- super(LaunchDashApp, self).setUp()
215+ super().setUp()
216 self.addCleanup(self.stop_application)
217 self.application_proxy = self.launch_application()
218
219@@ -69,11 +69,11 @@
220 class DisplayRotationLock(fixtures.Fixture):
221
222 def __init__(self, enable):
223- super(DisplayRotationLock, self).__init__()
224+ super().__init__()
225 self.enable = enable
226
227 def setUp(self):
228- super(DisplayRotationLock, self).setUp()
229+ super().setUp()
230 original_state = self._is_rotation_lock_enabled()
231 if self.enable != original_state:
232 self.addCleanup(self._set_rotation_lock, original_state)
233
234=== modified file 'tests/autopilot/unity8/indicators/__init__.py'
235--- tests/autopilot/unity8/indicators/__init__.py 2015-01-21 04:15:31 +0000
236+++ tests/autopilot/unity8/indicators/__init__.py 2015-03-03 04:24:40 +0000
237@@ -34,7 +34,7 @@
238 return False
239
240
241-class DisplayIndicator(object):
242+class DisplayIndicator():
243
244 def __init__(self, main_window):
245 self._main_window = main_window
246
247=== modified file 'tests/autopilot/unity8/indicators/tests/__init__.py'
248--- tests/autopilot/unity8/indicators/tests/__init__.py 2015-01-20 17:56:49 +0000
249+++ tests/autopilot/unity8/indicators/tests/__init__.py 2015-03-03 04:24:40 +0000
250@@ -29,6 +29,6 @@
251 def setUp(self):
252 if platform.model() == 'Desktop':
253 self.skipTest('Test cannot be run on the desktop.')
254- super(IndicatorTestCase, self).setUp()
255+ super().setUp()
256 self.unity_proxy = self.launch_unity()
257 process_helpers.unlock_unity(self.unity_proxy)
258
259=== modified file 'tests/autopilot/unity8/indicators/tests/test_indicators.py'
260--- tests/autopilot/unity8/indicators/tests/test_indicators.py 2015-01-20 17:56:49 +0000
261+++ tests/autopilot/unity8/indicators/tests/test_indicators.py 2015-03-03 04:24:40 +0000
262@@ -16,8 +16,6 @@
263 # You should have received a copy of the GNU General Public License
264 # along with this program. If not, see <http://www.gnu.org/licenses/>.
265
266-from __future__ import absolute_import
267-
268 from testscenarios import multiply_scenarios
269
270 from autopilot import platform
271@@ -42,7 +40,7 @@
272 )
273
274 def setUp(self):
275- super(IndicatorExistsTestCase, self).setUp()
276+ super().setUp()
277 if (platform.model() == 'Nexus 10' and
278 self.indicator_name == 'indicator-bluetooth'):
279 self.skipTest('Nexus 10 does not have bluetooth at the moment.')
280@@ -77,7 +75,7 @@
281 )
282
283 def setUp(self):
284- super(IndicatorPageTitleMatchesWidgetTestCase, self).setUp()
285+ super().setUp()
286 if (platform.model() == 'Nexus 10' and
287 self.indicator_name == 'indicator-bluetooth'):
288 self.skipTest('Nexus 10 does not have bluetooth at the moment.')
289
290=== modified file 'tests/autopilot/unity8/process_helpers.py'
291--- tests/autopilot/unity8/process_helpers.py 2014-09-08 10:33:50 +0000
292+++ tests/autopilot/unity8/process_helpers.py 2015-03-03 04:24:40 +0000
293@@ -1,7 +1,7 @@
294 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
295 #
296 # Unity Autopilot Utilities
297-# Copyright (C) 2013, 2014 Canonical
298+# Copyright (C) 2013, 2014, 2015 Canonical
299 #
300 # This program is free software: you can redistribute it and/or modify
301 # it under the terms of the GNU General Public License as published by
302@@ -19,16 +19,9 @@
303
304 import logging
305 import subprocess
306-import sys
307 import dbus
308
309-# This has to work in both python 3 (ap 1.5) and py2 (ap legacy 1.4.1) so we
310-# pick the correct location in each case. Remove the py2 branch once we no
311-# longer need to support python 2.
312-if sys.version >= '3':
313- from autopilot.exceptions import ProcessSearchError
314-else:
315- from autopilot.introspection import ProcessSearchError
316+from autopilot.exceptions import ProcessSearchError
317 from autopilot.introspection import get_proxy_object_for_existing_process
318
319 from unity8.shell import emulators
320
321=== modified file 'tests/autopilot/unity8/shell/__init__.py'
322--- tests/autopilot/unity8/shell/__init__.py 2015-02-17 15:33:39 +0000
323+++ tests/autopilot/unity8/shell/__init__.py 2015-03-03 04:24:40 +0000
324@@ -1,7 +1,7 @@
325 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
326 #
327 # Unity Autopilot Test Suite
328-# Copyright (C) 2012-2013 Canonical
329+# Copyright (C) 2012-2015 Canonical
330 #
331 # This program is free software: you can redistribute it and/or modify
332 # it under the terms of the GNU General Public License as published by
333@@ -38,7 +38,7 @@
334 return wrapper
335
336
337-class DragMixin(object):
338+class DragMixin():
339 def _drag(self, x1, y1, x2, y2):
340 # XXX This ugly code is here just temporarily, waiting for drag
341 # improvements to land on autopilot so we don't have to access device
342
343=== modified file 'tests/autopilot/unity8/shell/emulators/create_interactive_notification.py'
344--- tests/autopilot/unity8/shell/emulators/create_interactive_notification.py 2015-01-06 12:16:51 +0000
345+++ tests/autopilot/unity8/shell/emulators/create_interactive_notification.py 2015-03-03 04:24:40 +0000
346@@ -1,10 +1,9 @@
347-#!/usr/bin/env python
348-from __future__ import print_function
349+#!/usr/bin/env python3
350
351 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
352 #
353 # Unity Autopilot Test Suite
354-# Copyright (C) 2012-2013 Canonical
355+# Copyright (C) 2012, 2013, 2014, 2015 Canonical
356 #
357 # This program is free software: you can redistribute it and/or modify
358 # it under the terms of the GNU General Public License as published by
359
360=== modified file 'tests/autopilot/unity8/shell/emulators/dash.py'
361--- tests/autopilot/unity8/shell/emulators/dash.py 2014-12-15 22:42:44 +0000
362+++ tests/autopilot/unity8/shell/emulators/dash.py 2015-03-03 04:24:40 +0000
363@@ -1,7 +1,7 @@
364 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
365 #
366 # Unity Autopilot Test Suite
367-# Copyright (C) 2012, 2013, 2014 Canonical
368+# Copyright (C) 2012, 2013, 2014, 2015 Canonical
369 #
370 # This program is free software: you can redistribute it and/or modify
371 # it under the terms of the GNU General Public License as published by
372@@ -30,7 +30,7 @@
373 logger = logging.getLogger(__name__)
374
375
376-class DashApp(object):
377+class DashApp():
378
379 """Autopilot helper for the Dash app."""
380
381@@ -45,7 +45,7 @@
382 """An emulator that understands the Dash."""
383
384 def __init__(self, *args):
385- super(Dash, self).__init__(*args)
386+ super().__init__(*args)
387 self.dash_content_list = self.wait_select_single(
388 'QQuickListView', objectName='dashContentList')
389
390
391=== modified file 'tests/autopilot/unity8/shell/fixture_setup.py'
392--- tests/autopilot/unity8/shell/fixture_setup.py 2015-02-03 15:16:58 +0000
393+++ tests/autopilot/unity8/shell/fixture_setup.py 2015-03-03 04:24:40 +0000
394@@ -1,7 +1,7 @@
395 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
396 #
397 # Unity Autopilot Test Suite
398-# Copyright (C) 2014 Canonical
399+# Copyright (C) 2014, 2015 Canonical
400 #
401 # This program is free software: you can redistribute it and/or modify
402 # it under the terms of the GNU General Public License as published by
403@@ -31,7 +31,7 @@
404 class FakeScopes(fixtures.Fixture):
405
406 def setUp(self):
407- super(FakeScopes, self).setUp()
408+ super().setUp()
409 self.useFixture(
410 fixtures.EnvironmentVariable(
411 'QML2_IMPORT_PATH',
412
413=== modified file 'tests/autopilot/unity8/shell/tests/__init__.py'
414--- tests/autopilot/unity8/shell/tests/__init__.py 2015-02-05 20:21:00 +0000
415+++ tests/autopilot/unity8/shell/tests/__init__.py 2015-03-03 04:24:40 +0000
416@@ -1,7 +1,7 @@
417 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
418 #
419 # Unity Autopilot Test Suite
420-# Copyright (C) 2012, 2013, 2014 Canonical
421+# Copyright (C) 2012, 2013, 2014, 2015 Canonical
422 #
423 # This program is free software: you can redistribute it and/or modify
424 # it under the terms of the GNU General Public License as published by
425@@ -148,7 +148,7 @@
426 sys.exit(2)
427
428 def setUp(self):
429- super(UnityTestCase, self).setUp()
430+ super().setUp()
431 if is_unity7_running():
432 self.useFixture(toolkit_fixtures.HideUnity7Launcher())
433
434@@ -399,7 +399,7 @@
435 environment = {}
436
437 def setUp(self):
438- super(DashBaseTestCase, self).setUp()
439+ super().setUp()
440
441 if is_unity7_running():
442 self.useFixture(toolkit_fixtures.HideUnity7Launcher())
443
444=== modified file 'tests/autopilot/unity8/shell/tests/test_emulators.py'
445--- tests/autopilot/unity8/shell/tests/test_emulators.py 2014-10-23 20:29:31 +0000
446+++ tests/autopilot/unity8/shell/tests/test_emulators.py 2015-03-03 04:24:40 +0000
447@@ -1,7 +1,7 @@
448 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
449 #
450 # Unity Autopilot Test Suite
451-# Copyright (C) 2014 Canonical
452+# Copyright (C) 2014, 2015 Canonical
453 #
454 # This program is free software: you can redistribute it and/or modify
455 # it under the terms of the GNU General Public License as published by
456@@ -38,7 +38,7 @@
457 scenarios = tests._get_device_emulation_scenarios()
458
459 def setUp(self):
460- super(MainWindowTestCase, self).setUp()
461+ super().setUp()
462 unity_proxy = self.launch_unity()
463 process_helpers.unlock_unity(unity_proxy)
464
465@@ -110,7 +110,7 @@
466 def setUp(self):
467 # Set up the fake scopes before launching unity.
468 self.useFixture(fixture_setup.FakeScopes())
469- super(GenericScopeViewEmulatorTestCase, self).setUp()
470+ super().setUp()
471 self.generic_scope = self.dash.open_scope('MockScope1')
472
473 def test_open_preview(self):
474@@ -129,7 +129,7 @@
475 def setUp(self):
476 # Set up the fake scopes before launching unity.
477 self.useFixture(fixture_setup.FakeScopes())
478- super(DashAppsEmulatorTestCase, self).setUp()
479+ super().setUp()
480 self.applications_scope = self.dash.open_scope('clickscope')
481
482 def test_get_applications_should_return_correct_applications(self):
483
484=== modified file 'tests/autopilot/unity8/shell/tests/test_lock_screen.py'
485--- tests/autopilot/unity8/shell/tests/test_lock_screen.py 2015-02-05 20:21:00 +0000
486+++ tests/autopilot/unity8/shell/tests/test_lock_screen.py 2015-03-03 04:24:40 +0000
487@@ -1,7 +1,7 @@
488 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
489 #
490 # Unity Autopilot Test Suite
491-# Copyright (C) 2012, 2013, 2014 Canonical
492+# Copyright (C) 2012, 2013, 2014, 2015 Canonical
493 #
494 # This program is free software: you can redistribute it and/or modify
495 # it under the terms of the GNU General Public License as published by
496@@ -17,22 +17,14 @@
497 # along with this program. If not, see <http://www.gnu.org/licenses/>.
498 #
499
500-
501-from __future__ import absolute_import
502-
503 from unity8.shell.tests import UnityTestCase, _get_device_emulation_scenarios
504
505 from autopilot.matchers import Eventually
506-import sys
507 from testtools.matchers import Equals
508 import logging
509
510 logger = logging.getLogger(__name__)
511
512-# py2 compatible alias for py3
513-if sys.version >= '3':
514- basestring = str
515-
516
517 class TestLockscreen(UnityTestCase):
518
519
520=== modified file 'tests/autopilot/unity8/shell/tests/test_notifications.py'
521--- tests/autopilot/unity8/shell/tests/test_notifications.py 2015-02-17 15:33:39 +0000
522+++ tests/autopilot/unity8/shell/tests/test_notifications.py 2015-03-03 04:24:40 +0000
523@@ -1,7 +1,7 @@
524 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
525 #
526 # Unity Autopilot Test Suite
527-# Copyright (C) 2012, 2013, 2014 Canonical
528+# Copyright (C) 2012, 2013, 2014, 2015 Canonical
529 #
530 # This program is free software: you can redistribute it and/or modify
531 # it under the terms of the GNU General Public License as published by
532@@ -19,8 +19,6 @@
533
534 """Tests for Notifications"""
535
536-from __future__ import absolute_import
537-
538 from unity8 import shell
539 from unity8.process_helpers import unlock_unity
540 from unity8.shell.tests import UnityTestCase, _get_device_emulation_scenarios
541@@ -34,15 +32,9 @@
542 import logging
543 import signal
544 import subprocess
545-import sys
546
547 logger = logging.getLogger(__name__)
548
549-# from __future__ import range
550-# (python3's range, is same as python2's xrange)
551-if sys.version_info < (3,):
552- range = xrange
553-
554
555 class NotificationsBase(UnityTestCase):
556 """Base class for all notification tests that provides helper methods."""
557@@ -118,7 +110,7 @@
558 """Collection of test for Interactive tests including snap decisions."""
559
560 def setUp(self):
561- super(InteractiveNotificationBase, self).setUp()
562+ super().setUp()
563 # Need to keep track when we launch the notification script.
564 self._notify_proc = None
565
566@@ -338,7 +330,7 @@
567 action_string = "%s,%s" % (action_id, action_label)
568 script_args.extend(['--action', action_string])
569
570- python_bin = subprocess.check_output(['which', 'python']).strip()
571+ python_bin = subprocess.check_output(['which', 'python3']).strip()
572 command = [python_bin, self._get_notify_script()] + script_args
573 logger.info("Launching snap-decision notification as: %s", command)
574 self._notify_proc = subprocess.Popen(
575@@ -410,7 +402,7 @@
576 """Collection of tests for Emphemeral notifications (non-interactive.)"""
577
578 def setUp(self):
579- super(EphemeralNotificationsTests, self).setUp()
580+ super().setUp()
581 # Because we are using the Notify library we need to init and un-init
582 # otherwise we get crashes.
583 Notify.init("Autopilot Ephemeral Notification Tests")
584
585=== modified file 'tests/autopilot/unity8/shell/tests/test_tutorial.py'
586--- tests/autopilot/unity8/shell/tests/test_tutorial.py 2015-02-05 17:22:12 +0000
587+++ tests/autopilot/unity8/shell/tests/test_tutorial.py 2015-03-03 04:24:40 +0000
588@@ -1,7 +1,7 @@
589 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
590 #
591 # Unity Autopilot Test Suite
592-# Copyright (C) 2014 Canonical
593+# Copyright (C) 2014, 2015 Canonical
594 #
595 # This program is free software: you can redistribute it and/or modify
596 # it under the terms of the GNU General Public License as published by
597@@ -31,7 +31,7 @@
598 class TutorialTestCase(tests.UnityTestCase):
599
600 def setUp(self):
601- super(TutorialTestCase, self).setUp()
602+ super().setUp()
603 self._qml_mock_enabled = False
604 self._data_dirs_mock_enabled = False
605
606
607=== modified file 'tests/autopilot/unity8/shell/tests/test_upstart.py'
608--- tests/autopilot/unity8/shell/tests/test_upstart.py 2014-07-31 21:02:02 +0000
609+++ tests/autopilot/unity8/shell/tests/test_upstart.py 2015-03-03 04:24:40 +0000
610@@ -38,12 +38,6 @@
611
612 logger = logging.getLogger(__name__)
613
614-# from __future__ import range
615-# (python3's range, is same as python2's xrange)
616-import sys
617-if sys.version_info < (3,):
618- range = xrange
619-
620
621 class UpstartIntegrationTests(UnityTestCase):
622
623@@ -95,7 +89,7 @@
624 self.addCleanup(ensure_stopped)
625
626 def _set_proxy(self):
627- super(UpstartIntegrationTests, self)._set_proxy(
628+ super()._set_proxy(
629 get_proxy_object_for_existing_process(
630 pid=self.process.pid,
631 emulator_base=UnityEmulatorBase,))

Subscribers

People subscribed via source and target branches