Merge lp:~canonical-platform-qa/unity8/fix1446846-test_slider_revert into lp:unity8

[Leo Arias]

Fix one of the failing tests reported in bug #1446846: The slider value is reverted so we need to check that we have moved the slider to the right value before releasing the finger.

[Albert Astals Cid (aacid)]

Doesn't https://code.launchpad.net/~nick-dedekind/unity8/fix-autopilot-failures-1446846/+merge/258411 already fix them?

review: Needs Information

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1778
http://jenkins.qa.ubuntu.com/job/unity8-ci/5732/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/10
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-wily-mako/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/11
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20579

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5732/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

> Doesn't https://code.launchpad.net/~nick-dedekind/unity8/fix-autopilot-
> failures-1446846/+merge/258411 already fix them?

No, it doesn't. Take a look at nick's branch and you will see the error that this branch fixes.

But, there is a bug in autopilot that prevents this to land: https://bugs.launchpad.net/autopilot/+bug/1457212

We could either do a quicker move in here, cast the pointer to it's backend, or fix the bug in autopilot.

Back to work in progress.

[Albert Astals Cid (aacid)]

This is the wrong fix, you're just making the test pass, but if the slider is reverted, we need to find why it's reverted instead of ignore it, right?

review: Needs Fixing

[Leo Arias (elopio)]

tsdgeos: I think you are right. I misunderstood the test and dednick has a better branch to solve the problem.

review: Disapprove

Unmerged revisions

1778. By Leo Arias on 2015-05-18

Fix one of the failing tests reported in bug #1446846: The slider value is reverted so we need to check that we have moved the slider to the right value before releasing the finger.

=== modified file 'tests/autopilot/unity8/indicators/__init__.py'
--- tests/autopilot/unity8/indicators/__init__.py	2015-04-28 15:20:13 +0000
+++ tests/autopilot/unity8/indicators/__init__.py	2015-05-18 18:15:40 +0000
@@ -187,8 +187,11 @@
         start_y = stop_y = y + height/2
         stop_x = x
 
-        self.pointing_device.drag(start_x, start_y, stop_x, stop_y, rate)
+        self.pointing_device.move(start_x, start_y, rate=rate)
+        self.pointing_device.press()
+        self.pointing_device.move(stop_x, stop_y, rate=rate)
         self.value.wait_for(self.minimumValue, timeout)
+        self.pointing_device.release()
 
     def slide_right(self, timeout=10):
         x, y, width, height = self.globalRect
@@ -198,5 +201,8 @@
         start_y = stop_y = y + height/2
         stop_x = x + width
 
-        self.pointing_device.drag(start_x, start_y, stop_x, stop_y, rate)
+        self.pointing_device.move(start_x, start_y, rate=rate)
+        self.pointing_device.press()
+        self.pointing_device.move(stop_x, stop_y, rate=rate)
         self.value.wait_for(self.maximumValue, timeout)
+        self.pointing_device.release()