Unity 8

Merge lp:~canonical-platform-qa/unity8/fix1335548-click_scope_item into lp:unity8

  1. fix1335548-click_scope_item
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Michał Sawicz
Approved revision: 984
Merged at revision: 1157
Proposed branch: lp:~canonical-platform-qa/unity8/fix1335548-click_scope_item
Merge into: lp:unity8
Prerequisite: lp:~elopio/unity8/flake8
Diff against target: 58 lines (+16/-6)
1 file modified
tests/autopilot/unity8/shell/emulators/dash.py (+16/-6)
To merge this branch: bzr merge lp:~canonical-platform-qa/unity8/fix1335548-click_scope_item
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Needs Fixing
Brendan Donegan Pending
Review via email: mp+227570@code.launchpad.net

This proposal supersedes a proposal from 2014-06-29.

Commit message

Added an autopilot helper to click a scope item.

Description of the change

This is already tested on the test for opening a preview. No need to duplicate that adding a new test.

 * Are there any related MPs required for this MP to build/function as expected? Please list.

No MPs related.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes, ran the tests, explored the QML tree with autopilot vis, tested with the click scope tests.

 * Did you make sure that your branch does not contain spurious tags?

Yes, I did.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

No debian changes.

 * If you changed the UI, has there been a design review?

No UI changes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:979
http://jenkins.qa.ubuntu.com/job/unity8-ci/3263/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1338
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/267
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/357
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/357
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/357/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/357
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1649
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2250
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2250/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8997

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3263/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:980
http://jenkins.qa.ubuntu.com/job/unity8-ci/3371/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1728
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/375
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/465
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/465
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/465/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/465
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1990
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2774
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2774/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9503

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3371/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Text conflict in tests/autopilot/unity8/shell/emulators/dash.py
1 conflicts encountered.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:981
http://jenkins.qa.ubuntu.com/job/unity8-ci/3389/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1804/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/393
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/483
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/483
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/483/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/483
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2065/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2886
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2886/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9623

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3389/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:981
http://jenkins.qa.ubuntu.com/job/unity8-ci/3396/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1836
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/400/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/490
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/490
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/490/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/490
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2097
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2925
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2925/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9663

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3396/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:981
http://jenkins.qa.ubuntu.com/job/unity8-ci/3397/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1839
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/403
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/491
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/491
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/491/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/491
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2101
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2928
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2928/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9668

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3397/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

The error was one of the qmlscene crashes that we are finding more often now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:981
http://jenkins.qa.ubuntu.com/job/unity8-ci/3407/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1867
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/411
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/501
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/501
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/501/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/501
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2126
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2963
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2963/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9701

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3407/rebuild

review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

Just a resubmit to make it a team branch, following the new QA team policy.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:982
http://jenkins.qa.ubuntu.com/job/unity8-ci/3502/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2243
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/504
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/596
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/596
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/596/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/596
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2447
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3427
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3427/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10142

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3502/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:982
http://jenkins.qa.ubuntu.com/job/unity8-ci/3509/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2263
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/511
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/603
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/603
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/603/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/603
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2463
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3453
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3453/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10166

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3509/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:982
http://jenkins.qa.ubuntu.com/job/unity8-ci/3516/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2273
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/517
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/610
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/610
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/610/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/610
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2471
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3466
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3466/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10177

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3516/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:982
http://jenkins.qa.ubuntu.com/job/unity8-ci/3534/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2321
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/536
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/628
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/628
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/628/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/628
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2507
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3531/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10228

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3534/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Text conflict in tests/autopilot/unity8/shell/emulators/dash.py
1 conflicts encountered.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:982
http://jenkins.qa.ubuntu.com/job/unity8-ci/3632/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2558/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/634/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3801/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3632/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

Back to work in progress because the dash app branch will break this. Working on that first.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:984
http://jenkins.qa.ubuntu.com/job/unity8-ci/3857/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3336
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/859
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/951
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/951
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/951/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/951
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3273
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4582
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4582/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11266

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3857/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Should we not have a test for this emulator?

review: Needs Information
Revision history for this message
Michał Sawicz (saviq) wrote :

> Should we not have a test for this emulator?

Ignore please, read description.

Please run http://people.canonical.com/~msawicz/unity8/strip-u8-tags.py on this branch, and any local checkouts you might have.

review: Needs Fixing
Revision history for this message
Leo Arias (elopio) wrote :

Done. Thanks for the review. It is ready again.

Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yeas.

 * Did CI run pass? If not, please explain why.
Unrelated QML failures fixed in another branch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/unity8/shell/emulators/dash.py'
2--- tests/autopilot/unity8/shell/emulators/dash.py 2014-08-06 13:16:55 +0000
3+++ tests/autopilot/unity8/shell/emulators/dash.py 2014-08-11 15:45:24 +0000
4@@ -24,7 +24,6 @@
5
6 from autopilot import logging as autopilot_logging
7 from autopilot.introspection import dbus
8-from testtools.matchers import MatchesAny, Equals
9 from ubuntuuitoolkit import emulators as toolkit_emulators
10
11
12@@ -146,7 +145,8 @@
13 current_header.globalRect.y +
14 current_header.height / 4)
15 self.pointing_device.click()
16- headerContainer = current_header.select_single(objectName="headerContainer")
17+ headerContainer = current_header.select_single(
18+ objectName="headerContainer")
19 headerContainer.contentY.wait_for(0)
20 search_text_field = self._get_search_text_field()
21 search_text_field.write(query)
22@@ -177,22 +177,32 @@
23 """Open the preview of an application.
24
25 :parameter category: The name of the category where the application is.
26- :app_name: The name of the application.
27+ :parameter app_name: The name of the application.
28 :return: The opened preview.
29
30 """
31- category_element = self._get_category_element(category)
32- icon = category_element.select_single('AbstractButton', title=app_name)
33 # FIXME some categories need a long press in order to see the preview.
34 # Some categories do not show previews, like recent apps.
35 # --elopio - 2014-1-14
36- self.pointing_device.click_object(icon)
37+ self.click_scope_item(category, app_name)
38 preview_list = self.wait_select_single(
39 'PreviewListView', objectName='previewListView')
40 preview_list.x.wait_for(0)
41 return preview_list.select_single(
42 Preview, objectName='preview{}'.format(preview_list.currentIndex))
43
44+ @autopilot_logging.log_action(logger.debug)
45+ def click_scope_item(self, category, title):
46+ """Click an item from the scope.
47+
48+ :parameter category: The name of the category where the item is.
49+ :parameter title: The title of the item.
50+
51+ """
52+ category_element = self._get_category_element(category)
53+ icon = category_element.select_single('AbstractButton', title=title)
54+ self.pointing_device.click_object(icon)
55+
56 def _get_category_element(self, category):
57 try:
58 return self.wait_select_single(

Subscribers

People subscribed via source and target branches