Merge lp:~canonical-platform-qa/unity8/1421009-hangs-on-boot into lp:unity8

Proposed by Vincent Ladeuil
Status: Work in progress
Proposed branch: lp:~canonical-platform-qa/unity8/1421009-hangs-on-boot
Merge into: lp:unity8
Diff against target: 62 lines (+52/-0)
2 files modified
debian/tests/control (+17/-0)
debian/tests/doesnt-hang-on-boot (+35/-0)
To merge this branch: bzr merge lp:~canonical-platform-qa/unity8/1421009-hangs-on-boot
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Needs Information
Martin Pitt Needs Fixing
Review via email: mp+257408@code.launchpad.net

Commit message

Add a dep8 test to reproduce bug #1421009

Description of the change

This proposal add a dep8 test to reproduce https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1421009

It can be run from a unity8 branch with:

$ adt-run -B --unbuilt-tree . -o ../results --- ssh -s adb -- -p <pass{word,phrase>

It's not ready to land as-is, when run on the desktop is doesn't test unity8 (but it probably could with some more work).

I thought it was worth sharing since it provides a way to put a phone into the
broken state for developers to investigate.

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Very useful to have! Although with reboot 60 or even 100, because of the findings of the fluctuation of the problem.

Revision history for this message
Vincent Ladeuil (vila) wrote :

> Very useful to have! Although with reboot 60 or even 100, because of the
> findings of the fluctuation of the problem.

Bumped to 100 in revno 1750.

Revision history for this message
Martin Pitt (pitti) wrote :

"needs fixing" for the overzealous Depends:, the others are just simplification. Thanks!

review: Needs Fixing
Revision history for this message
Martin Pitt (pitti) wrote :

Found another bug.

Revision history for this message
Vincent Ladeuil (vila) wrote :

@Martin: shell advices much appreciated, keep them coming ;)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Is this something we would actually want to land or was just for debugging that bug?

review: Needs Information
Revision history for this message
Vincent Ladeuil (vila) wrote :

> Is this something we would actually want to land or was just for debugging
> that bug?

A bit of both but the plan is unclear :-/

It was useful to reproduce the bug and validate the workaround.

As such it sounds like a good regression test and can be used to gate the real fix.

I'll mark it wip until a decision is taken.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

1752. By Vincent Ladeuil

Further simplifications recommended by someone who knows how to write shell ;)

1751. By Vincent Ladeuil

We test unity8, depends on it to avoid installing too much.

1750. By Vincent Ladeuil

In at least one case, the hang happened after 54 reboots so doubling that number to validate the workaround in silo 17 and guard against regressions.

1749. By Vincent Ladeuil

Add a dep8 test reproducing https://bugs.launchpad.net/bugs/1421009.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'debian/tests'
2=== added file 'debian/tests/control'
3--- debian/tests/control 1970-01-01 00:00:00 +0000
4+++ debian/tests/control 2015-04-29 09:29:35 +0000
5@@ -0,0 +1,17 @@
6+# Copyright 2015 Canonical
7+#
8+# This program is free software: you can redistribute it and/or modify it
9+# under the terms of the GNU General Public License version 3, as published
10+# by the Free Software Foundation.
11+#
12+# This program is distributed in the hope that it will be useful,
13+# but WITHOUT ANY WARRANTY; without even the implied warranty of
14+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15+# GNU General Public License for more details.
16+#
17+# You should have received a copy of the GNU General Public License
18+# along with this program. If not, see <http://www.gnu.org/licenses/>.
19+
20+Tests: doesnt-hang-on-boot
21+Depends: unity8
22+Restrictions: needs-root
23
24=== added file 'debian/tests/doesnt-hang-on-boot'
25--- debian/tests/doesnt-hang-on-boot 1970-01-01 00:00:00 +0000
26+++ debian/tests/doesnt-hang-on-boot 2015-04-29 09:29:35 +0000
27@@ -0,0 +1,35 @@
28+#!/bin/sh
29+
30+# Copyright 2015 Canonical
31+#
32+# This program is free software: you can redistribute it and/or modify it
33+# under the terms of the GNU General Public License version 3, as published
34+# by the Free Software Foundation.
35+#
36+# This program is distributed in the hope that it will be useful,
37+# but WITHOUT ANY WARRANTY; without even the implied warranty of
38+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
39+# GNU General Public License for more details.
40+#
41+# You should have received a copy of the GNU General Public License
42+# along with this program. If not, see <http://www.gnu.org/licenses/>.
43+
44+set +e
45+
46+reboots=100
47+
48+if [ -z ${ADT_REBOOT_MARK} ] ; then
49+ iteration=1
50+else
51+ iteration=$((ADT_REBOOT_MARK+1))
52+fi
53+
54+if [ $((iteration)) -ge $((reboots)) ] ; then
55+ # Success
56+ echo "Successfully booted ${iteration} times"
57+ exit 0
58+else
59+ rm -fR ~/.cache/QML
60+ echo "Reboot #${iteration}"
61+ /tmp/autopkgtest-reboot ${iteration}
62+fi

Subscribers

People subscribed via source and target branches