Merge lp:~canonical-platform-qa/ubuntu-ui-toolkit/fix_keyboard_bug1523501 into lp:ubuntu-ui-toolkit/staging

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1754
Proposed branch: lp:~canonical-platform-qa/ubuntu-ui-toolkit/fix_keyboard_bug1523501
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 24 lines (+2/-2)
2 files modified
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py (+1/-1)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/ubuntu-ui-toolkit/fix_keyboard_bug1523501
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu SDK team Pending
Review via email: mp+279797@code.launchpad.net

Commit message

Only the OSK has the _keyboard attribute which we need for getting the info about it, so only try to use that if the keyboard is OSK

Description of the change

Only the OSK has the _keyboard attribute which we need for getting the info about it, so only try to use that if the keyboard is OSK

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py'
2--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py 2015-09-22 15:56:35 +0000
3+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py 2015-12-07 16:33:49 +0000
4@@ -60,7 +60,7 @@
5 restart_maliit_with_testability()
6 return input.Keyboard.create('OSK')
7 else:
8- return input.Keyboard.create()
9+ return None
10
11
12 def restart_maliit_with_testability():
13
14=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py'
15--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py 2015-10-07 20:50:20 +0000
16+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py 2015-12-07 16:33:49 +0000
17@@ -38,7 +38,7 @@
18 container.globalRect.y + container.globalRect.height
19 for container in containers if container.globalRect.height > 0]
20 keyboard = _common.get_keyboard()
21- if keyboard._keyboard.is_available():
22+ if keyboard and keyboard._keyboard.is_available():
23 containers_bottom.append(keyboard._keyboard.keyboard.globalRect.y)
24 return min(containers_bottom)
25

Subscribers

People subscribed via source and target branches