Merge lp:~canonical-platform-qa/ubuntu-ui-toolkit/fix1451945-click_element_doc into lp:ubuntu-ui-toolkit/staging

Proposed by Leo Arias on 2015-05-05
Status: Merged
Approved by: Zoltan Balogh on 2015-06-30
Approved revision: 1499
Merged at revision: 1542
Proposed branch: lp:~canonical-platform-qa/ubuntu-ui-toolkit/fix1451945-click_element_doc
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 13 lines (+2/-1)
1 file modified
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py (+2/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/ubuntu-ui-toolkit/fix1451945-click_element_doc
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-06-30
Zoltan Balogh (community) 2015-05-05 Approve on 2015-05-15
Nicholas Skaggs (community) Approve on 2015-05-05
Review via email: mp+258287@code.launchpad.net

Commit Message

Updated the documentation of the autopilot click_element helpers.

To post a comment you must log in.
Nicholas Skaggs (nskaggs) wrote :

Needs to be looked at across the board, but +1

review: Approve
Nicholas Skaggs (nskaggs) wrote :

Actually, looking at the code this seems to the be only one:

grep -r "parameter objectName"
_custom_proxy_objects/_qquicklistview.py: :parameter objectName: The objectName property of the element to click.

Zoltan Balogh (bzoltan) wrote :

Let it go

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py'
2--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py 2015-03-18 04:24:19 +0000
3+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py 2015-05-05 17:21:22 +0000
4@@ -37,7 +37,8 @@
5
6 It swipes the element into view if it's center is not visible.
7
8- :parameter objectName: The objectName property of the element to click.
9+ :parameter object_name: The objectName property of the element to
10+ click.
11 :parameter direction: The direction where the element is, it can be
12 either 'above' or 'below'. Default value is None, which means we
13 don't know where the object is and we will need to search the full

Subscribers

People subscribed via source and target branches