Merge lp:~canonical-platform-qa/ubuntu-test-cases/server-preseed into lp:ubuntu-test-cases/server

[Max Brustkern]

This adds unmount active to the preseeds to work around recent install troubles.

[Jean-Baptiste Lallement (jibel)]

LGTM. Thanks!

review: Approve

[Scott Moser (smoser)]

Why would there be mounted partitions during an install?
Can you give a pointer to what was failing?
I'm just trying to understand what changed that caused this.

[Scott Moser (smoser)]

further searching shows likely that the bug is http://pad.lv/1533243 .
The fix here would indicate that the other google hit for 'unmount_active' is fixed (http://pad.lv/1355845). If that is so, can we mark that bug as fixed?

Also, any reason to not '--fixes lp:1533243' on this MP?

[Scott Moser (smoser)]

Well, if this actually *does* fix the problem, then I think it is fine to pull it until bug 1533243 is fixed. I'd like a 'FIXME: remove after bug 1533243 fixed' style comment in the preseeds.

And then also, if it does fix the problem, then we should close bug 1355845 as fix-released.

[Max Brustkern (nuclearbob)]

I think bug 1355845 is fixed now. I'm not sure about bug 1533243. The same preseed worked a few months ago, and has been working for years. If someone wants to say, "yes, this is how it works now," then I think we can mark bug 1533243 as won't fix, and use the new preseed as the solution to the problem. Either way, I don't think updating the test preseeds actually fixes 1533243, it just fixes a utah bug I hadn't filed yet because we're still working through a couple other preseed problems there.

[lp:~canonical-platform-qa/ubuntu-test-cases/server-preseed]

104. By Max Brustkern on 2016-01-19

Added workaround note

[Scott Moser (smoser)]

review: Approve

[Scott Moser (smoser)]

So... My belief at this point is that in fact partman/unmount_active either
a.) is not preseedable
b.) does not do what we thought it did

My current understanding is that the tests were failing after installation was done and when d-i was trying to unmount filesystems. Because of a backgrounded task spawned by 'apt-get update'(described in bug 1527710) that unmount would fail.

The changes here actually did not do anything, and evidence shows that.
We continued to see the same errors after this change was merged.

[Max Brustkern (nuclearbob)]

Yeah, I'm seeing the same problem on some images but not others, so my best guess is some kind of race. I'm not sure how best to proceed on that. We no longer do apt changes in the late command, unlike desktop, so I'm not sure where this change needs to happen.

=== modified file 'preseeds/default.preseed'
--- preseeds/default.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/default.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/dns-server.preseed'
--- preseeds/dns-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/dns-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/lamp-reboot.preseed'
--- preseeds/lamp-reboot.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/lamp-reboot.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/lamp.preseed'
--- preseeds/lamp.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/lamp.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/lvm.preseed'
--- preseeds/lvm.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/lvm.preseed	2016-01-19 19:20:31 +0000
@@ -240,6 +240,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/mail-server.preseed'
--- preseeds/mail-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/mail-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/minimal-virtual.preseed'
--- preseeds/minimal-virtual.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/minimal-virtual.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/multi-lvm.preseed'
--- preseeds/multi-lvm.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/multi-lvm.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/openssh-server.preseed'
--- preseeds/openssh-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/openssh-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/postgresql-server.preseed'
--- preseeds/postgresql-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/postgresql-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/print-server.preseed'
--- preseeds/print-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/print-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/raid1.preseed'
--- preseeds/raid1.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/raid1.preseed	2016-01-19 19:20:31 +0000
@@ -282,6 +282,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/samba-server.preseed'
--- preseeds/samba-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/samba-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/templates/base'
--- preseeds/templates/base	2012-11-23 11:22:06 +0000
+++ preseeds/templates/base	2016-01-19 19:20:31 +0000
@@ -221,6 +221,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 {% block tasksel_first %}

=== modified file 'preseeds/tomcat-server.preseed'
--- preseeds/tomcat-server.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/tomcat-server.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection
 
 

=== modified file 'preseeds/virtual-host.preseed'
--- preseeds/virtual-host.preseed	2012-11-23 11:22:06 +0000
+++ preseeds/virtual-host.preseed	2016-01-19 19:20:31 +0000
@@ -241,6 +241,10 @@
 # Wait for two seconds in grub
 d-i	grub-installer/timeout	string 2
 
+# Unmount active partitions if needed
+# Workaround until lp#1533243 is fixed
+d-i partman/unmount_active boolean true
+
 ### Package selection