Merge lp:~canonical-platform-qa/ubuntu-system-tests/test_receive_sms into lp:ubuntu-system-tests
| Status: | Merged |
|---|---|
| Approved by: | Richard Huddie on 2015-06-04 |
| Approved revision: | 116 |
| Merged at revision: | 121 |
| Proposed branch: | lp:~canonical-platform-qa/ubuntu-system-tests/test_receive_sms |
| Merge into: | lp:ubuntu-system-tests |
| Prerequisite: | lp:~canonical-platform-qa/ubuntu-system-tests/crendentials |
| Diff against target: |
573 lines (+500/-0) 8 files modified
README.rst (+7/-0) debian/tests/control (+2/-0) ubuntu_system_tests/config.py (+14/-0) ubuntu_system_tests/helpers/addressbook/dbus_service.py (+84/-0) ubuntu_system_tests/helpers/telephony.py (+197/-0) ubuntu_system_tests/helpers/unity8/notifications.py (+41/-0) ubuntu_system_tests/tests/base.py (+26/-0) ubuntu_system_tests/tests/test_messaging.py (+129/-0) |
| To merge this branch: | bzr merge lp:~canonical-platform-qa/ubuntu-system-tests/test_receive_sms |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2015-06-04 | |
| Richard Huddie (community) | 2015-05-29 | Approve on 2015-06-04 | |
| Brendan Donegan (community) | Approve on 2015-06-03 | ||
| Sergio Cazzolato | Approve on 2015-06-03 | ||
|
Review via email:
|
|||
Commit Message
Test and framework for receiving an SMS
Description of the Change
Add the sanity test for receiving an SMS and the supporting helpers
Note that the phone number cannot be queried from the SIM in all circumstances so we have to have it as a config option.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:99
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 100. By Brendan Donegan on 2015-05-29
-
Notifications helpers
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:100
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 101. By Brendan Donegan on 2015-05-29
-
Remove TODO comment
- 102. By Brendan Donegan on 2015-05-29
-
Update to/from_number config help text
- 103. By Brendan Donegan on 2015-05-29
-
Update README with info on getting telephony service access
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:101
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:103
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Richard Huddie (rhuddie) wrote : | # |
This is looking good. I managed to get it working after a few problems (see comments below).
Also, some flake8 errors:
./ubuntu_
./ubuntu_
./ubuntu_
./ubuntu_
./ubuntu_
./ubuntu_
./ubuntu_
./ubuntu_
./ubuntu_
- 104. By Brendan Donegan on 2015-05-29
-
Fix flake8 issues in telephony helpers
- 105. By Brendan Donegan on 2015-05-29
-
Rename to_number to device_phone_number and from_number to telephony_
service_ number
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:105
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 106. By Brendan Donegan on 2015-05-29
-
Remove stray print statement
- 107. By Brendan Donegan on 2015-05-29
-
Added last bits of test and addressed last comments
| Brendan Donegan (brendan-donegan) wrote : | # |
Made a lot of updates, let's see what the Jenkins job comes back with.
| Brendan Donegan (brendan-donegan) wrote : | # |
Response to diff comments
| Brendan Donegan (brendan-donegan) wrote : | # |
Btw there is some new code at the end of the test to pay attention to, particularly to delete the message - maybe that should be done in a different way, not using the UI?
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:107
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
2 comments inline
- 108. By Brendan Donegan on 2015-05-30
-
Comment up the test code
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:108
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Brendan Donegan (brendan-donegan) wrote : | # |
Spoke to renato - since the dbus API is essentially private it could potentially change and break at any time - however the only public and supported way is using the C++ API. Writing bindings is laborious and fraught with danger, so I'd prefer to stick with using the DBus API. I would point out that this code was initially written nearly a year ago and still works as is so it's not as unstable as it might sound initially.
- 109. By Brendan Donegan on 2015-06-03
-
Merged from trunk
- 110. By Brendan Donegan on 2015-06-03
-
Fix flake8 issue
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:110
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Brendan Donegan (brendan-donegan) wrote : | # |
Tested again to make sure it works, and it does. If no further objections, we can top-approve?
| Richard Huddie (rhuddie) wrote : | # |
This looks really good, I ran the test fine.
Just 1 comment below about skipping the test if no sim inserted.
- 111. By Brendan Donegan on 2015-06-04
-
Skip test_receive_sms if no SIM is inserted
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:111
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 112. By Brendan Donegan on 2015-06-04
-
Merged from trunk
| Brendan Donegan (brendan-donegan) wrote : | # |
Skip added, tested both with and without SIM inserted, all works properly. Just wait for the Jenkins job to return clean and we can top-approve I guess
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:112
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 113. By Brendan Donegan on 2015-06-04
-
Revert removal of restart_unity
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:113
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 114. By Brendan Donegan on 2015-06-04
-
Remove _ensure_
application_ closed from test_messaging.py
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:114
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 115. By Brendan Donegan on 2015-06-04
-
typo in ensure_
application_ closed
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:115
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 116. By Richard Huddie on 2015-06-04
-
Temporarily remove use of tap_on notification method to improve reliability.
| Richard Huddie (rhuddie) wrote : | # |
Re-tested on mako with the notification change to improve reliability. Works fine.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:116
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:99 /code.launchpad .net/~canonical -platform- qa/ubuntu- system- tests/test_ receive_ sms/+merge/ 260545/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// s-jenkins. ubuntu- ci:8080/ job/ubuntu- sanity- tests-ci/ 263/ s-jenkins. ubuntu- ci:8080/ job/ubuntu- sanity- tests-wily- amd64-ci/ 34/console s-jenkins. ubuntu- ci:8080/ job/ubuntu- sanity- tests-wily- armhf-ci/ 34/console s-jenkins. ubuntu- ci:8080/ job/ubuntu- sanity- tests-wily- i386-ci/ 34/console
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- sanity- tests-ci/ 263/rebuild
http://