Merge lp:~canonical-platform-qa/ubuntu-system-tests/stability-longer-preview-timeout into lp:ubuntu-system-tests

[Richard Huddie]

Fix to extend the timeout period used to open an application preview.

Fix to extend the timeout period used to open an application preview. Fixes failures in sanity test ubuntu_system_tests.tests.test_uninstall_application.UninstallApplicationTestCase.test_uninstall_application: https://prod.practitest.com/p/1548/qtest_runs/2646196/edit

[Brendan Donegan (brendan-donegan)]

Playing devils advocate here but if you look at the history of the test (Tracability tab) it's only failed on vivid like this once (it fails on Wily for other reasons). The disadvantage of copying the open_preview helper is that it leaves us open to any changes that happen in unity8 breaking our version. I would keep this branch around and see if the failure starts happening more but wouldn't merge it just now.

review: Needs Information

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:220
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-ci/900/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-amd64-ci/628
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-armhf-ci/629
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-i386-ci/628

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-ci/900/rebuild

review: Approve (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:220
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/8/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/30/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/31/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/35/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/8/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:220
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1142/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1922/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1142/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

220. By Richard Huddie on 2015-09-30

Extend timeout peroid used in opening preview.

=== modified file 'ubuntu_system_tests/helpers/unity8/dash.py'
--- ubuntu_system_tests/helpers/unity8/dash.py	2015-09-25 22:09:29 +0000
+++ ubuntu_system_tests/helpers/unity8/dash.py	2015-10-01 08:20:18 +0000
@@ -18,11 +18,13 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 
+import logging
 import ubuntuuitoolkit
 
 from retrying import retry
 
 from autopilot import introspection
+from autopilot import logging as autopilot_logging
 from autopilot.input._common import get_center_point
 
 from ubuntu_system_tests.helpers.autopilot import order_by_x_coord
@@ -30,6 +32,8 @@
 from unity8 import process_helpers
 from unity8.shell.emulators import dash as unity8_dash
 
+logger = logging.getLogger(__name__)
+
 
 def get_dash():
     """Return the Unity8 Dash autopilot custom proxy object."""
@@ -43,11 +47,11 @@
 
 class Dash(unity8_dash.Dash):
 
-    def wait_for_processing_to_complete(self):
+    def wait_for_processing_to_complete(self, timeout=90):
         """Wait until the dash is fully loaded"""
         self.select_single(
             objectName='processingIndicator').visible.wait_for(False,
-                                                               timeout=90)
+                                                               timeout=timeout)
 
     def open_scope(self, scope):
         """Open the scope once the dash is ready to start the scroll
@@ -189,3 +193,25 @@
         x, y, width, height = icon.globalRect
         self.pointing_device.move(x + 1, y + 1)
         self.pointing_device.click(press_duration=press_duration)
+
+    @autopilot_logging.log_action(logger.info)
+    def open_preview(self, category, app_name, press_duration=0.10):
+        """Open the preview of an application.
+
+        This over-rides the implementation in unity8 because the timeout
+        for waiting for processing indicator to complete is not sufficient.
+
+        :parameter category: The name of the category where the application is.
+        :parameter app_name: The name of the application.
+        :return: The opened preview.
+
+        """
+        self.click_scope_item(category, app_name, press_duration)
+        preview_list = self.wait_select_single(
+            'QQuickLoader', objectName='subPageLoader')
+        preview_list.subPageShown.wait_for(True)
+        preview_list.x.wait_for(0)
+        get_dash().wait_for_processing_to_complete()
+        return preview_list.select_single(
+            unity8_dash.Preview, objectName='preview{}'.format(
+                preview_list.initialIndex))