Merge lp:~canonical-platform-qa/ubuntu-system-tests/add-setup-silent-option into lp:ubuntu-system-tests

Proposed by Richard Huddie
Status: Merged
Approved by: Max Brustkern
Approved revision: 412
Merged at revision: 411
Proposed branch: lp:~canonical-platform-qa/ubuntu-system-tests/add-setup-silent-option
Merge into: lp:ubuntu-system-tests
Diff against target: 118 lines (+14/-3)
3 files modified
ubuntu_system_tests/host/command_line.py (+1/-1)
ubuntu_system_tests/selftests/test_command_line.py (+11/-0)
ubuntu_system_tests/selftests/utils.py (+2/-2)
To merge this branch: bzr merge lp:~canonical-platform-qa/ubuntu-system-tests/add-setup-silent-option
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Approve
Max Brustkern (community) Approve
Review via email: mp+298812@code.launchpad.net

Commit message

Add silent option to setup command.

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

LGTM, but I suppose we should see what the bot doesn't like.

review: Approve
412. By Richard Huddie

Fix selftests.

Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_system_tests/host/command_line.py'
2--- ubuntu_system_tests/host/command_line.py 2016-06-29 08:05:47 +0000
3+++ ubuntu_system_tests/host/command_line.py 2016-06-30 18:29:08 +0000
4@@ -103,9 +103,9 @@
5 OPTION_CONFIG,
6 OPTION_CONFIG_SECTION,
7 OPTION_NETWORK_READY,
8+ OPTION_SILENT,
9 OPTION_VERBOSE]
10 RUN_ARGS = [
11- OPTION_SILENT,
12 OPTION_SUITES,
13 OPTION_TOUCH_VISUALIZATION]
14 SETUP_ARGS = [
15
16=== modified file 'ubuntu_system_tests/selftests/test_command_line.py'
17--- ubuntu_system_tests/selftests/test_command_line.py 2016-06-24 13:33:28 +0000
18+++ ubuntu_system_tests/selftests/test_command_line.py 2016-06-30 18:29:08 +0000
19@@ -98,6 +98,8 @@
20 DONT_INSTALL_TESTS = False
21 DO_USE_CACHE_DEPS = True
22 DONT_USE_CACHE_DEPS = False
23+ DO_USE_SILENT_MODE = True
24+ DONT_USE_SILENT_MODE = False
25 DO_USE_VERBOSE_LOGGING = True
26 DONT_USE_VERBOSE_LOGGING = False
27
28@@ -114,6 +116,7 @@
29 DO_DIST_UPGRADE,
30 DONT_INSTALL_TESTS,
31 DO_APT_UPDATE,
32+ DONT_USE_SILENT_MODE,
33 )
34 }),
35 ('alternative config', {
36@@ -128,6 +131,7 @@
37 DO_DIST_UPGRADE,
38 DONT_INSTALL_TESTS,
39 DO_APT_UPDATE,
40+ DONT_USE_SILENT_MODE,
41 )
42 }),
43 ('alternative config section', {
44@@ -142,6 +146,7 @@
45 DO_DIST_UPGRADE,
46 DONT_INSTALL_TESTS,
47 DO_APT_UPDATE,
48+ DONT_USE_SILENT_MODE,
49 )
50 }),
51 ('only apt-get update', {
52@@ -156,6 +161,7 @@
53 DONT_DIST_UPGRADE,
54 DONT_INSTALL_TESTS,
55 DO_APT_UPDATE,
56+ DONT_USE_SILENT_MODE,
57 )
58 }),
59 ('with network already setup', {
60@@ -170,6 +176,7 @@
61 DO_DIST_UPGRADE,
62 DONT_INSTALL_TESTS,
63 DO_APT_UPDATE,
64+ DONT_USE_SILENT_MODE,
65 )
66 }),
67 ('with dist-upgrade enabled', {
68@@ -184,6 +191,7 @@
69 DO_DIST_UPGRADE,
70 DONT_INSTALL_TESTS,
71 DO_APT_UPDATE,
72+ DONT_USE_SILENT_MODE,
73 )
74 }),
75 ('with install dependencies enabled', {
76@@ -198,6 +206,7 @@
77 DONT_DIST_UPGRADE,
78 DO_INSTALL_TESTS,
79 DO_APT_UPDATE,
80+ DONT_USE_SILENT_MODE,
81 )
82 }),
83 ('with cache deps specified', {
84@@ -212,6 +221,7 @@
85 DONT_DIST_UPGRADE,
86 DONT_INSTALL_TESTS,
87 DO_APT_UPDATE,
88+ DONT_USE_SILENT_MODE,
89 )
90 }),
91 ('with verbose logging specified', {
92@@ -226,6 +236,7 @@
93 DO_DIST_UPGRADE,
94 DONT_INSTALL_TESTS,
95 DO_APT_UPDATE,
96+ DONT_USE_SILENT_MODE,
97 )
98 }),
99 ]
100
101=== modified file 'ubuntu_system_tests/selftests/utils.py'
102--- ubuntu_system_tests/selftests/utils.py 2016-06-23 15:30:13 +0000
103+++ ubuntu_system_tests/selftests/utils.py 2016-06-30 18:29:08 +0000
104@@ -75,12 +75,12 @@
105 command='setup', config=config.DEFAULT_CONF,
106 config_section=config.KEY_DEFAULT, network_ready=False, verbose=False,
107 cache_deps=False, dist_upgrade=False, install_tests=False,
108- update_apt=False):
109+ update_apt=False, silent=False):
110 return Namespace(
111 command=command, config=config, config_section=config_section,
112 network_ready=network_ready, verbose=verbose, cache_deps=cache_deps,
113 dist_upgrade=dist_upgrade, install_tests=install_tests,
114- update_apt=update_apt)
115+ update_apt=update_apt, silent=silent)
116
117
118 def set_uniq_cwd(test, prefix=None):

Subscribers

People subscribed via source and target branches

to all changes: