Merge into trunk : cchange_ringtone_tests : Code : ubuntu-system-settings

Status:	Work in progress
Proposed branch:	lp:~canonical-platform-qa/ubuntu-system-settings/cchange_ringtone_tests
Merge into:	lp:ubuntu-system-settings
Diff against target:	373 lines (+215/-23) 8 files modified plugins/sound/PageComponent.qml (+1/-0) plugins/sound/SoundsList.qml (+4/-0) src/main.cpp (+2/-1) tests/autopilot/ubuntu_system_settings/__init__.py (+84/-10) tests/autopilot/ubuntu_system_settings/fixture_setup.py (+38/-0) tests/autopilot/ubuntu_system_settings/helpers.py (+39/-0) tests/autopilot/ubuntu_system_settings/tests/__init__.py (+8/-8) tests/autopilot/ubuntu_system_settings/tests/test_sound.py (+39/-4)
To merge this branch:	bzr merge lp:~canonical-platform-qa/ubuntu-system-settings/cchange_ringtone_tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration	2014-07-30	Needs Fixing on 2014-07-31
Sebastien Bacher		2014-07-30	Pending
Leo Arias		2014-07-30	Pending
Review via email: mp+228884@code.launchpad.net

Revision history for this message

Leo Arias (elopio) wrote on 2014-05-23: Posted in a previous version of this proposal

#

Just please rename this:

+ def ringtone_setting_button_current_value(self):

to:

get_current_value

Nice work, thanks!

review: Approve (code review)

Revision history for this message

Christopher Lee (veebers) wrote on 2014-05-23: Posted in a previous version of this proposal

#

Hi Omer, I'm just being very nosey. Is the sleep on diff line 130 required? Esp. if you're doing a wait_for just after that.

Looks nice and clean :-)

Revision history for this message

Omer Akram (om26er) wrote on 2014-05-23: Posted in a previous version of this proposal

#

> Hi Omer, I'm just being very nosey. Is the sleep on diff line 130 required?
> Esp. if you're doing a wait_for just after that.
>
> Looks nice and clean :-)

Thanks for the comment.

That sleep is required. When you open the ringtone settings page, initially the page is not moving but if the current selected ringtone is at the bottom of the list and not visible on screen, it automatically scrolls down. So we try to workaround that.

Ideally it would always show the selected ringtone at the center whenever the list is opened but currently its not doing that.

Revision history for this message

Omer Akram (om26er) wrote on 2014-05-23: Posted in a previous version of this proposal

#

> Just please rename this:
>
> + def ringtone_setting_button_current_value(self):
>
> to:
>
> get_current_value
>
> Nice work, thanks!

Done!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-23: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/835/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-23: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/836/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-23: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/837/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-26: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/838/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-06-03: Posted in a previous version of this proposal

#

Thank you for your work, the approach seems fine, CI is unhappy it seems though, could you have a look to that?

review: Needs Fixing

Revision history for this message

Omer Akram (om26er) wrote on 2014-06-04: Posted in a previous version of this proposal

#

Not ready, just changed status for CI.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-04: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/855/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-05: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/860/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-05: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/861/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-06: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/863/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-06: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/865/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-23: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:723
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/886/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1090/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/978/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/78/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/78/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/78/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1910/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1121/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/886/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-23: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/887/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-30: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/907/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-07-15: Posted in a previous version of this proposal

#

Should that be marked "work in progress"? The CI seems still unhappy there...

Note that https://code.launchpad.net/~elopio/ubuntu-system-settings/refactor_about_tests/+merge/226468 is about the land and that your changes are going to need to be rebased, since there is a conflict when applying those on top of trunk

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-15: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/996/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-16: Posted in a previous version of this proposal

#

I've been able to make it work fixing some things.

First, one second is not enough. And then, it's safest if you also wait for the dragging property.

Instead of:
186 + sleep(1)
187 + list_view.moving.wait_for(False)

sleep(3)
list_view.dragging.wait_for(False)
list_view.moving.wait_for(False)

Then, you will need this branch to land on the toolkit:
https://code.launchpad.net/~canonical-platform-qa/ubuntu-ui-toolkit/fix1342521-find_element_on_top/+merge/226961

Please review it.

Now, it's really important to notice that the need for a sleep is a typical case of a UX bug. For some seconds, the page does nothing. Enough time for the user to start an action. And when the user is just about to click an element on the list or swipe it, the list is swiped by itself making the user click the wrong thing, or just wondering what caused the magic swipe.

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-16: Posted in a previous version of this proposal

#

I reported that bug here: https://bugs.launchpad.net/ubuntu-ux/+bug/1342533
Please add a comment on the sleep with a reference to that bug.

review: Needs Fixing

Revision history for this message

Omer Akram (om26er) wrote on 2014-07-25: Posted in a previous version of this proposal

#

Hi Leo,

I incorporated your suggestions into my code. Also your branch improves the situation and my code does not fail now.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-25: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:837
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/ubuntu-system-settings/change_ringtone_test/+merge/228228/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1058/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-25: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:838
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/ubuntu-system-settings/change_ringtone_test/+merge/228228/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1060/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-25: Posted in a previous version of this proposal

#

Omer, you still haven't reviewed the branch that you need. Without a QA revision it's going to be harder to get it merged soon.
This branch is blocked by mine, so setting back as work in progress.

Revision history for this message

Omer Akram (om26er) wrote on 2014-07-25: Posted in a previous version of this proposal

#

I had reviewed, just didn't change the status. Did that now

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-28: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1073/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-30: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1079/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-07-30: Posted in a previous version of this proposal

#

the CI seems unhappy, can you have a look at that?

review: Needs Fixing

Revision history for this message

Omer Akram (om26er) wrote on 2014-07-30: Posted in a previous version of this proposal

#

Sorry for that, tests were passing on my phone so I thought its ready. Will make sure this time its fixed fully before changing to 'Needs fixing'.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-31:

#

FAILED: Continuous integration, rev:844
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/ubuntu-system-settings/cchange_ringtone_tests/+merge/228884/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1105/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

Omer Akram (om26er) wrote on 2014-07-31:

#

This is crazy, my test fails while trying to get SystemBus, it works on my phone, not really sure what's difference is there in the phone in the lab. Help ?

testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/ubuntu_system_settings/tests/test_sound.py", line 47, in setUp
    self.useFixture(fixture_setup.RingtoneBackup())
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 628, in useFixture
    fixture.setUp()
  File "/usr/lib/python3/dist-packages/ubuntu_system_settings/fixture_setup.py", line 28, in setUp
    self._backup_ringtone()
  File "/usr/lib/python3/dist-packages/ubuntu_system_settings/fixture_setup.py", line 31, in _backup_ringtone
    self.ringtone_backup = helpers.get_current_ringtone_from_backend()
  File "/usr/lib/python3/dist-packages/ubuntu_system_settings/helpers.py", line 35, in get_current_ringtone_from_backend
    accounts_iface = get_accounts_service_iface()
  File "/usr/lib/python3/dist-packages/ubuntu_system_settings/helpers.py", line 25, in get_accounts_service_iface
    bus = dbus.SystemBus()
  File "/usr/lib/python3/dist-packages/dbus/_dbus.py", line 194, in __new__
    private=private)
  File "/usr/lib/python3/dist-packages/dbus/_dbus.py", line 100, in __new__
    bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
  File "/usr/lib/python3/dist-packages/dbus/bus.py", line 122, in __new__
    bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoServer: Failed to connect to socket /tmp/dbus-k5zfELDGub: Connection refused

Reply

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-31:

#

I asked you about precisely this related to my previous system settings branches and you told me that they were intermittent issues on Jenkins. That they disappeared so you didn't dig into them.
I kept running my branches until I got a successful run.

Reply

Revision history for this message

Omer Akram (om26er) wrote on 2014-07-31:

#

You see, there is a difference, the problem we discussed was happening in otto setup and I had different errors in mind at that time. But now the issue is with mako which I never saw before and was not happening when we discussed a few weeks ago.

Reply

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-31:

#

Well, it was happening to me:
https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2232/testReport/junit/ubuntu_system_settings.tests.test_about/AboutTestCase/test_device_with_imei_must_display_it/

I dug a little and found there was a crash.
Here's your crash file: https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2874/artifact/clientlogs/ubuntu_system_settings/_usr_sbin_system-image-dbus.32011.crash

Reply

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-08-12:

#

setting to "work in progress" to get out of the review queue until the CI issues are sorted out

Reply

ubuntu-system-settings

Merge lp:~canonical-platform-qa/ubuntu-system-settings/cchange_ringtone_tests into lp:ubuntu-system-settings

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers

 === modified file 'plugins/sound/PageComponent.qml'
 --- plugins/sound/PageComponent.qml	2014-07-25 14:19:30 +0000
 +++ plugins/sound/PageComponent.qml	2014-07-30 15:30:26 +0000
@@ -112,6 +112,7 @@
+             }
              ListItem.SingleValue {
++                objectName: 'ringtoneListItem'
                  text: i18n.tr("Ringtone")
                  value: Utilities.buildDisplayName(
                             backendInfo.incomingCallSound)
 === modified file 'plugins/sound/SoundsList.qml'
 --- plugins/sound/SoundsList.qml	2014-07-16 16:20:23 +0000
 +++ plugins/sound/SoundsList.qml	2014-07-30 15:30:26 +0000
@@ -84,6 +84,10 @@
                          Utilities.indexSelectedFile(soundFileNames,
                              backendInfo.incomingMessageSound)
+         }
++        delegate: OptionSelectorDelegate {
++            objectName: "ringtone-" + modelData
++            text: modelData
++        }
          onDelegateClicked: {
              if (soundType == 0) {
                  soundSettings.incomingCallSound = soundFileNames[index]
 === modified file 'src/main.cpp'
 --- src/main.cpp	2014-02-18 11:53:03 +0000
 +++ src/main.cpp	2014-07-30 15:30:26 +0000
@@ -41,7 +41,8 @@
       * add some unneeded overhead => Let's load the testability driver on our
       * own.
       */
--    if (app.arguments().contains(QStringLiteral("-testability"))) {
++    if (app.arguments().contains(QStringLiteral("-testability")) ||
++        qgetenv("QT_LOAD_TESTABILITY") == "1") {
          QLibrary testLib(QStringLiteral("qttestability"));
          if (testLib.load()) {
              typedef void (*TasInitialize)(void);
 === modified file 'tests/autopilot/ubuntu_system_settings/__init__.py'
 --- tests/autopilot/ubuntu_system_settings/__init__.py	2014-07-22 18:29:46 +0000
 +++ tests/autopilot/ubuntu_system_settings/__init__.py	2014-07-30 15:30:26 +0000
@@ -35,49 +35,70 @@
      """Helper class for System Settings application"""
      APP_PATH = '/usr/bin/system-settings'
++    APP_UPSTART_ID = 'ubuntu-system-settings'
      DESKTOP_FILE = '/usr/share/applications/ubuntu-system-settings.desktop'
--    def __init__(self, testobj, panel=None):
++    def __init__(self, testobj, panel=None, upstart_launch=False):
          """Constructor. Launches system settings application
          :param testobj: An AutopilotTestCase object, needed to call
          testobj.launch_test_application()
          :param panel: Launch to a specific panel. Default None.
++        :param upstart_launch: whether to launch settings with upstart.
          """
          self.testobj = testobj
          self.panel = panel
++        self.upstart_launch = upstart_launch
          # Launches application
          self.app = self.launch(
              self.testobj,
              self.APP_PATH,
              self.DESKTOP_FILE,
--            panel=self.panel)
++            panel=self.panel,
++            upstart_launch=self.upstart_launch)
--    def launch(self, testobj, app_path, desktop_file, panel=None):
++    def launch(
++            self,
++            testobj,
++            app_path,
++            desktop_file,
++            panel=None,
++            upstart_launch=False):
          """Launch system settings application
          :param testobj: An AutopilotTestCase object, needed to call
          testobj.launch_test_application()
          :param panel: Launch to a specific panel. Default None.
++        :param upstart_launch: whether to launch settings with upstart.
          :returns: A proxy object that represents the application. Introspection
          data is retrievable via this object.
          """
--        params = [app_path]
--        if platform.model() != 'Desktop':
++        if upstart_launch:
++            params = [self.APP_UPSTART_ID]
++        elif platform.model() is 'Desktop':
++            params = [app_path]
++        else:
++            params = [app_path]
              params.append('--desktop_file_hint={}'.format(desktop_file))
          # Launch to a specific panel
          if panel is not None:
              params.append(panel)
--        app = testobj.launch_test_application(
--            *params,
--            app_type='qt',
--            emulator_base=ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase,
--            capture_output=True)
++        toolkit_base = ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase
++        if upstart_launch:
++            app = testobj.launch_upstart_application(
++                *params,
++                emulator_base=toolkit_base)
++        else:
++            app = testobj.launch_test_application(
++                *params,
++                app_type='qt',
++                emulator_base=toolkit_base,
++                capture_output=True)
          return app
@@ -183,6 +204,59 @@
                  return True
          return False
++    def _get_ringtone_setting_button(self):
++        return self.wait_select_single(
++            'SingleValue', objectName='ringtoneListItem')
++
++    def get_ringtone_setting_button_current_value(self):
++        """current value of the ringtone setting button.
++
++        :return: name of the currently selected ringtone.
++
++        """
++        return self._get_ringtone_setting_button().value
++
++    @autopilot.logging.log_action(logger.info)
++    def open_ringtone_selector(self):
++        """Open the ringtone selector.
++
++        :return: The page with ringtones list.
++
++        """
++        ringtone_setting_button = self._get_ringtone_setting_button()
++        self.pointing_device.click_object(ringtone_setting_button)
++
++        root = self.get_root_instance()
++        return root.wait_select_single(SoundsList)
++
++
++class SoundsList(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
++
++    def choose_ringtone(self, name):
++        """Choose a new ringtone.
++
++        :param name: name of the ringtone to select.
++        :return: newly selected ringtone item.
++
++        """
++        list_view = self.select_single('QQuickListView', objectName='listView')
++        # When last item of a long list is preselected the list scrolls
++        # down automatically, wait for the list to scroll down before
++        # trying to do anything. -- om26er.
++        sleep(3)
++        list_view.dragging.wait_for(False)
++        list_view.moving.wait_for(False)
++        list_view.click_element('ringtone-' + name)
++
++        return self.select_single(
++            'OptionSelectorDelegate', objectName='ringtone-' + name)
++
++    @autopilot.logging.log_action(logger.info)
++    def go_back_to_sound_page(self):
++        """Go back to the sound settings main page."""
++        main_window = self.get_root_instance().select_single(MainWindow)
++        main_window.go_back()
++
  class AboutPage(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
 === added file 'tests/autopilot/ubuntu_system_settings/fixture_setup.py'
 --- tests/autopilot/ubuntu_system_settings/fixture_setup.py	1970-01-01 00:00:00 +0000
 +++ tests/autopilot/ubuntu_system_settings/fixture_setup.py	2014-07-30 15:30:26 +0000
@@ -0,0 +1,38 @@
++# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
++#
++# Copyright (C) 2014 Canonical Ltd.
++#
++# This program is free software; you can redistribute it and/or modify
++# it under the terms of the GNU Lesser General Public License as published by
++# the Free Software Foundation; version 3.
++#
++# This program is distributed in the hope that it will be useful,
++# but WITHOUT ANY WARRANTY; without even the implied warranty of
++# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
++# GNU Lesser General Public License for more details.
++#
++# You should have received a copy of the GNU Lesser General Public License
++# along with this program. If not, see <http://www.gnu.org/licenses/>.
++
++import fixtures
++
++from ubuntu_system_settings import helpers
++
++
++class RingtoneBackup(fixtures.Fixture):
++    """Fixture to backup and restore ringtone."""
++
++    def setUp(self):
++        super(RingtoneBackup, self).setUp()
++        self.addCleanup(self._restore_ringtone)
++        self._backup_ringtone()
++
++    def _backup_ringtone(self):
++        self.ringtone_backup = helpers.get_current_ringtone_from_backend()
++
++    def _restore_ringtone(self):
++        iface = helpers.get_accounts_service_iface()
++        iface.Set(
++            'com.ubuntu.touch.AccountsService.Sound',
++            'IncomingCallSound',
++            self.ringtone_backup)
 === added file 'tests/autopilot/ubuntu_system_settings/helpers.py'
 --- tests/autopilot/ubuntu_system_settings/helpers.py	1970-01-01 00:00:00 +0000
 +++ tests/autopilot/ubuntu_system_settings/helpers.py	2014-07-30 15:30:26 +0000
@@ -0,0 +1,39 @@
++# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
++#
++# Copyright (C) 2014 Canonical Ltd.
++#
++# This program is free software; you can redistribute it and/or modify
++# it under the terms of the GNU Lesser General Public License as published by
++# the Free Software Foundation; version 3.
++#
++# This program is distributed in the hope that it will be useful,
++# but WITHOUT ANY WARRANTY; without even the implied warranty of
++# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
++# GNU Lesser General Public License for more details.
++#
++# You should have received a copy of the GNU Lesser General Public License
++# along with this program. If not, see <http://www.gnu.org/licenses/>.
++
++import os
++
++import dbus
++
++
++def get_accounts_service_iface():
++    """Return the accountsservice dbus interface."""
++    uid = os.geteuid()
++    bus = dbus.SystemBus()
++    proxy = bus.get_object(
++        'org.freedesktop.Accounts',
++        '/org/freedesktop/Accounts/User{}'.format(uid))
++
++    return dbus.Interface(proxy, 'org.freedesktop.DBus.Properties')
++
++
++def get_current_ringtone_from_backend():
++    """Return the URI of the current ringtone."""
++    accounts_iface = get_accounts_service_iface()
++
++    return accounts_iface.Get(
++        'com.ubuntu.touch.AccountsService.Sound',
++        'IncomingCallSound')
 === modified file 'tests/autopilot/ubuntu_system_settings/tests/__init__.py'
 --- tests/autopilot/ubuntu_system_settings/tests/__init__.py	2014-07-25 18:12:58 +0000
 +++ tests/autopilot/ubuntu_system_settings/tests/__init__.py	2014-07-30 15:30:26 +0000
@@ -39,9 +39,10 @@
      """Base class for Ubuntu System Settings."""
--    def setUp(self, panel=None):
++    def setUp(self, panel=None, upstart_launch=False):
          super(UbuntuSystemSettingsTestCase, self).setUp()
--        self.system_settings = SystemSettings(self, panel=panel)
++        self.system_settings = SystemSettings(
++            self, panel=panel, upstart_launch=upstart_launch)
          self.assertThat(
              self.system_settings.main_view.visible,
              Eventually(Equals(True)))
@@ -467,9 +468,8 @@
  class SoundBaseTestCase(UbuntuSystemSettingsTestCase):
      """ Base class for sound settings tests"""
--    def setUp(self):
--
--        """ Go to Sound page """
--        super(SoundBaseTestCase, self).setUp('sound')
--        self.assertThat(self.system_settings.main_view.sound_page.active,
--                        Eventually(Equals(True)))
++    def setUp(self, panel='sound', upstart_launch=False):
++        """Go to Sound page."""
++        super(SoundBaseTestCase, self).setUp(panel, upstart_launch)
++        self.sound_page = self.system_settings.main_view.select_single(
++            objectName='soundPage')
 === modified file 'tests/autopilot/ubuntu_system_settings/tests/test_sound.py'
 --- tests/autopilot/ubuntu_system_settings/tests/test_sound.py	2014-07-11 14:17:51 +0000
 +++ tests/autopilot/ubuntu_system_settings/tests/test_sound.py	2014-07-30 15:30:26 +0000
@@ -5,8 +5,13 @@
  # under the terms of the GNU General Public License version 3, as published
  # by the Free Software Foundation.
++from autopilot import platform
++from autopilot.matchers import Eventually
++from testtools import skipIf
  from testtools.matchers import Equals, NotEquals
++from ubuntu_system_settings import fixture_setup
++from ubuntu_system_settings import helpers
  from ubuntu_system_settings.tests import SoundBaseTestCase
  from ubuntu_system_settings.utils.i18n import ugettext as _
@@ -18,12 +23,10 @@
          """ Checks whether Sound page is available """
          self.assertThat(
              self.system_settings.main_view.sound_page,
--            NotEquals(None)
--        )
++            NotEquals(None))
          self.assertThat(
              self.system_settings.main_view.sound_page.title,
--            Equals(_('Sound'))
--        )
++            Equals(_('Sound')))
      def test_keyboard_sound_switch(self):
          """ Check that keyboard sound is present and clickable"""
@@ -33,3 +36,35 @@
          self.system_settings.main_view.pointing_device.click_object(kbd_snd)
          self.assertThat(
              kbd_snd.get_properties()["checked"], NotEquals(current_value))
++
++
++@skipIf(platform.model() is 'Desktop', 'Phones only')
++class RingtoneSettingTestCase(SoundBaseTestCase):
++
++    ringtone = 'Supreme'
++
++    def setUp(self):
++        self.useFixture(fixture_setup.RingtoneBackup())
++        super(RingtoneSettingTestCase, self).setUp(upstart_launch=True)
++
++    def test_ringtone_setting_change_in_ui(self):
++        """Ensure ringtone change is shown in UI."""
++        sounds_list = self.sound_page.open_ringtone_selector()
++        sounds_list.choose_ringtone(self.ringtone)
++
++        sounds_list.go_back_to_sound_page()
++
++        self.assertThat(
++            self.sound_page.get_ringtone_setting_button_current_value(),
++            Eventually(Equals(self.ringtone)))
++
++    def test_ringtone_setting_change_in_backend(self):
++        """Ensure ringtone change saves in backend."""
++        sounds_list = self.sound_page.open_ringtone_selector()
++        current_ringtone = sounds_list.choose_ringtone(self.ringtone)
++
++        self.assertThat(
++            current_ringtone.selected, Eventually(Equals(True)))
++        self.assertThat(
++            lambda: helpers.get_current_ringtone_from_backend().endswith(
++                self.ringtone + '.ogg'), Eventually(Equals(True)))