Merge lp:~canonical-platform-qa/ubuntu-qa-tools/add-xenial-to-release-list into lp:ubuntu-qa-tools

Proposed by Max Brustkern
Status: Merged
Merged at revision: 1124
Proposed branch: lp:~canonical-platform-qa/ubuntu-qa-tools/add-xenial-to-release-list
Merge into: lp:ubuntu-qa-tools
Diff against target: 11 lines (+1/-1)
1 file modified
dl-ubuntu-test-iso/dl-ubuntu-test-iso (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/ubuntu-qa-tools/add-xenial-to-release-list
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+294840@code.launchpad.net

Commit message

Add xenial to default release list.

Description of the change

This branch adds xenial to the default release list since it is now on the list of LTS releases. Without this in place, the default options used to download a pending build of an lts cause dl-ubuntu-test-iso to exit with status 0 after taking no action. I can file a bug for that if needed.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good. An improvement to the script might be to have update_release() also check to see what releases are LTSes.

review: Approve
Revision history for this message
Max Brustkern (nuclearbob) wrote :

That's a good idea. I'll try to remember it before the next LTS :)

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Would you accept a patch that uses the distro_info module? Then instead of enumerating releases here, we can get all supported, lts, and dev from that.

Revision history for this message
Steve Beattie (sbeattie) wrote :

On Tue, May 17, 2016 at 07:42:06PM -0000, Max Brustkern wrote:
> Would you accept a patch that uses the distro_info module? Then instead of enumerating releases here, we can get all supported, lts, and dev from that.

Yeah, that'd be a nice improvement.

--
Steve Beattie
<email address hidden>
http://NxNW.org/~steve/

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dl-ubuntu-test-iso/dl-ubuntu-test-iso'
2--- dl-ubuntu-test-iso/dl-ubuntu-test-iso 2016-04-22 17:58:08 +0000
3+++ dl-ubuntu-test-iso/dl-ubuntu-test-iso 2016-05-16 19:35:48 +0000
4@@ -32,7 +32,7 @@
5 default['variants'] = ['desktop', 'alternate', 'dvd']
6 default['build'] = 'current'
7 default['host'] = 'cdimage.ubuntu.com'
8-default['releases'] = ['precise', 'trusty', current_release]
9+default['releases'] = ['precise', 'trusty', 'xenial', current_release]
10 default['isoroot'] = environ['HOME'] + '/iso/'
11 default['do_release_check'] = True
12