Merge lp:~canonical-platform-qa/snappy-ecosystem-tests/fix-trunk into lp:snappy-ecosystem-tests

[Omer Akram]

fix ssh setup

fix ssh setup

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:32
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/244/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/2050/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/244/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:33
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/245/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/2052/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/245/rebuild

review: Needs Fixing (continuous-integration)

[Santiago Baldassin (sbaldassin)]

Code looks good to me

review: Approve

[platform-qa-bot (platform-qa-bot)]

review: Approve (continuous-integration)

[lp:~canonical-platform-qa/snappy-ecosystem-tests/fix-trunk]

31. By Omer Akram on 2017-03-03

fix ssh setup.

Approved by platform-qa-bot, Santiago Baldassin.

=== modified file 'snappy_ecosystem_tests/environment/managers.py'
--- snappy_ecosystem_tests/environment/managers.py	2017-03-03 15:52:55 +0000
+++ snappy_ecosystem_tests/environment/managers.py	2017-03-03 18:11:20 +0000
@@ -112,13 +112,11 @@
             os.path.expanduser('~') + '/.ssh/id_rsa.pub').read().strip('\n')
         container.files.put('/home/ubuntu/.ssh/authorized_keys', pub_key)
         # Allow export of environment variables over ssh.
-        container.execute(
-            COMMAND_ALLOW_ENV_VARS.format(
-                ' '.join(PROFILES[profile][container_type]
-                         ['environment_variables'].keys())
-            )
-        )
-        container.execute('service ssh restart')
+        container.execute(shlex.split(COMMAND_ALLOW_ENV_VARS.format(
+            ' '.join(PROFILES[profile][container_type]
+                     ['environment_variables'].keys()))
+        ))
+        container.execute(shlex.split('service ssh restart'))
 
     def setup(self, profile):
         """setup the container based on the profile"""