Merge lp:~canonical-platform-qa/snappy-ecosystem-tests/adding-pylint-checker into lp:snappy-ecosystem-tests

[Heber Parrucci]

Adding pylint as code checker

This change include pylint a a code checker.

Includes:
A script run_pylint that run the checking in a virtual env
A config file in which the rules are stored

To run it locally just call the script ./run_pylint and check the results in pylint-results.txt

Another changes were made to got a positive result from pylint

I removed nose and the xml runner dependencies: do not worry, I am working on a new tests runner that uses nose2 and will be able to generate xml format results.

[platform-qa-bot (platform-qa-bot)]

PASSED: Continuous integration, rev:8
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/2/
Executed test runs:

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/2/rebuild

review: Approve (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:9
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/3/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1552/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/3/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:9
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/4/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1553/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/4/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

PASSED: Continuous integration, rev:10
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/5/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1554/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/5/rebuild

review: Approve (continuous-integration)

[I Ahmad (iahmad)]

could you please add instructions for running pylint to the README file, otherwise looks good to me

review: Approve

[Heber Parrucci (heber013)]

> could you please add instructions for running pylint to the README file,
> otherwise looks good to me

Sure. I will add instructions to README file. Thanks!

[platform-qa-bot (platform-qa-bot)]

PASSED: Continuous integration, rev:11
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/6/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1562/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/6/rebuild

review: Approve (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

PASSED: Continuous integration, rev:12
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/9/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1566/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/9/rebuild

review: Approve (continuous-integration)

[Santiago Baldassin (sbaldassin)]

Code looks good to me

review: Approve

[Omer Akram (om26er)]

Code looks good to me. We could use bzr mv instead of deleting and creating new files like tests/test-store-login.py could have been renamed to snappy_ecosystem_tests/test_store_login.py, this reduces diff size. Likewise snappy_ecosystem_tests/helpers/__init__.py could have been renamed as well.

But I won't block on that as I know revert can be quite a challenge but something we should ensure in future. Lets ship it.

review: Approve

[platform-qa-bot (platform-qa-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-autoland/2/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-land-mp/2660/console

review: Needs Fixing (continuous-integration)

=== modified file 'README'
--- README	2017-02-03 07:25:11 +0000
+++ README	2017-02-08 14:28:57 +0000
@@ -1,5 +1,5 @@
 How to setup and execute snappy ecosystem tests
-
+===============================================
 Please make sure you have following dependencies installed
 1. Python version >= 3.5
 2. nosetests >= 1.3.7
@@ -9,8 +9,9 @@
 
 Make sure webdrivers are added to $PATH
 
+
 To run the tests checkout the branch follow the below steps
-
+===========================================================
 $ bzr branch lp:snappy-ecosystem-tests
 $ cd snappy-ecosystem-tests/
 $ export UBUNTU_STORE_LOGIN_EMAIL=<store account email>
@@ -19,4 +20,10 @@
 $ nosetests --with-xunit
 
 
+Running code analysis with pylint
+=================================
+To run static code analysis you can execute from root directory:
+$ ./run_pylint
+It will store the results in pylint-results.txt
+The config file with all the rules is pylint.cfg
 

=== added file 'pylint.cfg'
--- pylint.cfg	1970-01-01 00:00:00 +0000
+++ pylint.cfg	2017-02-08 14:28:57 +0000
@@ -0,0 +1,407 @@
+[MASTER]
+
+# Specify a configuration file.
+#rcfile=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Add files or directories to the blacklist. They should be base names, not
+# paths.
+ignore=CVS
+
+# Add files or directories matching the regex patterns to the blacklist. The
+# regex matches against base names, not paths.
+ignore-patterns=
+
+# Pickle collected data for later comparisons.
+persistent=yes
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=
+
+# Use multiple processes to speed up Pylint.
+jobs=1
+
+# Allow loading of arbitrary C extensions. Extensions are imported into the
+# active Python interpreter and may run arbitrary code.
+unsafe-load-any-extension=no
+
+# A comma-separated list of package or module names from where C extensions may
+# be loaded. Extensions are loading into the active Python interpreter and may
+# run arbitrary code
+extension-pkg-whitelist=
+
+# Allow optimization of some AST trees. This will activate a peephole AST
+# optimizer, which will apply various small optimizations. For instance, it can
+# be used to obtain the result of joining multiple strings with the addition
+# operator. Joining a lot of strings can lead to a maximum recursion error in
+# Pylint and this flag can prevent that. It has one side effect, the resulting
+# AST will be different than the one from reality. This option is deprecated
+# and it will be removed in Pylint 2.0.
+optimize-ast=no
+
+
+[MESSAGES CONTROL]
+
+# Only show warnings with the listed confidence levels. Leave empty to show
+# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
+confidence=
+
+# Enable the message, report, category or checker with the given id(s). You can
+# either give multiple identifier separated by comma (,) or put this option
+# multiple time (only on the command line, not in the configuration file where
+# it should appear only once). See also the "--disable" option for examples.
+#enable=
+
+# Disable the message, report, category or checker with the given id(s). You
+# can either give multiple identifiers separated by comma (,) or put this
+# option multiple times (only on the command line, not in the configuration
+# file where it should appear only once).You can also use "--disable=all" to
+# disable everything first and then reenable specific checks. For example, if
+# you want to run only the similarities checker, you can use "--disable=all
+# --enable=similarities". If you want to run only the classes checker, but have
+# no Warning level messages displayed, use"--disable=all --enable=classes
+# --disable=W"
+disable=coerce-method,filter-builtin-not-iterating,nonzero-method,unicode-builtin,parameter-unpacking,old-raise-syntax,long-suffix,useless-suppression,unpacking-in-except,round-builtin,cmp-builtin,basestring-builtin,indexing-exception,backtick,unichr-builtin,coerce-builtin,dict-view-method,raw_input-builtin,delslice-method,no-absolute-import,print-statement,import-star-module-level,reduce-builtin,next-method-called,file-builtin,old-ne-operator,map-builtin-not-iterating,raising-string,xrange-builtin,suppressed-message,input-builtin,reload-builtin,using-cmp-argument,zip-builtin-not-iterating,standarderror-builtin,hex-method,oct-method,old-division,range-builtin-not-iterating,apply-builtin,dict-iter-method,long-builtin,buffer-builtin,metaclass-assignment,intern-builtin,execfile-builtin,cmp-method,old-octal-literal,setslice-method,getslice-method
+
+
+[REPORTS]
+
+# Set the output format. Available formats are text, parseable, colorized, msvs
+# (visual studio) and html. You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=text
+
+# Put messages in a separate file for each module / package specified on the
+# command line instead of printing them on stdout. Reports (if any) will be
+# written in a file name "pylint_global.[txt|html]". This option is deprecated
+# and it will be removed in Pylint 2.0.
+files-output=no
+
+# Tells whether to display a full report or only the messages
+reports=yes
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (RP0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Template used to display messages. This is a python new-style format string
+# used to format the message information. See doc for all details
+#msg-template=
+
+
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=(_+[a-zA-Z0-9]*?$)|dummy
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
+
+# List of strings which can identify a callback function by name. A callback
+# name must start or end with one of those strings.
+callbacks=cb_,_cb
+
+# List of qualified module names which can have objects that can redefine
+# builtins.
+redefining-builtins-modules=six.moves,future.builtins
+
+
+[LOGGING]
+
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
+
+
+[BASIC]
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,ex,Run,_
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
+
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
+
+# List of decorators that produce properties, such as abc.abstractproperty. Add
+# to this list to register other decorators that produce valid properties.
+property-classes=abc.abstractproperty
+
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression matching correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct function names
+function-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for function names
+function-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for attribute names
+attr-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct method names
+method-rgx=[a-z_][a-z0-9_]{2,30}$|setUp|tearDown
+
+# Naming hint for method names
+method-name-hint=[a-z_][a-z0-9_]{2,30}$|setUp|tearDown
+
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct argument names
+argument-rgx=[a-z_][a-z0-9_]{1,30}$
+
+# Naming hint for argument names
+argument-name-hint=[a-z_][a-z0-9_]{1,30}$
+
+# Regular expression matching correct variable names
+variable-rgx=[a-z_][a-z0-9_]{1,30}$
+
+# Naming hint for variable names
+variable-name-hint=[a-z_][a-z0-9_]{1,30}$
+
+# Regular expression which should only match function or class names that do
+# not require a docstring.
+no-docstring-rgx=.*TestCase$|setUp|tearDown
+
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
+
+
+[ELIF]
+
+# Maximum number of nested blocks for function / method body
+max-nested-blocks=5
+
+
+[FORMAT]
+
+# Maximum number of characters on a single line.
+max-line-length=100
+
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+# List of optional constructs for which whitespace checking is disabled. `dict-
+# separator` is used to allow tabulation in dicts, etc.: {1  : 1,\n222: 2}.
+# `trailing-comma` allows a space between comma and closing bracket: (a, ).
+# `empty-line` allows space-only lines.
+no-space-check=trailing-comma,dict-separator
+
+# Maximum number of lines in a module
+max-module-lines=1000
+
+# String used as indentation unit. This is usually "    " (4 spaces) or "\t" (1
+# tab).
+indent-string='    '
+
+# Number of spaces of indent required inside a hanging  or continued line.
+indent-after-paren=4
+
+# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
+expected-line-ending-format=
+
+
+[SPELLING]
+
+# Spelling dictionary name. Available dictionaries: none. To make it working
+# install python-enchant package.
+spelling-dict=
+
+# List of comma separated words that should not be checked.
+spelling-ignore-words=
+
+# A path to a file that contains private dictionary; one word per line.
+spelling-private-dict-file=
+
+# Tells whether to store unknown words to indicated private dictionary in
+# --spelling-private-dict-file option instead of raising a message.
+spelling-store-unknown-words=no
+
+
+[SIMILARITIES]
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+# Ignore imports when computing similarities.
+ignore-imports=no
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO
+
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus existing member attributes cannot be deduced by static analysis. It
+# supports qualified module names, as well as Unix pattern matching.
+ignored-modules=
+
+# List of class names for which member attributes should not be checked (useful
+# for classes with dynamically set attributes). This supports the use of
+# qualified names.
+ignored-classes=optparse.Values,thread._local,_thread._local
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E1101 when accessed. Python regular
+# expressions are accepted.
+generated-members=
+
+# List of decorators that produce context managers, such as
+# contextlib.contextmanager. Add to this list to register other decorators that
+# produce valid context managers.
+contextmanager-decorators=contextlib.contextmanager
+
+
+[CLASSES]
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+# List of member names, which should be excluded from the protected access
+# warning.
+exclude-protected=_asdict,_fields,_replace,_source,_make
+
+
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of branch for function / method body
+max-branches=12
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+# Maximum number of boolean expressions in a if statement
+max-bool-expr=5
+
+
+[IMPORTS]
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=optparse
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+# Force import order to recognize a module as part of the standard
+# compatibility libraries.
+known-standard-library=
+
+# Force import order to recognize a module as part of a third party library.
+known-third-party=enchant
+
+# Analyse import fallback blocks. This can be used to support both Python 2 and
+# 3 compatible code, which means that the block might have code that exists
+# only in one or another interpreter, leading to false positives when analysed.
+analyse-fallback-blocks=no
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=Exception

=== modified file 'requirements.txt'
--- requirements.txt	2017-02-06 10:36:22 +0000
+++ requirements.txt	2017-02-08 14:28:57 +0000
@@ -1,2 +1,2 @@
-nose >= 1.3.7
-xmlrunner >= 1.7.7
+pexpect
+selenium

=== added file 'run_pylint'
--- run_pylint	1970-01-01 00:00:00 +0000
+++ run_pylint	2017-02-08 14:28:57 +0000
@@ -0,0 +1,22 @@
+#!/bin/bash
+
+virtualenv -p python3 ve_pylint
+. ve_pylint/bin/activate
+
+proxy=$1
+if [ "$proxy" ]; then
+    echo "Using proxy: $proxy to install dependencies"
+    pip install --proxy $proxy pylint
+    pip install --proxy $proxy -r requirements.txt
+else
+    pip install pylint
+    pip install -r requirements.txt
+fi
+
+ve_pylint/bin/python3 -m pylint snappy_ecosystem_tests --reports=y --rcfile=pylint.cfg > pylint-results.txt
+
+result=$?
+
+deactivate
+
+if [ $result != 0 ] && [ $result != 4 ]; then exit 1; fi

=== renamed directory 'tests' => 'snappy_ecosystem_tests'
=== added file 'snappy_ecosystem_tests/data/__init__.py'
--- snappy_ecosystem_tests/data/__init__.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/data/__init__.py	2017-02-08 14:28:57 +0000
@@ -0,0 +1,19 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#

=== modified file 'snappy_ecosystem_tests/helpers/__init__.py'
--- tests/helpers/__init__.py	2017-02-06 10:40:05 +0000
+++ snappy_ecosystem_tests/helpers/__init__.py	2017-02-08 14:28:57 +0000
@@ -17,124 +17,3 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
-
-import unittest
-
-from selenium import webdriver
-from selenium.webdriver.support.ui import WebDriverWait
-from selenium.webdriver.support import expected_conditions as EC
-from selenium.common.exceptions import TimeoutException
-from selenium.webdriver.common.by import By
-
-from tests import storeconfig
-
-LOGIN_EMAIL, LOGIN_PASSWORD = storeconfig.get_store_credentials()
-STORE_URL = storeconfig.get_store_web_url()
-
-# default PAGE and ELEMENTS load timeout
-PAGE_LOAD_TIMEOUT = 30
-
-
-class UbuntuStoreWebTestsBase(unittest.TestCase):
-
-    def setUp(self):
-        # TODO - add support for multiple type browsers including Chrome, FF and IE
-        options = webdriver.ChromeOptions()
-        options.add_argument("--start-maximized")
-        self.driver = webdriver.Chrome(chrome_options=options)
-
-    def wait_for_element(self, locator, timeout=PAGE_LOAD_TIMEOUT):
-        """Wait of element to be loaded  for the given timeout,
-        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
-        wait = WebDriverWait(self.driver, timeout)
-        try:
-            element_present = EC.presence_of_element_located(locator)
-            wait.until(element_present)
-        except TimeoutException:
-            print ("Timed out waiting for "+locator[1]+" page")
-
-    def wait_for_page_title(self, title, timeout=PAGE_LOAD_TIMEOUT):
-        """Wait for the target page title for given timeout,
-        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
-        wait = WebDriverWait(self.driver, timeout)
-        try:
-
-            find_title = EC.title_is(title)
-            wait.until(find_title)
-
-        except TimeoutException:
-            print ("Timed out waiting for "+title+ " page")
-
-    def wait_for_visible(self, locator, timeout=PAGE_LOAD_TIMEOUT):
-        """Wait for the element to be visible for given timeout,
-        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
-        wait = WebDriverWait(self.driver, timeout)
-        try:
-            element_visible = EC.visibility_of_element_located((By.XPATH, "/html/body/nav/div/div[1]/span"))
-            wait.until(element_visible)
-        except TimeoutException:
-            print ("Timed out waiting for element to be visible")
-
-    def wait_for_clickable(self, locator, timeout=PAGE_LOAD_TIMEOUT):
-        """Wait for the element to be visible for given timeout,
-        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
-        wait = WebDriverWait(self.driver, timeout)
-        try:
-            element_clickable = EC.element_to_be_clickable((By.XPATH, "/html/body/nav/div/div[1]/span"))
-            wait.until(element_clickable)
-        except TimeoutException:
-            print ("Timed out waiting for element to be clickable")
-
-    def login(self):
-        """Login to web interface, following the UI flow which end user would use"""
-        driver = self.driver
-        driver.get(STORE_URL)
-
-        signin_link = driver.find_element_by_link_text("Sign in or register")
-        signin_link.click()
-        self.wait_for_element((By.ID, 'login-form'))
-        login_form = driver.find_element_by_id("login-form")
-        email = login_form.find_element_by_id("id_email")
-        email.send_keys(LOGIN_EMAIL)
-        password = login_form.find_element_by_id("id_password")
-        password.send_keys(LOGIN_PASSWORD)
-        login_form.submit()
-        self.wait_for_element((By.NAME, 'decideform'))
-        decide_form = driver.find_element_by_name("decideform")
-        decide_form.submit()
-        self.wait_for_page_title("Your packages")
-
-    def logout(self):
-        """Logout of web interface, following the UI flow which end user would use"""
-        driver = self.driver
-        self.wait_for_element((By.CLASS_NAME, "b-dropdown__arrow_light"))
-        #
-        # extremely ugly way to reach the desired element by xpath, a bug will be
-        # raised to uniquely identify the dropdown arrows
-        self.wait_for_clickable((By.XPATH, "/html/body/nav/div/div[1]/span"))
-        down_arrow = driver.find_element_by_xpath("/html/body/nav/div/div[1]/span")
-        #
-        # There is a bug with Firefox webdriver when clicking elements,
-        # as sometime click doesn't have any effect, to workaround that
-        # multiple attempts are made. However everything works fine with chrome webdriver.
-
-        for t in range(0,2):
-            wait = WebDriverWait(self.driver, 1)
-            try:
-                down_arrow.click()
-                element_present = EC.presence_of_element_located((By.CLASS_NAME, "b-dropdown_open"))
-                wait.until(element_present)
-                break
-            except TimeoutException:
-                print ("Failed to open the accounts dropdown menu card, Trying again")
-
-
-        self.wait_for_visible((By.LINK_TEXT, "Log out"))
-        logout_link = driver.find_element_by_link_text("Log out")
-        logout_link.click()
-
-        self.wait_for_page_title("Sign in to see your packages")
-
-    def tearDown(self):
-        self.driver.close()
-        self.driver.quit()

=== added file 'snappy_ecosystem_tests/helpers/ubuntu_store_tests_base.py'
--- snappy_ecosystem_tests/helpers/ubuntu_store_tests_base.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/helpers/ubuntu_store_tests_base.py	2017-02-08 14:28:57 +0000
@@ -0,0 +1,19 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#

=== added file 'snappy_ecosystem_tests/helpers/ubuntu_store_web_test_base.py'
--- snappy_ecosystem_tests/helpers/ubuntu_store_web_test_base.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/helpers/ubuntu_store_web_test_base.py	2017-02-08 14:28:57 +0000
@@ -0,0 +1,145 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+"""Web-Ui related functionality for testing web pages using selenium"""
+
+import unittest
+
+from selenium import webdriver
+from selenium.webdriver.support.ui import WebDriverWait
+from selenium.webdriver.support import expected_conditions as EC
+from selenium.common.exceptions import TimeoutException
+from selenium.webdriver.common.by import By
+
+from snappy_ecosystem_tests import storeconfig
+
+LOGIN_EMAIL, LOGIN_PASSWORD = storeconfig.get_store_credentials()
+STORE_URL = storeconfig.get_store_web_url()
+
+# default PAGE and ELEMENTS load timeout
+PAGE_LOAD_TIMEOUT = 30
+
+
+class UbuntuStoreWebTestsBase(unittest.TestCase):
+    """Base class to represent a Web-UI test case.
+    Contain basic functionality for locating web elements and interacting with a page
+    """
+    def setUp(self):
+        # TODO - add support for multiple type browsers including Chrome, FF and IE
+        options = webdriver.ChromeOptions()
+        options.add_argument("--start-maximized")
+        self.driver = webdriver.Chrome(chrome_options=options)
+
+    def wait_for_element(self, locator, timeout=PAGE_LOAD_TIMEOUT):
+        """Wait of element to be loaded  for the given timeout,
+        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
+        wait = WebDriverWait(self.driver, timeout)
+        try:
+            element_present = EC.presence_of_element_located(locator)
+            wait.until(element_present)
+        except TimeoutException:
+            print("Timed out waiting for "+locator[1]+" page")
+
+    def wait_for_page_title(self, title, timeout=PAGE_LOAD_TIMEOUT):
+        """Wait for the target page title for given timeout,
+        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
+        wait = WebDriverWait(self.driver, timeout)
+        try:
+            find_title = EC.title_is(title)
+            wait.until(find_title)
+        except TimeoutException:
+            print("Timed out waiting for "+title + " page")
+
+    def wait_for_visible(self, timeout=PAGE_LOAD_TIMEOUT):
+        # TODO: re-implement to allow any locator as parameter
+        """Wait for the element to be visible for given timeout,
+        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
+        wait = WebDriverWait(self.driver, timeout)
+        try:
+            element_visible = EC.visibility_of_element_located(
+                (By.XPATH, "/html/body/nav/div/div[1]/span"))
+            wait.until(element_visible)
+        except TimeoutException:
+            print("Timed out waiting for element to be visible")
+
+    def wait_for_clickable(self, timeout=PAGE_LOAD_TIMEOUT):
+        # TODO: re-implement to allow any locator as parameter
+        """Wait for the element to be visible for given timeout,
+        default timeout is as per PAGE_LOAD_TIMEOUT variable"""
+        wait = WebDriverWait(self.driver, timeout)
+        try:
+            element_clickable = EC.element_to_be_clickable(
+                (By.XPATH, "/html/body/nav/div/div[1]/span"))
+            wait.until(element_clickable)
+        except TimeoutException:
+            print("Timed out waiting for element to be clickable")
+
+    def login(self):
+        """Login to web interface, following the UI flow which end user would use"""
+        driver = self.driver
+        driver.get(STORE_URL)
+
+        signin_link = driver.find_element_by_link_text("Sign in or register")
+        signin_link.click()
+        self.wait_for_element((By.ID, 'login-form'))
+        login_form = driver.find_element_by_id("login-form")
+        email = login_form.find_element_by_id("id_email")
+        email.send_keys(LOGIN_EMAIL)
+        password = login_form.find_element_by_id("id_password")
+        password.send_keys(LOGIN_PASSWORD)
+        login_form.submit()
+        self.wait_for_element((By.NAME, 'decideform'))
+        decide_form = driver.find_element_by_name("decideform")
+        decide_form.submit()
+        self.wait_for_page_title("Your packages")
+
+    def logout(self):
+        """Logout of web interface, following the UI flow which end user would use"""
+        driver = self.driver
+        self.wait_for_element((By.CLASS_NAME, "b-dropdown__arrow_light"))
+        #
+        # extremely ugly way to reach the desired element by xpath, a bug will be
+        # raised to uniquely identify the dropdown arrows
+        self.wait_for_clickable()
+        down_arrow = driver.find_element_by_xpath("/html/body/nav/div/div[1]/span")
+        #
+        # There is a bug with Firefox webdriver when clicking elements,
+        # as sometime click doesn't have any effect, to workaround that
+        # multiple attempts are made. However everything works fine with chrome webdriver.
+
+        for _ in range(0, 2):
+            wait = WebDriverWait(self.driver, 1)
+            try:
+                down_arrow.click()
+                element_present = EC.presence_of_element_located((By.CLASS_NAME, "b-dropdown_open"))
+                wait.until(element_present)
+                break
+            except TimeoutException:
+                print("Failed to open the accounts dropdown menu card, Trying again")
+
+        self.wait_for_visible()
+        logout_link = driver.find_element_by_link_text("Log out")
+        logout_link.click()
+
+        self.wait_for_page_title("Sign in to see your packages")
+
+    def tearDown(self):
+        self.driver.close()
+        self.driver.quit()

=== added file 'snappy_ecosystem_tests/pageobjects/__init__.py'
--- snappy_ecosystem_tests/pageobjects/__init__.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/pageobjects/__init__.py	2017-02-08 14:28:57 +0000
@@ -0,0 +1,19 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#

=== modified file 'snappy_ecosystem_tests/storeconfig.py'
--- tests/storeconfig.py	2017-02-07 11:35:30 +0000
+++ snappy_ecosystem_tests/storeconfig.py	2017-02-08 14:28:57 +0000
@@ -18,6 +18,8 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 
+"""Helpers to retrieve store configuration data like: credentials, urls, etc"""
+
 import os
 
 KEY_ENVIRON_STORE_LOGIN_EMAIL = 'UBUNTU_STORE_LOGIN_EMAIL'

=== added file 'snappy_ecosystem_tests/test_store_login.py'
--- snappy_ecosystem_tests/test_store_login.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/test_store_login.py	2017-02-08 14:28:57 +0000
@@ -0,0 +1,47 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+"""Test for Login to the Store via Web Interface, snapcraft and snapd"""
+
+from snappy_ecosystem_tests.utils.snapcraft import Snapcraft
+from snappy_ecosystem_tests.helpers.ubuntu_store_web_test_base import UbuntuStoreWebTestsBase
+
+
+class StoreLoginTestCase(UbuntuStoreWebTestsBase):
+    def setUp(self):
+        super().setUp()
+
+    def test_login_logout(self):
+        """Test login and logout functionality of snapcraft, web interface
+        and snapd."""
+        try:
+            sc = Snapcraft()
+            sc.login()
+            sc.logout()
+        except ValueError as err:
+            self.fail(msg=err)
+
+        self.login()
+        self.assertEqual(self.driver.title, "Your packages", "Failed to login")
+        # TODO - fragile as there is no unique way to identify the dropdown arrow
+        self.logout()
+        self.assertEqual(
+            self.driver.title, "Sign in to see your packages",
+            "Failed to logout")

=== added directory 'snappy_ecosystem_tests/tests'
=== added file 'snappy_ecosystem_tests/tests/__init__.py'
--- snappy_ecosystem_tests/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/tests/__init__.py	2017-02-08 14:28:57 +0000
@@ -0,0 +1,19 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#

=== modified file 'snappy_ecosystem_tests/utils/snapcraft.py'
--- tests/utils/snapcraft.py	2017-02-06 10:40:05 +0000
+++ snappy_ecosystem_tests/utils/snapcraft.py	2017-02-08 14:28:57 +0000
@@ -18,13 +18,17 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 
+"""Snapcraft related helpers to configure the snapcraft environment: staging or production
+and other specific functions inside Snapcraft class
+"""
+
 import os
-
 import pexpect
 
-from tests import storeconfig
 
 # login credentials exported by shell environment
+from snappy_ecosystem_tests import storeconfig
+
 LOGIN_EMAIL, LOGIN_PASSWORD = storeconfig.get_store_credentials()
 
 
@@ -36,7 +40,8 @@
         os.environ["UBUNTU_STORE_SEARCH_ROOT_URL"] = 'https://search.apps.staging.ubuntu.com/'
         os.environ["UBUNTU_STORE_UPLOAD_ROOT_URL"] = 'https://upload.apps.staging.ubuntu.com/'
         os.environ["UBUNTU_SSO_API_ROOT_URL"] = 'https://login.staging.ubuntu.com/api/v2/'
-        os.environ["UBUNTU_STORE_API_ROOT_URL"] = 'https://myapps.developer.staging.ubuntu.com/dev/api/'
+        os.environ["UBUNTU_STORE_API_ROOT_URL"] = \
+            'https://myapps.developer.staging.ubuntu.com/dev/api/'
     else:
         os.environ["UBUNTU_STORE_SEARCH_ROOT_URL"] = 'https://search.apps.ubuntu.com/'
         os.environ["UBUNTU_STORE_UPLOAD_ROOT_URL"] = 'https://upload.apps.ubuntu.com/'
@@ -45,6 +50,7 @@
 
 
 class Snapcraft(object):
+    """Contain Snapcraft specific functionality to use via command line interface"""
     def __init__(self):
         """Create new snapcraft instance."""
         self._login = False
@@ -52,6 +58,7 @@
         self._cleanup()
 
     def _cleanup(self):
+        """Perform cleanup actions"""
         self.logout()
 
     def logout(self):
@@ -78,10 +85,8 @@
 
         self._login = True
 
-    def listRegistered(self):
+    def list_registered(self):
         """call snapcraft list-registered command, raise exception if not logged in"""
         if self._login is False:
             raise ValueError("User is not logged in, please login before using this command")
         return pexpect.spawnu("snapcraft list-registered").read()
-
-

=== removed file 'tests/helpers/ubuntu-store-tests-base.py'
--- tests/helpers/ubuntu-store-tests-base.py	2017-02-06 10:40:05 +0000
+++ tests/helpers/ubuntu-store-tests-base.py	1970-01-01 00:00:00 +0000
@@ -1,19 +0,0 @@
-# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
-
-#
-# Snappy Ecosystem Tests
-# Copyright (C) 2017 Canonical
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#

=== removed file 'tests/test-store-login.py'
--- tests/test-store-login.py	2017-02-06 10:40:05 +0000
+++ tests/test-store-login.py	1970-01-01 00:00:00 +0000
@@ -1,58 +0,0 @@
-# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
-
-#
-# Snappy Ecosystem Tests
-# Copyright (C) 2017 Canonical
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-
-import unittest
-
-import xmlrunner
-
-from tests.helpers import UbuntuStoreWebTestsBase
-from tests.utils.snapcraft import Snapcraft
-
-
-class StoreLoginTests(UbuntuStoreWebTestsBase):
-
-    def setUp(self):
-        super().setUp()
-
-    def test_login_logout(self):
-        """Test login and logout functionality of snapcraft, web interface
-        and snapd."""
-        try:
-            sc = Snapcraft()
-            sc.login()
-            sc.logout()
-        except ValueError as err:
-            self.fail(err.message)
-
-        self.login()
-        self.assertEqual(self.driver.title, "Your packages", "Failed to login")
-        # TODO - fragile as there is no unique way to identify the dropdown arrow # NOQA
-        self.logout()
-        self.assertEqual(
-            self.driver.title, "Sign in to see your packages",
-            "Failed to logout")
-
-
-if __name__ == '__main__':
-    unittest.main(
-        testRunner=xmlrunner.XMLTestRunner(output='test-reports'),
-        # these make sure that some options that are not applicable
-        # remain hidden from the help menu.
-        failfast=False, buffer=False, catchbreak=False)