Merge lp:~canonical-platform-qa/reminders-app/workaround1363604-add_sleep into lp:reminders-app

Proposed by Leo Arias
Status: Merged
Merged at revision: 234
Proposed branch: lp:~canonical-platform-qa/reminders-app/workaround1363604-add_sleep
Merge into: lp:reminders-app
Diff against target: 14 lines (+4/-0)
1 file modified
tests/autopilot/reminders/credentials.py (+4/-0)
To merge this branch: bzr merge lp:~canonical-platform-qa/reminders-app/workaround1363604-add_sleep
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Nicholas Skaggs (community) Approve
Review via email: mp+232912@code.launchpad.net

Commit message

Added a sleep on the delete account test helper to workaround bug 1363604

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Thanks Leo!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Due to the issues with jenkins not running the existing testsuite, this will not pass jenkins despite fixing the issue. As a workaround, I will manually merge this into trunk. I have confirmed the tests pass locally as well as on the device.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/reminders/credentials.py'
2--- tests/autopilot/reminders/credentials.py 2014-07-24 21:36:02 +0000
3+++ tests/autopilot/reminders/credentials.py 2014-09-01 23:11:08 +0000
4@@ -178,6 +178,10 @@
5 """
6 logger.info('Deleting the account with id {}.'.format(account.id))
7 self._start_main_loop()
8+ # XXX There seems to be a problem when we try to delete the account too
9+ # soon after starting the main loop.
10+ # Reported as bug http://pad.lv/1363604. --elopio - 2014-09-01
11+ time.sleep(10)
12 account.delete()
13 account.store(self._on_account_deleted, None)
14 self._join_main_loop()

Subscribers

People subscribed via source and target branches