Merge lp:~canonical-platform-qa/qa-jenkins-jobs/temporarily-pass-no-tests into lp:qa-jenkins-jobs

Proposed by Allan LeSage
Status: Merged
Approved by: Max Brustkern
Approved revision: 168
Merged at revision: 168
Proposed branch: lp:~canonical-platform-qa/qa-jenkins-jobs/temporarily-pass-no-tests
Merge into: lp:qa-jenkins-jobs
Diff against target: 28 lines (+4/-3)
2 files modified
jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh (+3/-2)
scripts/ubuntu-system-tests/get_tests_to_run.py (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/qa-jenkins-jobs/temporarily-pass-no-tests
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
platform-qa-bot continuous-integration Approve
Review via email: mp+302460@code.launchpad.net

Commit message

Temporarily pass jobs with no tests specified to appease CI MP process pending Conditional Build Step plugin installation.

Description of the change

Until I'm able to get the Conditional Build Step plugin installed, need to "PASS" builds listing no tests b/c the CI job will invoke ubuntu-system-tests with no tests if none are found in a merge proposal. In the future we'll use the Conditional Build Step plugin, that'll be much cleaner and more correct, but for the moment MP CI is erroneously failing.

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Seems legit.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh'
2--- jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-07-19 20:23:05 +0000
3+++ jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-08-09 19:18:23 +0000
4@@ -29,8 +29,9 @@
5 TESTS_TO_RUN=$(bzr cat "$UBUNTU_SYSTEM_TESTS_BRANCH/test_lists/sanity.tests" | tr '\n' ' ')
6 ;;
7 "")
8- echo "Please specify tests to run!" >&2
9- exit 1
10+ # FIXME: restore error when we're able to install Conditional Build Step plugin!
11+ echo "No tests specified, PASS!" >&2
12+ exit 0
13 ;;
14 esac
15
16
17=== modified file 'scripts/ubuntu-system-tests/get_tests_to_run.py'
18--- scripts/ubuntu-system-tests/get_tests_to_run.py 2016-08-02 16:23:29 +0000
19+++ scripts/ubuntu-system-tests/get_tests_to_run.py 2016-08-09 19:18:23 +0000
20@@ -33,7 +33,7 @@
21 try:
22 tests = commit_message.split('@run_tests:')[1:][0].strip()
23 except IndexError:
24- tests = []
25+ tests = ""
26 sys.stdout.write(str(tests))
27
28 if __name__ == "__main__":

Subscribers

People subscribed via source and target branches