Merge lp:~canonical-platform-qa/qa-jenkins-jobs/separate-subunit-to-junit-builder into lp:qa-jenkins-jobs

Proposed by Allan LeSage
Status: Merged
Approved by: Max Brustkern
Approved revision: 52
Merged at revision: 53
Proposed branch: lp:~canonical-platform-qa/qa-jenkins-jobs/separate-subunit-to-junit-builder
Merge into: lp:qa-jenkins-jobs
Diff against target: 66 lines (+18/-11)
3 files modified
jobs/ubuntu-system-tests/jobs.yaml (+7/-0)
jobs/ubuntu-system-tests/subunit-to-junit.sh (+10/-0)
scripts/ubuntu-system-tests/run-ubuntu-system-tests.sh (+1/-11)
To merge this branch: bzr merge lp:~canonical-platform-qa/qa-jenkins-jobs/separate-subunit-to-junit-builder
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Approve
Max Brustkern (community) Approve
Review via email: mp+297571@code.launchpad.net

Commit message

Perform subunit-to-junit conversion in a separate builder.

Description of the change

subunit in the archive won't translate subunit skipped tests to junit skipped tests, literally inserting 'skip' instead of 'skipped' in the XML; the remedy is to get the freshest subunit via PyPi, this MP breaks the subunit2junit step into its own builder downstream of the build proper to accomplish such.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

LGTM

review: Approve
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~canonical-platform-qa/qa-jenkins-jobs/separate-subunit-to-junit-builder/+merge/297571/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/ubuntu-system-tests/jobs.yaml'
2--- jobs/ubuntu-system-tests/jobs.yaml 2016-06-02 22:35:43 +0000
3+++ jobs/ubuntu-system-tests/jobs.yaml 2016-06-15 22:54:36 +0000
4@@ -83,6 +83,7 @@
5 - clear-artifacts
6 - flash-device-builder
7 - ubuntu-system-tests-builder
8+ - subunit-to-junit-results-builder
9 publishers:
10 - archive:
11 artifacts: 'results/**/*'
12@@ -177,6 +178,12 @@
13 - shell:
14 !include-raw: 'ubuntu-system-tests-builder.sh'
15
16+- builder:
17+ name: subunit-to-junit-results-builder
18+ builders:
19+ - shell:
20+ !include-raw: 'subunit-to-junit.sh'
21+
22 - job-template:
23 name: 'ust_report-results-to-practitest'
24 parameters:
25
26=== added file 'jobs/ubuntu-system-tests/subunit-to-junit.sh'
27--- jobs/ubuntu-system-tests/subunit-to-junit.sh 1970-01-01 00:00:00 +0000
28+++ jobs/ubuntu-system-tests/subunit-to-junit.sh 2016-06-15 22:54:36 +0000
29@@ -0,0 +1,10 @@
30+
31+virtualenv --python=python3 ve3
32+. ve3/bin/activate
33+
34+pip3 install subunit
35+pip3 install junitxml
36+
37+subunit2junitxml $WORKSPACE/results/artifacts/test-results.subunit > $WORKSPACE/results/artifacts/test-results.xml
38+
39+deactivate # our virtualenv
40
41=== modified file 'scripts/ubuntu-system-tests/run-ubuntu-system-tests.sh'
42--- scripts/ubuntu-system-tests/run-ubuntu-system-tests.sh 2016-05-13 10:13:39 +0000
43+++ scripts/ubuntu-system-tests/run-ubuntu-system-tests.sh 2016-06-15 22:54:36 +0000
44@@ -8,21 +8,11 @@
45 virtualenv --python=python3 ve3
46 . ve3/bin/activate
47
48-# uci-config is broken in trusty ppa
49-rm -rf uci-config
50-bzr branch lp:uci-config
51-CURDIR=`pwd`
52-cd uci-config
53-python3 setup.py install
54-cd $CURDIR
55-
56 rm -rf ubuntu-system-tests
57 bzr branch $UBUNTU_SYSTEM_TESTS_BRANCH ubuntu-system-tests
58 cd ubuntu-system-tests
59+
60 python3 setup.py develop
61 python3 -m ubuntu_system_tests.run -n -d -p -u -v --config=$CONFIG_PATH "$TESTS"
62
63 deactivate # our virtualenv
64-
65-# TODO: run this as a post-build step
66-subunit2junitxml $WORKSPACE/results/artifacts/test-results.subunit > $WORKSPACE/results/artifacts/test-results.xml || true

Subscribers

People subscribed via source and target branches