Merge lp:~canonical-platform-qa/qa-jenkins-jobs/restore-ust-minus-x into lp:qa-jenkins-jobs

Proposed by Allan LeSage
Status: Merged
Approved by: Allan LeSage
Approved revision: 173
Merged at revision: 173
Proposed branch: lp:~canonical-platform-qa/qa-jenkins-jobs/restore-ust-minus-x
Merge into: lp:qa-jenkins-jobs
Diff against target: 9 lines (+1/-0)
1 file modified
jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh (+1/-0)
To merge this branch: bzr merge lp:~canonical-platform-qa/qa-jenkins-jobs/restore-ust-minus-x
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
platform-qa-bot continuous-integration Approve
Review via email: mp+303725@code.launchpad.net

Commit message

Restore -x debugging for ust runs.

Description of the change

When eliminating the job-running script by pushing it back into the job definition I think I removed -x bash debugging, restore it here.

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

If you leave out the shebang line, jenkins will set -ex by default. If you don't want -e, though, then this makes sense.

review: Approve
Revision history for this message
Allan LeSage (allanlesage) wrote :

Need the shebang for some bash devilishness elsewhere in that particular script, which contributed to my failure to add -x here when moving from one script to another. Thx for review!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh'
2--- jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-08-18 23:58:31 +0000
3+++ jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-08-23 19:14:02 +0000
4@@ -1,4 +1,5 @@
5 #!/bin/bash
6+set -x
7
8 # use plars' lifeboat scripts to get our adb serial
9 rm -rf lifeboat

Subscribers

People subscribed via source and target branches