Merge lp:~canonical-platform-qa/qa-jenkins-jobs/fix-spurious-subunit2junitxml-failure into lp:qa-jenkins-jobs

Proposed by Allan LeSage
Status: Merged
Approved by: Max Brustkern
Approved revision: 159
Merged at revision: 157
Proposed branch: lp:~canonical-platform-qa/qa-jenkins-jobs/fix-spurious-subunit2junitxml-failure
Merge into: lp:qa-jenkins-jobs
Diff against target: 15 lines (+1/-2)
1 file modified
jobs/ubuntu-system-tests/subunit-to-junit.sh (+1/-2)
To merge this branch: bzr merge lp:~canonical-platform-qa/qa-jenkins-jobs/fix-spurious-subunit2junitxml-failure
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
platform-qa-bot continuous-integration Approve
Review via email: mp+299454@code.launchpad.net

Commit message

Set +x to avoid a spurious subunit2junitxml error.

Description of the change

Getting a return of 1 for subunit2junitxml although the stream produced appears complete, hence I must shrug shoulders and set +x so that our jobs don't all appear to fail due to this spurious subunit2junitxml error? Max any comments on a better/best way to do this?

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
158. By Allan LeSage

Oops meant +e.

Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

If you want to just ignore failures from that operation, I'd do
command || true
That'll let us pick up on failures from anything else.

159. By Allan LeSage

Switch to or true.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/ubuntu-system-tests/subunit-to-junit.sh'
2--- jobs/ubuntu-system-tests/subunit-to-junit.sh 2016-06-28 22:02:25 +0000
3+++ jobs/ubuntu-system-tests/subunit-to-junit.sh 2016-07-08 20:31:53 +0000
4@@ -1,10 +1,9 @@
5-
6 virtualenv --python=python3 ve3
7 . ve3/bin/activate
8
9 pip3 install python-subunit
10 pip3 install junitxml
11
12-subunit2junitxml $WORKSPACE/results/artifacts/test-results.subunit > $WORKSPACE/results/artifacts/test-results.xml
13+subunit2junitxml $WORKSPACE/results/artifacts/test-results.subunit > $WORKSPACE/results/artifacts/test-results.xml || true
14
15 deactivate # our virtualenv

Subscribers

People subscribed via source and target branches