Merge lp:~canonical-platform-qa/qa-jenkins-jobs/conditional-ust-ci into lp:qa-jenkins-jobs

Proposed by Allan LeSage
Status: Merged
Approved by: Max Brustkern
Approved revision: 173
Merged at revision: 163
Proposed branch: lp:~canonical-platform-qa/qa-jenkins-jobs/conditional-ust-ci
Merge into: lp:qa-jenkins-jobs
Diff against target: 40 lines (+15/-8)
2 files modified
jobs/ubuntu-system-tests/ci-jobs.yaml (+12/-5)
jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh (+3/-3)
To merge this branch: bzr merge lp:~canonical-platform-qa/qa-jenkins-jobs/conditional-ust-ci
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
platform-qa-bot continuous-integration Approve
Review via email: mp+303855@code.launchpad.net

Commit message

Conditionally run ust MP CI only if tests to run are specified.

Description of the change

Now that we've installed the conditional-build-step plugin, use it to only run ust CI when the MP specifies a test to run.

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Deploys correctly for me!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/ubuntu-system-tests/ci-jobs.yaml'
2--- jobs/ubuntu-system-tests/ci-jobs.yaml 2016-08-03 17:11:19 +0000
3+++ jobs/ubuntu-system-tests/ci-jobs.yaml 2016-08-24 18:58:14 +0000
4@@ -96,8 +96,15 @@
5 - builder:
6 name: trigger-ust-builder
7 builders:
8- - trigger-builds:
9- - project:
10- - 'ust_rc-proposed_krillin_sanity_test'
11- block: true
12- property-file: $WORKSPACE/ust-parameters.txt
13+ - conditional-step:
14+ condition-kind: not
15+ condition-operand:
16+ condition-kind: strings-match
17+ condition-string1: ${PROPFILE,file="ust-parameters.txt",property="TESTS_TO_RUN"}
18+ condition-string2: ""
19+ steps:
20+ - trigger-builds:
21+ - project:
22+ - 'ust_rc-proposed_krillin_sanity_test'
23+ block: true
24+ property-file: $WORKSPACE/ust-parameters.txt
25
26=== modified file 'jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh'
27--- jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-08-23 19:12:14 +0000
28+++ jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-08-24 18:58:14 +0000
29@@ -47,9 +47,9 @@
30 TESTS_TO_RUN=$(query_practitest_for_tests_to_run_by_filter 63805)
31 ;;
32 "")
33- # FIXME: restore error when we're able to install Conditional Build Step plugin!
34- echo "No tests specified, PASS!" >&2
35- exit 0
36+ # NOTE that conditional build step should've prevented
37+ echo "Please specify tests to run!" >&2
38+ exit 1
39 ;;
40 esac
41

Subscribers

People subscribed via source and target branches