Merge lp:~canonical-platform-qa/qa-jenkins-jobs/add-regression-list into lp:qa-jenkins-jobs

Proposed by Allan LeSage
Status: Merged
Approved by: Max Brustkern
Approved revision: 162
Merged at revision: 163
Proposed branch: lp:~canonical-platform-qa/qa-jenkins-jobs/add-regression-list
Merge into: lp:qa-jenkins-jobs
Diff against target: 12 lines (+1/-1)
1 file modified
jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/qa-jenkins-jobs/add-regression-list
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
platform-qa-bot continuous-integration Approve
Review via email: mp+300377@code.launchpad.net

Commit message

Add ust regression tests list.

Description of the change

See https://code.launchpad.net/~canonical-platform-qa/ubuntu-system-tests/add-regression-list/+merge/300375 , this just takes advantage of the now-explicit regression tests list so that we can re-run each individual test on error.

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

This looks good. If the other branch doesn't land, will the output be a failure, or can we make it just be empty? If it's still empty, will the other stuff work as expected? If not, we should make sure the regression list lands.

On the subject of the other merge, if I were maintaining that, I'd probably land it reluctantly and then work on a solution to generate the list automatically with minimal dependencies, but that might take a while.

Revision history for this message
Allan LeSage (allanlesage) wrote :

Too late, the other branch landed! Your criticism is welcome on the other branch Max but I'm going to use the "because pragmatism" argument, with a less maintenance-heavy solution being discussed with rhuddie.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh'
2--- jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-05-26 22:22:08 +0000
3+++ jobs/ubuntu-system-tests/ubuntu-system-tests-builder.sh 2016-07-18 18:15:16 +0000
4@@ -21,7 +21,7 @@
5
6 case "$TESTS_TO_RUN" in
7 "regression")
8- TESTS_TO_RUN=""
9+ TESTS_TO_RUN=$(bzr cat "$UBUNTU_SYSTEM_TESTS_BRANCH/test_lists/regression.tests" | tr '\n' ' ')
10 ;;
11 "sanity")
12 TESTS_TO_RUN=$(bzr cat "$UBUNTU_SYSTEM_TESTS_BRANCH/test_lists/sanity.tests" | tr '\n' ' ')

Subscribers

People subscribed via source and target branches