messaging-app

Merge lp:~canonical-platform-qa/messaging-app/fix_send_button into lp:messaging-app

  1. fix_send_button
  2. Merge into trunk
Proposed by Brendan Donegan on 2015-08-06
Status: Merged
Approved by: Gustavo Pichorim Boiko on 2015-08-12
Approved revision: 419
Merged at revision: 423
Proposed branch: lp:~canonical-platform-qa/messaging-app/fix_send_button
Merge into: lp:messaging-app
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/messaging_app/emulators.py (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/messaging-app/fix_send_button
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) 2015-08-06 Approve on 2015-08-12
PS Jenkins bot continuous-integration Needs Fixing on 2015-08-06
Review via email: mp+267163@code.launchpad.net

Commit Message

Remove component version from get_send_button

Description of the Change

It looks like to work around an issue with Autopilot, the messaging-app emulators were hardcoding the component version for the Send Icon to 'Icon11'. It seems a fix for this has landed but subsequently broke code that tried this workaround. We can now remove the '11' and just specify 'Icon' and Autopilot will handle it.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/messaging_app/emulators.py'
2--- tests/autopilot/messaging_app/emulators.py 2015-07-10 19:24:09 +0000
3+++ tests/autopilot/messaging_app/emulators.py 2015-08-06 09:31:15 +0000
4@@ -125,7 +125,7 @@
5 def get_send_button(self):
6 """Return Button with text Send"""
7
8- return self.get_messages_page().select_single('Icon11',
9+ return self.get_messages_page().select_single('Icon',
10 objectName='sendButton')
11
12 def get_toolbar_back_button(self):

Subscribers

People subscribed via source and target branches