Merge lp:~canonical-platform-qa/messaging-app/bug1513044_label_uclabel into lp:messaging-app

Proposed by Brendan Donegan
Status: Needs review
Proposed branch: lp:~canonical-platform-qa/messaging-app/bug1513044_label_uclabel
Merge into: lp:messaging-app
Diff against target: 135 lines (+16/-16)
2 files modified
tests/autopilot/messaging_app/emulators.py (+4/-4)
tests/autopilot/messaging_app/tests/test_messaging.py (+12/-12)
To merge this branch: bzr merge lp:~canonical-platform-qa/messaging-app/bug1513044_label_uclabel
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+276641@code.launchpad.net

Description of the change

As per https://bugs.launchpad.net/ubuntu/+source/messaging-app/+bug/1513044, Label seems to have switched to UCLabel. This is just a quick update to account for that

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:460
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/messaging-app/bug1513044_label_uclabel/+merge/276641/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/messaging-app-ci/691/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5010/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/204/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5007/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/691/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

460. By Brendan Donegan

Update references to Label to UCLabel

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/messaging_app/emulators.py'
2--- tests/autopilot/messaging_app/emulators.py 2015-09-11 14:25:57 +0000
3+++ tests/autopilot/messaging_app/emulators.py 2015-11-04 12:25:41 +0000
4@@ -60,7 +60,7 @@
5
6 time.sleep(2) # message is not always found on slow emulator
7 for message in self.select_many(MessageDelegateFactory):
8- for item in message.select_many('Label'):
9+ for item in message.select_many('UCLabel'):
10 if "text" in item.get_properties():
11 if item.get_properties()['text'] == text:
12 return message
13@@ -73,7 +73,7 @@
14 :parameter text: the text of the label to return
15 """
16
17- return self.select_single('Label', visible=True, text=text)
18+ return self.select_single('UCLabel', visible=True, text=text)
19
20 def get_main_page(self):
21 """Return messages with objectName messagesPage"""
22@@ -506,9 +506,9 @@
23 for index in range(self.get_messages_count()):
24 message_delegate = self._get_message_delegate(index)
25 date = message_delegate.select_single(
26- 'Label', objectName='messageDate').text
27+ 'UCLabel', objectName='messageDate').text
28 text = message_delegate.select_single(
29- 'Label', objectName='messageText').text
30+ 'UCLabel', objectName='messageText').text
31 messages.append((date, text))
32 return messages
33
34
35=== modified file 'tests/autopilot/messaging_app/tests/test_messaging.py'
36--- tests/autopilot/messaging_app/tests/test_messaging.py 2015-10-08 22:00:25 +0000
37+++ tests/autopilot/messaging_app/tests/test_messaging.py 2015-11-04 12:25:41 +0000
38@@ -79,10 +79,10 @@
39 self.assertThat(self.thread_list.count, Eventually(Equals(1)))
40
41 # verify number
42- self.thread_list.select_single('Label', text='0815')
43+ self.thread_list.select_single('UCLabel', text='0815')
44 time.sleep(1) # make it visible to human users for a sec
45 # verify text
46- self.thread_list.select_single('Label', text='hello to Ubuntu')
47+ self.thread_list.select_single('UCLabel', text='hello to Ubuntu')
48
49 def test_write_new_message(self):
50 """Verify we can write and send a new text message"""
51@@ -104,7 +104,7 @@
52 thread = self.main_view.get_thread_from_number(phone_num)
53 self.assertThat(thread.phoneNumber, Equals(phone_num))
54 # verify our text
55- thread.wait_select_single('Label', text=message)
56+ thread.wait_select_single('UCLabel', text=message)
57
58 def test_deleting_message_long_press(self):
59 """Verify we can delete a message with a long press on the message"""
60@@ -146,7 +146,7 @@
61 helpers.receive_sms(number, message)
62 self.assertThat(self.thread_list.count, Eventually(Equals(1)))
63 # click message thread
64- mess_thread = self.thread_list.wait_select_single('Label', text=number)
65+ mess_thread = self.thread_list.wait_select_single('UCLabel', text=number)
66 self.pointing_device.click_object(mess_thread)
67 self.main_view.get_message(message)
68 # send new message
69@@ -188,7 +188,7 @@
70 # verify messsage is not gone
71 time.sleep(5) # wait 5 seconds, the emulator is slow
72 list_view = self.main_view.get_multiple_selection_list_view()
73- list_view.select_single("Label", text=message)
74+ list_view.select_single("UCLabel", text=message)
75
76 def test_receive_text_with_letters_in_phone_number(self):
77 """verify we can receive a text message with letters for a phone #"""
78@@ -199,7 +199,7 @@
79 self.assertThat(self.thread_list.count, Eventually(Equals(1)))
80 # click message thread
81 mess_thread = self.thread_list.wait_select_single(
82- 'Label',
83+ 'UCLabel',
84 text='letters@' # phonesim sends text with number as letters@
85 )
86 self.pointing_device.click_object(mess_thread)
87@@ -231,7 +231,7 @@
88 thread = self.main_view.get_thread_from_number(phone_num)
89 self.assertThat(thread.phoneNumber, Equals(phone_num))
90 # verify our text
91- thread.select_single('Label', text=message)
92+ thread.select_single('UCLabel', text=message)
93 # use select button in toolbar
94 self.main_view.enable_threads_selection_mode()
95 # click cancel button
96@@ -240,7 +240,7 @@
97 thread = self.main_view.get_thread_from_number(phone_num)
98 self.assertThat(thread.phoneNumber, Equals(phone_num))
99 # verify our text was not deleted
100- thread.select_single('Label', text=message)
101+ thread.select_single('UCLabel', text=message)
102
103 def test_delete_thread_from_main_view(self):
104 """Verify we can delete a message thread"""
105@@ -261,7 +261,7 @@
106 # verify our number
107 mess_thread = self.main_view.get_thread_from_number(phone_num)
108 # verify our text
109- self.thread_list.select_single('Label', text=message)
110+ self.thread_list.select_single('UCLabel', text=message)
111 # use select button in toolbar
112 self.main_view.enable_threads_selection_mode()
113 # click thread we want to delete
114@@ -342,10 +342,10 @@
115 self.assertThat(self.thread_list.count, Eventually(Equals(1)))
116
117 # verify number
118- self.thread_list.select_single('Label', text='Orange')
119+ self.thread_list.select_single('UCLabel', text='Orange')
120 time.sleep(1) # make it visible to human users for a sec
121 # verify text
122- self.thread_list.select_single('Label', text='hello to Ubuntu')
123+ self.thread_list.select_single('UCLabel', text='hello to Ubuntu')
124
125
126 class MessagingTestCaseWithExistingThread(MessagingAppTestCase):
127@@ -568,7 +568,7 @@
128 self.assertThat(thread_list.count, Eventually(Equals(1)))
129
130 # click message thread
131- mess_thread = thread_list.wait_select_single('Label', text=number)
132+ mess_thread = thread_list.wait_select_single('UCLabel', text=number)
133 self.pointing_device.click_object(mess_thread)
134
135 swipe_item_demo = self.main_view.get_swipe_item_demo()

Subscribers

People subscribed via source and target branches