dialer-app

Merge lp:~canonical-platform-qa/dialer-app/qmltests1 into lp:dialer-app

qmltests1
Merge into trunk

Proposed by Leo Arias on 2014-09-02

Status:	Merged
Approved by:	Gustavo Pichorim Boiko on 2014-09-10
Approved revision:	238
Merged at revision:	270
Proposed branch:	lp:~canonical-platform-qa/dialer-app/qmltests1
Merge into:	lp:dialer-app
Prerequisite:	lp:~canonical-platform-qa/dialer-app/custom_proxy_objects
Diff against target:	218 lines (+146/-2) 7 files modified debian/control (+4/-0) debian/rules (+1/-1) src/qml/CMakeLists.txt (+2/-0) src/qml/DialerPage/KeypadButton.qml (+3/-1) tests/CMakeLists.txt (+2/-0) tests/qml/CMakeLists.txt (+31/-0) tests/qml/tst_KeypadButton.qml (+103/-0)
To merge this branch:	bzr merge lp:~canonical-platform-qa/dialer-app/qmltests1
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2014-09-02	Approve on 2014-09-10
Didier Roche-Tolomelli		2014-09-02	Approve on 2014-09-09
PS Jenkins bot	continuous-integration	2014-09-02	Approve on 2014-09-08
Canonical Platform QA Team		2014-09-02	Pending
Review via email: mp+233130@code.launchpad.net

This proposal supersedes a proposal from 2014-08-12.

Commit message

Added the initial suite of QML tests.

Description of the change

Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, from boiko:
<boiko> btw, the failure on the qmltests branch is due to telephony-service's qml plugin not pulling the gsettings schemas, but I have an MR to fix that in the same silo

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

It is.

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

I ran the tests many times. They failed only on the schroot and boiko has now found the cause.

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

No functionality changes, so no need to run manual tests.

If you changed the UI, was the change specified/approved by design?

No UI changes.

If you changed UI labels, did you update the pot file?

No UI changes.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

Subscribing...

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-12: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/372/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-12: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/375/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-08-12: Posted in a previous version of this proposal

Hum, I guess I'm still missing some dependencies. Back to the workshop.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/378/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/381/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/382/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:222
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/383/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/154/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/153/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/154/console
    None: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3478/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2737/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3014/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/383/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/385/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-27: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:224
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/426/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/197/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4133/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3145/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5385/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3432/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/426/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2014-09-02: Posted in a previous version of this proposal

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but that's because of a missing dependency that got fixed in telephony-service

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-02:

FAILED: Continuous integration, rev:227
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/434/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/205/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4365/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3268/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5617/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3562/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/434/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-02:

FAILED: Continuous integration, rev:228
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/439/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/210/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4370/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3273/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5622/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3567/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/439/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2014-09-03:

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but that's because it needs a fix done in a separate telephony-service branch

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

lp:~canonical-platform-qa/dialer-app/qmltests1 updated on 2014-09-05

232. By Leo Arias on 2014-09-05: Added a test with a signal spy.
233. By Leo Arias on 2014-09-05: Reverted the pot changes.
234. By Leo Arias on 2014-09-05: Reverted the pot changes.
235. By Leo Arias on 2014-09-05: Reverted the pot changes.
236. By Leo Arias on 2014-09-05: Merged with trunk.
237. By Leo Arias on 2014-09-05: Reverted the pot changes.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/442/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/443/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-06:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/444/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-06:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/445/rebuild

review: Approve (continuous-integration)

lp:~canonical-platform-qa/dialer-app/qmltests1 updated on 2014-09-08

238. By Leo Arias on 2014-09-08: Click the button.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-08:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/446/rebuild

review: Approve (continuous-integration)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2014-09-09:

ack on the packaging change

review: Approve

Revision history for this message

Leo Arias (elopio) wrote on 2014-09-09:

Thanks Didier.

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2014-09-10:

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Canonical Platform QA Team

Ishan Joshi

Ubuntu Phablet Team

 === modified file 'debian/control'
 --- debian/control	2014-09-02 21:06:15 +0000
 +++ debian/control	2014-09-08 17:18:25 +0000
@@ -8,9 +8,13 @@
                 pkg-config,
                 python3-all:any,
                 dh-python,
++               qml-module-qttest,
                 qt5-default,
                 qtbase5-dev (>= 5.0),
                 qtdeclarative5-dev (>= 5.0),
++               qtdeclarative5-dev-tools,
++               qtdeclarative5-ubuntu-ui-toolkit-plugin,
++               xvfb,
  Standards-Version: 3.9.4
  Homepage: https://launchpad.net/dialer-app
  # If you aren't a member of ~phablet-team but need to upload packaging changes,
 === modified file 'debian/rules'
 --- debian/rules	2014-05-22 14:25:18 +0000
 +++ debian/rules	2014-09-08 17:18:25 +0000
@@ -13,7 +13,7 @@
  	dh_auto_configure -- -DCMAKE_BUILD_TYPE=Debug
  override_dh_auto_test:
--	make -C obj-$(DEB_HOST_GNU_TYPE) test
++	CTEST_OUTPUT_ON_FAILURE=1 make -C obj-$(DEB_HOST_GNU_TYPE) test
  override_dh_translations:
  	# Override dh_translations to work around http://pad.lv/1183262.
 === modified file 'src/qml/CMakeLists.txt'
 --- src/qml/CMakeLists.txt	2014-08-22 14:51:14 +0000
 +++ src/qml/CMakeLists.txt	2014-09-08 17:18:25 +0000
@@ -1,3 +1,5 @@
++project(qml)
++
  file(GLOB QML_JS_FILES *.qml *.js)
  # make the files visible on qtcreator
 === modified file 'src/qml/DialerPage/KeypadButton.qml'
 --- src/qml/DialerPage/KeypadButton.qml	2014-08-06 02:49:06 +0000
 +++ src/qml/DialerPage/KeypadButton.qml	2014-09-08 17:18:25 +0000
@@ -33,10 +33,11 @@
      property bool isCorner: false
      property int corner
      property alias pressed: mouseArea.pressed
--
++
      signal keyPressed()
      UbuntuShape {
++        objectName: "keypadButtonUbuntuShape"
          anchors.fill: parent
          opacity: button.pressed ? 1 : 0
@@ -48,6 +49,7 @@
+     }
      Item {
++        objectName: "keypadButtonLabelsContainer"
          height: childrenRect.height
          width: parent.width
          clip: true
 === modified file 'tests/CMakeLists.txt'
 --- tests/CMakeLists.txt	2014-08-13 17:24:42 +0000
 +++ tests/CMakeLists.txt	2014-09-08 17:18:25 +0000
@@ -1,1 +1,3 @@
++add_subdirectory(qml)
++
  add_subdirectory(autopilot)
 === added directory 'tests/qml'
 === added file 'tests/qml/CMakeLists.txt'
 --- tests/qml/CMakeLists.txt	1970-01-01 00:00:00 +0000
 +++ tests/qml/CMakeLists.txt	2014-09-08 17:18:25 +0000
@@ -0,0 +1,31 @@
++find_program(QMLTESTRUNNER_BIN
++    NAMES qmltestrunner
++    PATHS /usr/lib/*/qt5/bin
++    NO_DEFAULT_PATH
++)
++
++find_program(XVFB_RUN_BIN
++    NAMES xvfb-run
++)
++
++macro(DECLARE_QML_TEST TST_NAME TST_QML_FILE)
++    add_test(NAME ${TST_NAME}
++        WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
++        COMMAND ${XVFB_RUN_BIN} -a -s "-screen 0 1024x768x24" ${QMLTESTRUNNER_BIN} -import ${qml_BINARY_DIR} -input ${CMAKE_CURRENT_SOURCE_DIR}/${TST_QML_FILE}
++    )
++endmacro()
++
++if(QMLTESTRUNNER_BIN AND XVFB_RUN_BIN)
++    declare_qml_test("keypad_button" tst_KeypadButton.qml)
++else()
++    if (NOT QMLTESTRUNNER_BIN)
++        message(WARNING "Qml tests disabled: qmltestrunner not found")
++    else()
++        message(WARNING "Qml tests disabled: xvfb-run not found")
++    endif()
++endif()
++
++set(QML_TST_FILES
++    tst_KeypadButton.qml
++)
++add_custom_target(tst_QmlFiles ALL SOURCES ${QML_TST_FILES})
 === added file 'tests/qml/tst_KeypadButton.qml'
 --- tests/qml/tst_KeypadButton.qml	1970-01-01 00:00:00 +0000
 +++ tests/qml/tst_KeypadButton.qml	2014-09-08 17:18:25 +0000
@@ -0,0 +1,103 @@
++/*
++ * Copyright 2014 Canonical Ltd.
++ *
++ * This file is part of dialer-app.
++ *
++ * dialer-app is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * dialer-app is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU General Public License for more details.
++ *
++ * You should have received a copy of the GNU General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++import QtQuick 2.2
++import QtTest 1.0
++import Ubuntu.Test 0.1
++
++import '../../src/qml/DialerPage'
++
++Item {
++    id: root
++
++    width: units.gu(40)
++    height: units.gu(60)
++
++    KeypadButton {
++        id: keypadButton
++        label: 'test label'
++        keycode: 1
++
++        anchors.fill: parent
++    }
++
++    SignalSpy {
++        id: spyOnKeyPressed
++        target: keypadButton
++        signalName: 'keyPressed'
++    }
++
++    UbuntuTestCase {
++        id: keypadButtonTestCase
++        name: 'keypadButtonTestCase'
++
++        when: windowShown
++
++        function init() {
++            waitForRendering(keypadButton);
++        }
++
++        function cleanup() {
++            spyOnKeyPressed.clear()
++        }
++
++        function test_clickButtonMustScaleLabelsContainer() {
++            var labelsContainer = findChild(
++                keypadButton, 'keypadButtonLabelsContainer')
++            compare(labelsContainer.scale, 1)
++
++            mousePress(
++                keypadButton, keypadButton.width / 2, keypadButton.height / 2)
++
++            tryCompare(labelsContainer, 'scale', 0.9)
++
++            mouseRelease(
++                keypadButton, keypadButton.width / 2, keypadButton.height / 2)
++
++            tryCompare(labelsContainer, 'scale', 1)
++        }
++
++        function test_clickButtonMustMakeUbuntuShapeVisible() {
++            var ubuntuShape = findChild(
++                keypadButton, 'keypadButtonUbuntuShape')
++            compare(ubuntuShape.opacity, 0)
++
++            mousePress(
++                keypadButton, keypadButton.width / 2, keypadButton.height / 2)
++
++            tryCompare(ubuntuShape, 'opacity', 1)
++
++            mouseRelease(
++                keypadButton, keypadButton.width / 2, keypadButton.height / 2)
++
++            tryCompare(ubuntuShape, 'opacity', 0)
++        }
++
++        function test_clickButtonMustEmitKeyPressed() {
++            mouseClick(
++                keypadButton, keypadButton.width / 2, keypadButton.height / 2)
++
++            spyOnKeyPressed.wait()
++            compare(
++                spyOnKeyPressed.count, 1,
++                'keyPressed signal was not emitted.')
++        }
++
++    }
++
++}