Merge lp:~canonical-platform-qa/dialer-app/fix1349582-number_format into lp:dialer-app

[Leo Arias]

Set up the locale for autopilot tests.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:199
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/319/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/90
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/89
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/89/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/90
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2613/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2096
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2745/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3856
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3856/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10566
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1750
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2349
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2349/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/319/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:199
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/321/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/92
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/91
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/91/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/92
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2626/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2106
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2758/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3869
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3869/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10586
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1760
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2362
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2362/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/321/rebuild

review: Needs Fixing (continuous-integration)

[Chris Gagnon (chris.gagnon)]

I'd like these tests use the same code formatting standard as the autopilot project (see code comments)

I'd also like to see the tests pass before approving

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:199
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/324/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/95
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/94
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/94/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/95
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2667
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2132
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2790
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3910
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3910/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10633
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1778
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2390
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2390/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/324/rebuild

review: Approve (continuous-integration)

[lp:~canonical-platform-qa/dialer-app/fix1349582-number_format]

200. By Leo Arias on 2014-07-29

Follow the autopilot style for closing parentheses.

[Leo Arias (elopio)]

> I'd like these tests use the same code formatting standard as the autopilot
> project (see code comments)
>
> I'd also like to see the tests pass before approving

Done. And all the tests passing now. Which is a little weird as there's another open bug, I'll take a look there. But anyway, all the tests I touched here are now passing, which is good.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:200
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/326/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/96
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/96/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2684
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2146
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2800
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3927
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3927/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10647
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1785
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2404
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2404/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/326/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

Ok, these results make more sense. The only remaining failures is fixed here:
https://code.launchpad.net/~canonical-platform-qa/dialer-app/fix1349641-swipe_recent/+merge/228594

[Gustavo Pichorim Boiko (boiko)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but the problem is fixed in a separate MR.

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

=== modified file 'tests/autopilot/dialer_app/tests/__init__.py'
--- tests/autopilot/dialer_app/tests/__init__.py	2014-06-19 17:26:34 +0000
+++ tests/autopilot/dialer_app/tests/__init__.py	2014-07-29 23:43:51 +0000
@@ -9,13 +9,17 @@
 
 """Dialer App autopilot tests."""
 
+import fixtures
 from autopilot.input import Mouse, Touch, Pointer
 from autopilot.introspection import get_proxy_object_for_existing_process
 from autopilot.matchers import Eventually
 from autopilot.platform import model
 from autopilot.testcase import AutopilotTestCase
 from testtools.matchers import Equals
-from ubuntuuitoolkit import emulators as toolkit_emulators
+from ubuntuuitoolkit import (
+    emulators as toolkit_emulators,
+    fixture_setup
+)
 from dialer_app import emulators
 from dialer_app import helpers
 
@@ -53,6 +57,8 @@
         self.pointing_device = Pointer(self.input_device_class.create())
         super(DialerAppTestCase, self).setUp()
 
+        self.set_up_locale()
+
         if os.path.exists(self.local_location):
             self.launch_test_local()
         else:
@@ -60,21 +66,28 @@
 
         self.assertThat(self.main_view.visible, Eventually(Equals(True)))
 
+    def set_up_locale(self):
+        # We set up the language to english to check the formatting of the
+        # dialed number.
+        self.useFixture(
+            fixtures.EnvironmentVariable('LANGUAGE', newvalue='en')
+        )
+        self.useFixture(
+            fixture_setup.InitctlEnvironmentVariable(LANGUAGE='en')
+        )
+
     def launch_test_local(self):
         self.app = self.launch_test_application(
             self.local_location,
             app_type='qt',
-            emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
+            emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase
+        )
 
     def launch_test_installed(self):
-        if model() == 'Desktop':
-            self.app = self.launch_test_application(
-                "dialer-app",
-                emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
-        else:
-            self.app = self.launch_upstart_application(
-                "dialer-app",
-                emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
+        self.app = self.launch_upstart_application(
+            'dialer-app',
+            emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase
+        )
 
     def _get_app_proxy_object(self, app_name):
         return get_proxy_object_for_existing_process(