Merge lp:~canonical-platform-qa/dialer-app/call-tests into lp:dialer-app

[Martin Pitt]

Add some incoming/outgoing call tests, using ofono-phonesim.

Add some incoming/outgoing call tests.

These need to be run with ofono-phonesim set up, which can either happen with
merely installing "ofono-phonesim-autostart", or installing ofono-phonesim,
xvfb, and ofono-scripts and running "sudo with-ofono-phonesim" before launching
the tests. If phonesim is not running, the tests are skipped (i. e. they won't
fail without phonesim).

This tests the whole dialer-app → libofono-qt → telephony-service → telepathy-ofono → ofono stack, but does not have any hardware requirements so this can easily run on x86 machines during CI testing.

I launch the tests with

  cd tests/autopilot
  autopilot run dialer_app

(not sure if there's a more standard way for that)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:65
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/77/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-amd64-ci/77
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-armhf-ci/77
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-armhf-ci/77/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-i386-ci/77

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dialer-app-ci/77/rebuild

review: Approve (continuous-integration)

[lp:~canonical-platform-qa/dialer-app/call-tests]

66. By Martin Pitt on 2013-10-10

merge trunk

[Martin Pitt (pitti)]

Merged with latest trunk and re-tested on image 90, still working fine.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:66
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/80/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-amd64-ci/80
    FAILURE: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-armhf-ci/80/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-i386-ci/80

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dialer-app-ci/80/rebuild

review: Needs Fixing (continuous-integration)

[Martin Pitt (pitti)]

ARM build failed with some weird "hudson.remoting.RequestAbortedException: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel", can you please retry?

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:66
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/82/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-amd64-ci/82
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-armhf-ci/82
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-armhf-ci/82/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-saucy-i386-ci/82

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dialer-app-ci/82/rebuild

review: Approve (continuous-integration)

[Gustavo Pichorim Boiko (boiko)]

Looks good.

review: Approve

=== modified file 'src/qml/HistoryPage/HistoryPage.qml'
--- src/qml/HistoryPage/HistoryPage.qml	2013-10-09 14:46:13 +0000
+++ src/qml/HistoryPage/HistoryPage.qml	2013-10-10 09:12:21 +0000
@@ -57,6 +57,8 @@
 
     MultipleSelectionListView {
         id: historyList
+        objectName: "historyList"
+
         property int currentContactExpanded: -1
         anchors.fill: parent
         listModel: sortProxy

=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
--- src/qml/LiveCallPage/LiveCall.qml	2013-10-02 22:00:53 +0000
+++ src/qml/LiveCallPage/LiveCall.qml	2013-10-10 09:12:21 +0000
@@ -28,6 +28,7 @@
 
 Page {
     id: liveCall
+    objectName: "pageLiveCall"
 
     property QtObject call: callManager.foregroundCall
     property string dtmfEntry: ""
@@ -115,6 +116,7 @@
 
     StopWatch {
         id: stopWatch
+        objectName: "stopWatch"
         time: call ? call.elapsedTime : 0
         visible: false
     }
@@ -355,6 +357,7 @@
 
         HangupButton {
             id: hangupButton
+            objectName: "hangupButton"
 
             anchors.horizontalCenter: parent.horizontalCenter
             anchors.verticalCenter: parent.verticalCenter

=== modified file 'tests/autopilot/dialer_app/emulators.py'
--- tests/autopilot/dialer_app/emulators.py	2013-08-21 20:31:27 +0000
+++ tests/autopilot/dialer_app/emulators.py	2013-10-10 09:12:21 +0000
@@ -50,3 +50,6 @@
 
     def get_erase_button(self):
         return self.select_single("CustomButton", objectName="eraseButton")
+
+    def get_call_button(self):
+        return self.select_single(objectName="callButton")

=== added file 'tests/autopilot/dialer_app/tests/test_calls.py'
--- tests/autopilot/dialer_app/tests/test_calls.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/dialer_app/tests/test_calls.py	2013-10-10 09:12:21 +0000
@@ -0,0 +1,193 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright 2013 Canonical
+# Author: Martin Pitt <[e-mail]>
+#
+# This file is part of dialer-app.
+#
+# dialer-app is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+
+"""Tests for the Dialer App using ofono-phonesim"""
+
+from __future__ import absolute_import
+
+import subprocess
+import os
+import time
+
+from autopilot.matchers import Eventually
+from testtools.matchers import Equals, NotEquals
+from testtools import skipUnless
+
+from dialer_app.tests import DialerAppTestCase
+
+# determine whether we are running with phonesim
+try:
+    out = subprocess.check_output(["/usr/share/ofono/scripts/list-modems"],
+                                  stderr=subprocess.PIPE)
+    have_phonesim = out.startswith("[ /phonesim ]")
+except subprocess.CalledProcessError:
+    have_phonesim = False
+
+
+@skipUnless(have_phonesim,
+            "this test needs to run under with-ofono-phonesim")
+class TestCalls(DialerAppTestCase):
+    """Tests for simulated phone calls."""
+
+    def setUp(self):
+        # provide clean history
+        self.history = os.path.expanduser(
+            "~/.local/share/history-service/history.sqlite")
+        if os.path.exists(self.history):
+            subprocess.call(["pkill", "history-daemon"])
+            os.rename(self.history, self.history + ".orig")
+
+        super(TestCalls, self).setUp()
+        self.entry = self.main_view.dialer_page.get_keypad_entry()
+        self.call_button = self.main_view.dialer_page.get_call_button()
+        self.hangup_button = None
+
+        # should have an empty history at the beginning of each test
+        self.history_list = self.app.select_single(objectName="historyList")
+        self.assertThat(self.history_list.visible, Equals(False))
+        self.assertThat(self.history_list.count, Equals(0))
+
+        self.keys = []
+        for i in range(10):
+            self.keys.append(self.main_view.dialer_page.get_keypad_key(str(i)))
+
+    def tearDown(self):
+        super(TestCalls, self).tearDown()
+
+        # ensure that there are no leftover calls in case of failed tests
+        subprocess.call(["/usr/share/ofono/scripts/hangup-all"])
+
+        # restore history
+        if os.path.exists(self.history + ".orig"):
+            subprocess.call(["pkill", "history-daemon"])
+            os.rename(self.history + ".orig", self.history)
+
+    def test_outgoing_noanswer(self):
+        """Outgoing call to a normal number, no answer"""
+
+        self.keypad_dial("144")
+        self.wait_live_call_page("144")
+        self.hangup()
+
+        # log should show call to "Unknown"
+        self.assertThat(self.history_list.count, Equals(1))
+        self.assertThat(self.history_list.select_single(
+            "Label", text="Unknown"), NotEquals(None))
+
+    def test_outgoing_answer_local_hangup(self):
+        """Outgoing call, remote answers, local hangs up"""
+
+        # 06123xx causes accept after xx seconds
+        self.keypad_dial("0612302")
+        self.wait_live_call_page("0612302")
+
+        # stop watch should start counting
+        stop_watch = self.app.select_single(objectName="stopWatch")
+        self.assertIn("00:0", stop_watch.elapsed)
+
+        # should still be connected after some time
+        time.sleep(3)
+        self.assertIn("00:0", stop_watch.elapsed)
+
+        self.hangup()
+
+    def test_outgoing_answer_remote_hangup(self):
+        """Outgoing call, remote answers and hangs up"""
+
+        # 05123xx causes immediate accept and hangup after xx seconds
+        self.keypad_dial("0512303")
+        self.wait_live_call_page("0512303")
+
+        # stop watch should start counting
+        stop_watch = self.app.select_single(objectName="stopWatch")
+        self.assertIn("00:0", stop_watch.elapsed)
+
+        # after remote hangs up, should switch to call log page and show call
+        # to "Unknown"
+        fn = lambda: self.app.select_single(objectName="hangupButton")
+        self.assertThat(fn, Eventually(Equals(None)))
+        self.assertThat(self.history_list.visible, Eventually(Equals(True)))
+        self.assertThat(self.history_list.count, Equals(1))
+        self.assertThat(self.history_list.select_single(
+            "Label", text="Unknown"), NotEquals(None))
+
+    def test_incoming(self):
+        """Incoming call"""
+
+        # magic number 199 will cause a callback from 1234567; dialing 199
+        # itself will fail, so quiesce the error
+        subprocess.call(["/usr/share/ofono/scripts/dial-number", "199"],
+                        stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+
+        # wait for incoming call, accept; it would be nicer to fake-click the
+        # popup notification, but as this isn't generated by dialer-app it
+        # isn't exposed to autopilot
+        self.wait_for_incoming_call()
+        subprocess.call(["/usr/share/ofono/scripts/answer-calls"],
+                        stdout=subprocess.PIPE)
+
+        # call back is from that number
+        self.wait_live_call_page("1234567")
+
+        # stop watch should start counting
+        stop_watch = self.app.select_single(objectName="stopWatch")
+        self.assertIn("00:0", stop_watch.elapsed)
+
+        self.hangup()
+
+    #
+    # Helper methods
+    #
+
+    def keypad_dial(self, number):
+        """Dial given number (string) on the keypad and call"""
+        for digit in number:
+            self.pointing_device.click_object(self.keys[int(digit)])
+        self.assertThat(self.entry.value, Eventually(Equals(number)))
+
+        self.pointing_device.click_object(self.call_button)
+
+    def wait_live_call_page(self, number):
+        """Wait until live call page gets visible
+
+        Sets self.hangup_button.
+        """
+        fn = lambda: self.app.select_single(objectName="hangupButton")
+        self.assertThat(fn, Eventually(NotEquals(None)))
+        self.hangup_button = self.app.select_single(objectName="hangupButton")
+        self.assertThat(self.hangup_button.visible, Eventually(Equals(True)))
+        self.assertThat(self.call_button.visible, Equals(False))
+
+        # should show called number in title page
+        lcp = self.app.select_single(objectName="pageLiveCall")
+        self.assertThat(lcp.title, Equals(number))
+
+    def wait_for_incoming_call(self):
+        """Wait up to 5 s for an incoming phone call"""
+
+        timeout = 10
+        while timeout >= 0:
+            out = subprocess.check_output(
+                ["/usr/share/ofono/scripts/list-calls"],
+                stderr=subprocess.PIPE)
+            if "State = incoming" in out:
+                break
+            timeout -= 1
+            time.sleep(0.5)
+        else:
+            self.fail("timed out waiting for incoming phonesim call")
+
+    def hangup(self):
+        self.pointing_device.click_object(self.hangup_button)
+        fn = lambda: self.app.select_single(objectName="hangupButton")
+        self.assertThat(fn, Eventually(Equals(None)))
+
+        # should switch to call log page
+        self.assertThat(self.history_list.visible, Eventually(Equals(True)))