Dekko

Merge lp:~canonical-platform-qa/dekko/add_object_names_part1 into lp:~dpniel/dekko/trunk2

  1. add_object_names_part1
  2. Merge into trunk2
Proposed by Omer Akram
Status: Needs review
Proposed branch: lp:~canonical-platform-qa/dekko/add_object_names_part1
Merge into: lp:~dpniel/dekko/trunk2
Diff against target: 130 lines (+13/-1)
8 files modified
qml/MessageListView/MessageListPage.qml (+1/-0)
qml/SetupWizard/CredentialValidation.qml (+1/-0)
qml/SetupWizard/DetailsInput.qml (+2/-1)
qml/SetupWizard/IdentityInput.qml (+1/-0)
qml/SetupWizard/NewAccountPage.qml (+2/-0)
qml/SetupWizard/NewAccountTypeListView.qml (+1/-0)
qml/SetupWizard/NoAccountsPage.qml (+2/-0)
qml/SetupWizard/UserInput.qml (+3/-0)
To merge this branch: bzr merge lp:~canonical-platform-qa/dekko/add_object_names_part1
Reviewer Review Type Date Requested Status
Dan Chapman  Pending
Review via email: mp+291044@code.launchpad.net

Commit message

Add objectNames to be used for autopilot testing

Description of the change

Add objectNames to be used for autopilot testing in the lp:ubuntu-system-tests project

Note: this is just an initial set of objectNames, required for a test I am working on, I will create more pull requests as the need arise.

To post a comment you must log in.
lp:~canonical-platform-qa/dekko/add_object_names_part1 updated
739. By Omer Akram

right place

740. By Omer Akram

Add objectName for credentials verification screen

Unmerged revisions

740. By Omer Akram

Add objectName for credentials verification screen

739. By Omer Akram

right place

738. By Omer Akram

Add initial set of objectNames

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/MessageListView/MessageListPage.qml'
2--- qml/MessageListView/MessageListPage.qml 2016-02-08 12:36:26 +0000
3+++ qml/MessageListView/MessageListPage.qml 2016-04-06 05:45:04 +0000
4@@ -29,6 +29,7 @@
5
6 DekkoPage {
7 id: messageListPage
8+ objectName: "emailListPage"
9 pageTitle: dekko.currentAccount.msgListModel.unreadCount ? qsTr("Inbox %1").arg(dekko.currentAccount.msgListModel.unreadCount ) : qsTr("Inbox")
10
11 function updateTitle() {
12
13=== modified file 'qml/SetupWizard/CredentialValidation.qml'
14--- qml/SetupWizard/CredentialValidation.qml 2016-02-08 12:36:25 +0000
15+++ qml/SetupWizard/CredentialValidation.qml 2016-04-06 05:45:04 +0000
16@@ -20,6 +20,7 @@
17
18 ProcessingOverlay {
19 id: credentialValidation
20+ objectName: "credentialValidation"
21
22 signal failedWithErrorMessage(string message)
23
24
25=== modified file 'qml/SetupWizard/DetailsInput.qml'
26--- qml/SetupWizard/DetailsInput.qml 2016-02-08 12:36:26 +0000
27+++ qml/SetupWizard/DetailsInput.qml 2016-04-06 05:45:04 +0000
28@@ -24,8 +24,9 @@
29
30 Item {
31 id: userInput
32+ objectName: "accountDetailExtraScreen"
33 anchors.fill: parent
34-
35+
36 signal back()
37 signal inputComplete()
38
39
40=== modified file 'qml/SetupWizard/IdentityInput.qml'
41--- qml/SetupWizard/IdentityInput.qml 2016-02-08 12:36:26 +0000
42+++ qml/SetupWizard/IdentityInput.qml 2016-04-06 05:45:04 +0000
43@@ -24,6 +24,7 @@
44
45 Item {
46 id: userInput
47+ objectName: "userIdentityInputScreen"
48 anchors.fill: parent
49
50 signal back()
51
52=== modified file 'qml/SetupWizard/NewAccountPage.qml'
53--- qml/SetupWizard/NewAccountPage.qml 2016-02-08 12:36:26 +0000
54+++ qml/SetupWizard/NewAccountPage.qml 2016-04-06 05:45:04 +0000
55@@ -22,6 +22,7 @@
56
57 Page {
58 id: newAccountPage
59+ objectName: "accountTypeListPage"
60 flickable: null
61 signal next()
62 signal createNewOA()
63@@ -36,6 +37,7 @@
64 }
65
66 NewAccountTypeListView {
67+ objectName: "accountTypeList"
68 anchors {
69 top: header.bottom
70 left: parent.left
71
72=== modified file 'qml/SetupWizard/NewAccountTypeListView.qml'
73--- qml/SetupWizard/NewAccountTypeListView.qml 2016-02-08 12:36:26 +0000
74+++ qml/SetupWizard/NewAccountTypeListView.qml 2016-04-06 05:45:04 +0000
75@@ -48,6 +48,7 @@
76 // }
77
78 delegate: AccountsDrawerDelegate {
79+ objectName: "newAccountListItem_" + model.serviceName
80 text: description
81 iconSource: model.icon
82 onClicked: {
83
84=== modified file 'qml/SetupWizard/NoAccountsPage.qml'
85--- qml/SetupWizard/NoAccountsPage.qml 2016-02-08 12:36:26 +0000
86+++ qml/SetupWizard/NoAccountsPage.qml 2016-04-06 05:45:04 +0000
87@@ -23,6 +23,7 @@
88
89 Item {
90 id: accountsPage
91+ objectName: "noAccountsPage"
92 anchors.fill: parent
93
94 DekkoHeader {
95@@ -57,6 +58,7 @@
96
97 Button {
98 id: btn
99+ objectName "addAccountButton"
100 anchors {
101 top: emptyState.bottom
102 topMargin: units.gu(4)
103
104=== modified file 'qml/SetupWizard/UserInput.qml'
105--- qml/SetupWizard/UserInput.qml 2016-02-08 12:36:26 +0000
106+++ qml/SetupWizard/UserInput.qml 2016-04-06 05:45:04 +0000
107@@ -23,6 +23,7 @@
108
109 Item {
110 id: userInput
111+ objectName: "usernamePasswordArea"
112 anchors.fill: parent
113
114 signal back()
115@@ -153,6 +154,7 @@
116 spacing: units.gu(1)
117 TitledTextField {
118 id: emailField
119+ objectName: "emailField"
120 text: wizard.accountType === NewAccountType.SMTP ? wizard.account.smtpSettings.username : wizard.account.imapSettings.username
121 requiredField: nonValidUsernameField
122 inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhEmailCharactersOnly | Qt.ImhNoPredictiveText
123@@ -171,6 +173,7 @@
124
125 TitledTextField {
126 id: passwordField
127+ objectName: "passwordField"
128 title: qsTr("Password")
129 text: wizard.tempPasswordStore
130 inputMethodHints: Qt.ImhHiddenText | Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText

Subscribers

People subscribed via source and target branches