camera-app

Merge lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open into lp:camera-app

  1. drag_too_fast_to_open
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Superseded
Proposed branch: lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open
Merge into: lp:camera-app
Diff against target: 13 lines (+1/-2)
1 file modified
tests/autopilot/camera_app/emulators/panel.py (+1/-2)
To merge this branch: bzr merge lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+278689@code.launchpad.net

This proposal has been superseded by a proposal from 2015-11-26.

Commit message

Remove rate parameter from drag call in _drag_to_open as it was not opening the panel when dragged that fast.

Description of the change

The _drag_to_open helper was passing a rate=sys.maxintsize to the drag command. This represents a very fast drag action and apparently this wasn't being registered so the panel didn't open.

Removing the parameter to use the default drag speed fixes it.

To post a comment you must log in.
lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open updated
609. By Brendan Donegan

Do the same for _drag_to_close

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/camera_app/emulators/panel.py'
2--- tests/autopilot/camera_app/emulators/panel.py 2015-04-29 15:56:44 +0000
3+++ tests/autopilot/camera_app/emulators/panel.py 2015-11-26 12:24:15 +0000
4@@ -39,8 +39,7 @@
5 start_y = y + self.height - 1
6 stop_y = y
7
8- self.pointing_device.drag(
9- line_x, start_y, line_x, stop_y, rate=sys.maxsize)
10+ self.pointing_device.drag(line_x, start_y, line_x, stop_y)
11
12 @autopilot_logging.log_action(logger.info)
13 def close(self):

Subscribers

People subscribed via source and target branches